X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=src%2Fhardware%2Flink-mso19%2Fapi.c;h=dd3ff3c80c8923195b18f253f16f4b560f0f61cd;hb=8cd15dd4ce2fdbefbcc6e64632c8006e5404f253;hp=c3abb0ae8de738e653c3d5a3977f16767d963bf5;hpb=709468baf7626b162b5559c101516289d9bbb258;p=libsigrok.git diff --git a/src/hardware/link-mso19/api.c b/src/hardware/link-mso19/api.c index c3abb0ae..dd3ff3c8 100644 --- a/src/hardware/link-mso19/api.c +++ b/src/hardware/link-mso19/api.c @@ -22,9 +22,12 @@ #include #include "protocol.h" -static const uint32_t devopts[] = { +static const uint32_t drvopts[] = { SR_CONF_OSCILLOSCOPE, SR_CONF_LOGIC_ANALYZER, +}; + +static const uint32_t devopts[] = { SR_CONF_LIMIT_SAMPLES | SR_CONF_SET, SR_CONF_SAMPLERATE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST, SR_CONF_TRIGGER_TYPE | SR_CONF_LIST, @@ -50,40 +53,9 @@ static const uint64_t samplerates[] = { SR_HZ(100), }; -SR_PRIV struct sr_dev_driver link_mso19_driver_info; - -/* TODO: Use sr_dev_inst to store connection handle & use std_dev_clear(). */ -static int dev_clear(const struct sr_dev_driver *di) -{ - struct drv_context *drvc = di->context; - GSList *l; - struct sr_dev_inst *sdi; - struct dev_context *devc; - int ret = SR_OK; - - /* Properly close and free all devices. */ - for (l = drvc->instances; l; l = l->next) { - if (!(sdi = l->data)) { - /* Log error, but continue cleaning up the rest. */ - sr_err("%s: sdi was NULL, continuing", __func__); - ret = SR_ERR_BUG; - continue; - } - if (!(devc = sdi->priv)) { - /* Log error, but continue cleaning up the rest. */ - sr_err("%s: sdi->priv was NULL, continuing", __func__); - ret = SR_ERR_BUG; - continue; - } - std_serial_dev_close(sdi); - sr_serial_dev_inst_free(devc->serial); - sr_dev_inst_free(sdi); - } - g_slist_free(drvc->instances); - drvc->instances = NULL; - - return ret; -} +static const char *trigger_slopes[2] = { + "r", "f", +}; static GSList *scan(struct sr_dev_driver *di, GSList *options) { @@ -194,30 +166,15 @@ static GSList *scan(struct sr_dev_driver *di, GSList *options) sdi->vendor = g_strdup(manufacturer); sdi->model = g_strdup(product); sdi->version = g_strdup(hwrev); - - if (!sdi) { - sr_err("Unable to create device instance for %s", - sysname); - sr_dev_inst_free(sdi); - g_free(devc); - return devices; - } - - sdi->driver = di; sdi->priv = devc; for (i = 0; i < ARRAY_SIZE(channel_names); i++) { chtype = (i == 0) ? SR_CHANNEL_ANALOG : SR_CHANNEL_LOGIC; sr_channel_new(sdi, i, chtype, TRUE, channel_names[i]); } - - //Add the driver - struct drv_context *drvc = di->context; - drvc->instances = g_slist_append(drvc->instances, sdi); - devices = g_slist_append(devices, sdi); } - return devices; + return std_scan_complete(di, devices); } static int dev_open(struct sr_dev_inst *sdi) @@ -230,8 +187,6 @@ static int dev_open(struct sr_dev_inst *sdi) if (serial_open(devc->serial, SERIAL_RDWR) != SR_OK) return SR_ERR; - sdi->status = SR_ST_ACTIVE; - /* FIXME: discard serial buffer */ mso_check_trigger(devc->serial, &devc->trigger_state); sr_dbg("Trigger state: 0x%x.", devc->trigger_state); @@ -251,8 +206,8 @@ static int dev_open(struct sr_dev_inst *sdi) return SR_OK; } -static int config_get(int key, GVariant **data, const struct sr_dev_inst *sdi, - const struct sr_channel_group *cg) +static int config_get(int key, GVariant **data, + const struct sr_dev_inst *sdi, const struct sr_channel_group *cg) { struct dev_context *devc; @@ -274,10 +229,9 @@ static int config_get(int key, GVariant **data, const struct sr_dev_inst *sdi, return SR_OK; } -static int config_set(int key, GVariant *data, const struct sr_dev_inst *sdi, - const struct sr_channel_group *cg) +static int config_set(int key, GVariant *data, + const struct sr_dev_inst *sdi, const struct sr_channel_group *cg) { - int ret; struct dev_context *devc; uint64_t num_samples; const char *slope; @@ -288,82 +242,51 @@ static int config_set(int key, GVariant *data, const struct sr_dev_inst *sdi, devc = sdi->priv; - if (sdi->status != SR_ST_ACTIVE) - return SR_ERR_DEV_CLOSED; - switch (key) { case SR_CONF_SAMPLERATE: // FIXME return mso_configure_rate(sdi, g_variant_get_uint64(data)); - ret = SR_OK; - break; case SR_CONF_LIMIT_SAMPLES: num_samples = g_variant_get_uint64(data); if (num_samples != 1024) { sr_err("Only 1024 samples are supported."); - ret = SR_ERR_ARG; - } else { - devc->limit_samples = num_samples; - ret = SR_OK; + return SR_ERR_ARG; } + devc->limit_samples = num_samples; break; case SR_CONF_CAPTURE_RATIO: - ret = SR_OK; break; case SR_CONF_TRIGGER_SLOPE: - slope = g_variant_get_string(data, NULL); - - if (!slope || !(slope[0] == 'f' || slope[0] == 'r')) - sr_err("Invalid trigger slope"); - ret = SR_ERR_ARG; - } else { - devc->trigger_slope = (slope[0] == 'r') - ? SLOPE_POSITIVE : SLOPE_NEGATIVE; - ret = SR_OK; - } + if ((idx = std_str_idx(data, ARRAY_AND_SIZE(trigger_slopes))) < 0) + return SR_ERR_ARG; + devc->trigger_slope = idx; break; case SR_CONF_HORIZ_TRIGGERPOS: pos = g_variant_get_double(data); if (pos < 0 || pos > 255) { sr_err("Trigger position (%f) should be between 0 and 255.", pos); - ret = SR_ERR_ARG; - } else { - trigger_pos = (int)pos; - devc->trigger_holdoff[0] = trigger_pos & 0xff; - ret = SR_OK; + return SR_ERR_ARG; } + trigger_pos = (int)pos; + devc->trigger_holdoff[0] = trigger_pos & 0xff; break; case SR_CONF_RLE: - ret = SR_OK; break; default: - ret = SR_ERR_NA; - break; + return SR_ERR_NA; } - return ret; + return SR_OK; } -static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi, - const struct sr_channel_group *cg) +static int config_list(int key, GVariant **data, + const struct sr_dev_inst *sdi, const struct sr_channel_group *cg) { - GVariant *gvar; - GVariantBuilder gvb; - - (void)cg; - (void)sdi; - switch (key) { case SR_CONF_DEVICE_OPTIONS: - *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32, - devopts, ARRAY_SIZE(devopts), sizeof(uint32_t)); - break; + return STD_CONFIG_LIST(key, data, sdi, cg, NO_OPTS, drvopts, devopts); case SR_CONF_SAMPLERATE: - g_variant_builder_init(&gvb, G_VARIANT_TYPE("a{sv}")); - gvar = g_variant_new_fixed_array(G_VARIANT_TYPE("t"), samplerates, - ARRAY_SIZE(samplerates), sizeof(uint64_t)); - g_variant_builder_add(&gvb, "{sv}", "samplerate-steps", gvar); - *data = g_variant_builder_end(&gvb); + *data = std_gvar_samplerates_steps(ARRAY_AND_SIZE(samplerates)); break; case SR_CONF_TRIGGER_TYPE: *data = g_variant_new_string(TRIGGER_TYPE); @@ -380,9 +303,6 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi) struct dev_context *devc; int ret = SR_ERR; - if (sdi->status != SR_ST_ACTIVE) - return SR_ERR_DEV_CLOSED; - devc = sdi->priv; if (mso_configure_channels(sdi) != SR_OK) { @@ -430,7 +350,7 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi) /* Reset trigger state. */ devc->trigger_state = 0x00; - std_session_send_df_header(sdi, LOG_PREFIX); + std_session_send_df_header(sdi); /* Our first channel is analog, the other 8 are of type 'logic'. */ /* TODO. */ @@ -441,7 +361,6 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi) return SR_OK; } -/* This stops acquisition on ALL devices, ignoring dev_index. */ static int dev_acquisition_stop(struct sr_dev_inst *sdi) { stop_acquisition(sdi); @@ -449,7 +368,7 @@ static int dev_acquisition_stop(struct sr_dev_inst *sdi) return SR_OK; } -SR_PRIV struct sr_dev_driver link_mso19_driver_info = { +static struct sr_dev_driver link_mso19_driver_info = { .name = "link-mso19", .longname = "Link Instruments MSO-19", .api_version = 1, @@ -457,7 +376,7 @@ SR_PRIV struct sr_dev_driver link_mso19_driver_info = { .cleanup = std_cleanup, .scan = scan, .dev_list = std_dev_list, - .dev_clear = dev_clear, + .dev_clear = std_dev_clear, .config_get = config_get, .config_set = config_set, .config_list = config_list, @@ -467,3 +386,4 @@ SR_PRIV struct sr_dev_driver link_mso19_driver_info = { .dev_acquisition_stop = dev_acquisition_stop, .context = NULL, }; +SR_REGISTER_DEV_DRIVER(link_mso19_driver_info);