X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=pv%2Fviews%2Fviewbase.cpp;h=ff3a4fdbbb3e30be432667338dba559f0806e0bd;hb=0bb3dd25421a8638afb881d46799a13378d3f00b;hp=69be61c892b67a5815b0096db1d78ea516ef4eac;hpb=a24412db987328f80cf32d8299d82b72a441c239;p=pulseview.git

diff --git a/pv/views/viewbase.cpp b/pv/views/viewbase.cpp
index 69be61c8..ff3a4fdb 100644
--- a/pv/views/viewbase.cpp
+++ b/pv/views/viewbase.cpp
@@ -34,9 +34,10 @@ namespace pv {
 namespace views {
 
 const char* ViewTypeNames[ViewTypeCount] = {
-		"Trace View",
+	"Trace View",
 #ifdef ENABLE_DECODE
-		"Decoder Output View"
+	"Binary Decoder Output View",
+	"Tabular Decoder Output View"
 #endif
 };
 
@@ -63,6 +64,11 @@ ViewBase::ViewBase(Session &session, bool is_main_view, QMainWindow *parent) :
 	delayed_view_updater_.setInterval(1000 / MaxViewAutoUpdateRate);
 }
 
+bool ViewBase::is_main_view() const
+{
+	return is_main_view_;
+}
+
 void ViewBase::reset_view_state()
 {
 	current_segment_ = 0;
@@ -78,11 +84,7 @@ const Session& ViewBase::session() const
 	return session_;
 }
 
-void ViewBase::clear_signals()
-{
-}
-
-unordered_set< shared_ptr<data::SignalBase> > ViewBase::signalbases() const
+vector< shared_ptr<data::SignalBase> > ViewBase::signalbases() const
 {
 	return signalbases_;
 }
@@ -101,7 +103,7 @@ void ViewBase::clear_signalbases()
 
 void ViewBase::add_signalbase(const shared_ptr<data::SignalBase> signalbase)
 {
-	signalbases_.insert(signalbase);
+	signalbases_.push_back(signalbase);
 
 	connect(signalbase.get(), SIGNAL(samples_cleared()),
 		this, SLOT(on_data_updated()));
@@ -109,19 +111,35 @@ void ViewBase::add_signalbase(const shared_ptr<data::SignalBase> signalbase)
 		this, SLOT(on_samples_added(uint64_t, uint64_t, uint64_t)));
 }
 
+void ViewBase::remove_signalbase(const shared_ptr<data::SignalBase> signalbase)
+{
+	disconnect(signalbase.get(), SIGNAL(samples_cleared()),
+		this, SLOT(on_data_updated()));
+	disconnect(signalbase.get(), SIGNAL(samples_added(uint64_t, uint64_t, uint64_t)),
+		this, SLOT(on_samples_added(uint64_t, uint64_t, uint64_t)));
+
+	signalbases_.erase(std::remove_if(signalbases_.begin(), signalbases_.end(),
+		[&](shared_ptr<data::SignalBase> s) { return s == signalbase; }),
+		signalbases_.end());
+}
+
 #ifdef ENABLE_DECODE
 void ViewBase::clear_decode_signals()
 {
+	decode_signals_.clear();
 }
 
 void ViewBase::add_decode_signal(shared_ptr<data::DecodeSignal> signal)
 {
-	(void)signal;
+	decode_signals_.push_back(signal);
 }
 
 void ViewBase::remove_decode_signal(shared_ptr<data::DecodeSignal> signal)
 {
-	(void)signal;
+	decode_signals_.erase(std::remove_if(
+		decode_signals_.begin(), decode_signals_.end(),
+		[&](shared_ptr<data::DecodeSignal> s) { return s == signal; }),
+		decode_signals_.end());
 }
 #endif
 
@@ -135,6 +153,12 @@ void ViewBase::restore_settings(QSettings &settings)
 	(void)settings;
 }
 
+void ViewBase::focus_on_range(uint64_t start_sample, uint64_t end_sample)
+{
+	(void)start_sample;
+	(void)end_sample;
+}
+
 void ViewBase::trigger_event(int segment_id, util::Timestamp location)
 {
 	(void)segment_id;