X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Fview.cpp;h=227fadfdb4197c334d084dd9a19edb37e4728181;hb=6202cf13abc361af4d1419dc56eaabc314900692;hp=40ecc195cea44e9cd5d204b525c2386c8c618baa;hpb=e887fe9e6ede73b9fe9ace9c6bfd4f6a096eb3b2;p=pulseview.git

diff --git a/pv/views/trace/view.cpp b/pv/views/trace/view.cpp
index 40ecc195..227fadfd 100644
--- a/pv/views/trace/view.cpp
+++ b/pv/views/trace/view.cpp
@@ -94,8 +94,10 @@ const Timestamp View::MinScale("1e-12");
 
 const int View::MaxScrollValue = INT_MAX / 2;
 
-const int View::ScaleUnits[3] = {1, 2, 5};
+/* Area at the top and bottom of the view that can't be scrolled out of sight */
+const int View::ViewScrollMargin = 50;
 
+const int View::ScaleUnits[3] = {1, 2, 5};
 
 CustomScrollArea::CustomScrollArea(QWidget *parent) :
 	QAbstractScrollArea(parent)
@@ -201,6 +203,7 @@ View::View(Session &session, bool is_main_view, QMainWindow *parent) :
 	connect(&lazy_event_handler_, SIGNAL(timeout()),
 		this, SLOT(process_sticky_events()));
 	lazy_event_handler_.setSingleShot(true);
+	lazy_event_handler_.setInterval(1000 / ViewBase::MaxViewAutoUpdateRate);
 
 	// Set up local keyboard shortcuts
 	zoom_in_shortcut_ = new QShortcut(QKeySequence(Qt::Key_Plus), this,
@@ -315,7 +318,7 @@ const Session& View::session() const
 	return session_;
 }
 
-unordered_set< shared_ptr<Signal> > View::signals() const
+vector< shared_ptr<Signal> > View::signals() const
 {
 	return signals_;
 }
@@ -342,7 +345,7 @@ void View::clear_signals()
 void View::add_signal(const shared_ptr<Signal> signal)
 {
 	ViewBase::add_signalbase(signal->base());
-	signals_.insert(signal);
+	signals_.push_back(signal);
 
 	signal->set_segment_display_mode(segment_display_mode_);
 	signal->set_current_segment(current_segment_);
@@ -808,13 +811,13 @@ void View::set_scale_offset(double scale, const Timestamp& offset)
 	viewport_->update();
 }
 
-set< shared_ptr<SignalData> > View::get_visible_data() const
+vector< shared_ptr<SignalData> > View::get_visible_data() const
 {
 	// Make a set of all the visible data objects
-	set< shared_ptr<SignalData> > visible_data;
+	vector< shared_ptr<SignalData> > visible_data;
 	for (const shared_ptr<Signal>& sig : signals_)
 		if (sig->enabled())
-			visible_data.insert(sig->data());
+			visible_data.push_back(sig->data());
 
 	return visible_data;
 }
@@ -822,8 +825,14 @@ set< shared_ptr<SignalData> > View::get_visible_data() const
 pair<Timestamp, Timestamp> View::get_time_extents() const
 {
 	boost::optional<Timestamp> left_time, right_time;
-	const set< shared_ptr<SignalData> > visible_data = get_visible_data();
-	for (const shared_ptr<SignalData>& d : visible_data) {
+
+	vector< shared_ptr<SignalData> > data;
+	if (signals_.size() == 0)
+		return make_pair(0, 0);
+
+	data.push_back(signals_.front()->data());
+
+	for (const shared_ptr<SignalData>& d : data) {
 		const vector< shared_ptr<Segment> > segments = d->segments();
 		for (const shared_ptr<Segment>& s : segments) {
 			double samplerate = s->samplerate();
@@ -1245,9 +1254,13 @@ void View::update_scroll()
 	const pair<int, int> extents = v_extents();
 
 	// Don't change the scrollbar range if there are no traces
-	if (extents.first != extents.second)
-		vscrollbar->setRange(extents.first - areaSize.height(),
-			extents.second);
+	if (extents.first != extents.second) {
+		int top_margin = ViewScrollMargin;
+		int btm_margin = ViewScrollMargin;
+
+		vscrollbar->setRange(extents.first - areaSize.height() + top_margin,
+			extents.second - btm_margin);
+	}
 
 	if (scroll_needs_defaults_) {
 		set_scroll_default();
@@ -1547,8 +1560,8 @@ void View::extents_changed(bool horz, bool vert)
 		(horz ? TraceTreeItemHExtentsChanged : 0) |
 		(vert ? TraceTreeItemVExtentsChanged : 0);
 
-	lazy_event_handler_.stop();
-	lazy_event_handler_.start();
+	if (!lazy_event_handler_.isActive())
+		lazy_event_handler_.start();
 }
 
 void View::on_signal_name_changed()
@@ -1909,6 +1922,8 @@ void View::on_segment_changed(int segment)
 
 void View::on_settingViewTriggerIsZeroTime_changed(const QVariant new_value)
 {
+	(void)new_value;
+
 	if (!custom_zero_offset_set_)
 		reset_zero_position();
 }