X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Fdecodetrace.cpp;h=f76e43a8470427faee0601c3238b0dfc813fd43a;hb=15784350767c05f3afb2f9af0c4b212a89493e30;hp=f68ded99edd92f2adec0fa47d5bb53c16cde3b16;hpb=0cbadf1c6a80ec37481ae11ee3cb709eeffda3e7;p=pulseview.git diff --git a/pv/views/trace/decodetrace.cpp b/pv/views/trace/decodetrace.cpp index f68ded99..f76e43a8 100644 --- a/pv/views/trace/decodetrace.cpp +++ b/pv/views/trace/decodetrace.cpp @@ -21,6 +21,7 @@ extern "C" { #include } +#include #include #include @@ -30,11 +31,15 @@ extern "C" { #include #include +#include #include +#include #include #include #include +#include #include +#include #include #include "decodetrace.hpp" @@ -56,6 +61,7 @@ using std::abs; using std::make_pair; using std::max; using std::min; +using std::numeric_limits; using std::out_of_range; using std::pair; using std::shared_ptr; @@ -96,6 +102,11 @@ DecodeTrace::DecodeTrace(pv::Session &session, { decode_signal_ = dynamic_pointer_cast(base_); + GlobalSettings settings; + always_show_all_rows_ = settings.value(GlobalSettings::Key_Dec_AlwaysShowAllRows).toBool(); + + GlobalSettings::add_change_handler(this); + // Determine shortest string we want to see displayed in full QFontMetrics m(QApplication::font()); min_useful_label_width_ = m.width("XX"); // e.g. two hex characters @@ -131,6 +142,11 @@ DecodeTrace::DecodeTrace(pv::Session &session, delayed_trace_updater_.setInterval(1000 / MaxTraceUpdateRate); } +DecodeTrace::~DecodeTrace() +{ + GlobalSettings::remove_change_handler(this); +} + bool DecodeTrace::enabled() const { return true; @@ -163,23 +179,20 @@ void DecodeTrace::paint_mid(QPainter &p, ViewItemPaintParams &pp) row_height_ = (text_height * 6) / 4; const int annotation_height = (text_height * 5) / 4; - const QString err = decode_signal_->error_message(); - if (!err.isEmpty()) { - draw_unresolved_period( - p, annotation_height, pp.left(), pp.right()); - draw_error(p, err, pp); - return; - } - // Set default pen to allow for text width calculation p.setPen(Qt::black); // Iterate through the rows int y = get_visual_y(); - pair sample_range = get_sample_range( - pp.left(), pp.right()); + pair sample_range = get_view_sample_range(pp.left(), pp.right()); + + // Just because the view says we see a certain sample range it + // doesn't mean we have this many decoded samples, too, so crop + // the range to what has been decoded already + sample_range.second = min((int64_t)sample_range.second, + decode_signal_->get_decoded_sample_count(current_segment_, false)); - const vector rows = decode_signal_->visible_rows(); + const vector rows = decode_signal_->get_rows(!always_show_all_rows_); visible_rows_.clear(); for (const Row& row : rows) { @@ -197,17 +210,14 @@ void DecodeTrace::paint_mid(QPainter &p, ViewItemPaintParams &pp) vector annotations; decode_signal_->get_annotation_subset(annotations, row, current_segment_, sample_range.first, sample_range.second); - if (!annotations.empty()) { + if (always_show_all_rows_ || !annotations.empty()) { draw_annotations(annotations, p, annotation_height, pp, y, - get_row_color(visible_rows_.size()), row_title_width); - + get_row_color(row.index()), row_title_width); y += row_height_; - visible_rows_.push_back(row); } } - // Draw the hatching draw_unresolved_period(p, annotation_height, pp.left(), pp.right()); if ((int)visible_rows_.size() > max_visible_rows_) { @@ -217,6 +227,10 @@ void DecodeTrace::paint_mid(QPainter &p, ViewItemPaintParams &pp) owner_->extents_changed(false, true); owner_->row_item_appearance_changed(false, true); } + + const QString err = decode_signal_->error_message(); + if (!err.isEmpty()) + draw_error(p, err, pp); } void DecodeTrace::paint_fore(QPainter &p, ViewItemPaintParams &pp) @@ -260,6 +274,33 @@ void DecodeTrace::paint_fore(QPainter &p, ViewItemPaintParams &pp) paint_hover_marker(p); } +void DecodeTrace::update_stack_button() +{ + const vector< shared_ptr > &stack = decode_signal_->decoder_stack(); + + // Only show decoders in the menu that can be stacked onto the last one in the stack + if (!stack.empty()) { + const srd_decoder* d = stack.back()->decoder(); + + if (d->outputs) { + pv::widgets::DecoderMenu *const decoder_menu = + new pv::widgets::DecoderMenu(stack_button_, (const char*)(d->outputs->data)); + connect(decoder_menu, SIGNAL(decoder_selected(srd_decoder*)), + this, SLOT(on_stack_decoder(srd_decoder*))); + + decoder_menu->setStyleSheet("QMenu { menu-scrollable: 1; }"); + + stack_button_->setMenu(decoder_menu); + stack_button_->show(); + return; + } + } + + // No decoders available for stacking + stack_button_->setMenu(nullptr); + stack_button_->hide(); +} + void DecodeTrace::populate_popup_form(QWidget *parent, QFormLayout *form) { using pv::data::decode::Decoder; @@ -294,24 +335,18 @@ void DecodeTrace::populate_popup_form(QWidget *parent, QFormLayout *form) } // Add stacking button - pv::widgets::DecoderMenu *const decoder_menu = - new pv::widgets::DecoderMenu(parent); - connect(decoder_menu, SIGNAL(decoder_selected(srd_decoder*)), - this, SLOT(on_stack_decoder(srd_decoder*))); - - QPushButton *const stack_button = - new QPushButton(tr("Stack Decoder"), parent); - stack_button->setMenu(decoder_menu); - stack_button->setToolTip(tr("Stack a higher-level decoder on top of this one")); + stack_button_ = new QPushButton(tr("Stack Decoder"), parent); + stack_button_->setToolTip(tr("Stack a higher-level decoder on top of this one")); + update_stack_button(); QHBoxLayout *stack_button_box = new QHBoxLayout; - stack_button_box->addWidget(stack_button, 0, Qt::AlignRight); + stack_button_box->addWidget(stack_button_, 0, Qt::AlignRight); form->addRow(stack_button_box); } -QMenu* DecodeTrace::create_context_menu(QWidget *parent) +QMenu* DecodeTrace::create_header_context_menu(QWidget *parent) { - QMenu *const menu = Trace::create_context_menu(parent); + QMenu *const menu = Trace::create_header_context_menu(parent); menu->addSeparator(); @@ -323,6 +358,118 @@ QMenu* DecodeTrace::create_context_menu(QWidget *parent) return menu; } +QMenu* DecodeTrace::create_view_context_menu(QWidget *parent, QPoint &click_pos) +{ + // Get entries from default menu before adding our own + QMenu *const menu = new QMenu(parent); + + QMenu* default_menu = Trace::create_view_context_menu(parent, click_pos); + if (default_menu) { + for (QAction *action : default_menu->actions()) { // clazy:exclude=range-loop + menu->addAction(action); + if (action->parent() == default_menu) + action->setParent(menu); + } + delete default_menu; + + // Add separator if needed + if (menu->actions().length() > 0) + menu->addSeparator(); + } + + try { + selected_row_ = &visible_rows_[get_row_at_point(click_pos)]; + } catch (out_of_range&) { + selected_row_ = nullptr; + } + + const View *const view = owner_->view(); + assert(view); + QPoint pos = view->viewport()->mapFrom(parent, click_pos); + + // Default sample range is "from here" + const pair sample_range = get_view_sample_range(pos.x(), pos.x() + 1); + selected_sample_range_ = make_pair(sample_range.first, numeric_limits::max()); + + if (decode_signal_->is_paused()) { + QAction *const resume = + new QAction(tr("Resume decoding"), this); + resume->setIcon(QIcon::fromTheme("media-playback-start", + QIcon(":/icons/media-playback-start.png"))); + connect(resume, SIGNAL(triggered()), this, SLOT(on_pause_decode())); + menu->addAction(resume); + } else { + QAction *const pause = + new QAction(tr("Pause decoding"), this); + pause->setIcon(QIcon::fromTheme("media-playback-pause", + QIcon(":/icons/media-playback-pause.png"))); + connect(pause, SIGNAL(triggered()), this, SLOT(on_pause_decode())); + menu->addAction(pause); + } + + QAction *const copy_annotation_to_clipboard = + new QAction(tr("Copy annotation text to clipboard"), this); + copy_annotation_to_clipboard->setIcon(QIcon::fromTheme("edit-paste", + QIcon(":/icons/edit-paste.png"))); + connect(copy_annotation_to_clipboard, SIGNAL(triggered()), this, SLOT(on_copy_annotation_to_clipboard())); + menu->addAction(copy_annotation_to_clipboard); + + menu->addSeparator(); + + QAction *const export_all_rows = + new QAction(tr("Export all annotations"), this); + export_all_rows->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_all_rows, SIGNAL(triggered()), this, SLOT(on_export_all_rows())); + menu->addAction(export_all_rows); + + QAction *const export_row = + new QAction(tr("Export all annotations for this row"), this); + export_row->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_row, SIGNAL(triggered()), this, SLOT(on_export_row())); + menu->addAction(export_row); + + menu->addSeparator(); + + QAction *const export_all_rows_from_here = + new QAction(tr("Export all annotations, starting here"), this); + export_all_rows_from_here->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_all_rows_from_here, SIGNAL(triggered()), this, SLOT(on_export_all_rows_from_here())); + menu->addAction(export_all_rows_from_here); + + QAction *const export_row_from_here = + new QAction(tr("Export annotations for this row, starting here"), this); + export_row_from_here->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_row_from_here, SIGNAL(triggered()), this, SLOT(on_export_row_from_here())); + menu->addAction(export_row_from_here); + + menu->addSeparator(); + + QAction *const export_all_rows_with_cursor = + new QAction(tr("Export all annotations within cursor range"), this); + export_all_rows_with_cursor->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_all_rows_with_cursor, SIGNAL(triggered()), this, SLOT(on_export_all_rows_with_cursor())); + menu->addAction(export_all_rows_with_cursor); + + QAction *const export_row_with_cursor = + new QAction(tr("Export annotations for this row within cursor range"), this); + export_row_with_cursor->setIcon(QIcon::fromTheme("document-save-as", + QIcon(":/icons/document-save-as.png"))); + connect(export_row_with_cursor, SIGNAL(triggered()), this, SLOT(on_export_row_with_cursor())); + menu->addAction(export_row_with_cursor); + + if (!view->cursors()->enabled()) { + export_all_rows_with_cursor->setEnabled(false); + export_row_with_cursor->setEnabled(false); + } + + return menu; +} + void DecodeTrace::draw_annotations(vector annotations, QPainter &p, int h, const ViewItemPaintParams &pp, int y, QColor row_color, int row_title_width) @@ -553,17 +700,18 @@ void DecodeTrace::draw_error(QPainter &p, const QString &message, { const int y = get_visual_y(); + double samples_per_pixel, pixels_offset; + tie(pixels_offset, samples_per_pixel) = get_pixels_offset_samples_per_pixel(); + p.setPen(ErrorBgColor.darker()); p.setBrush(ErrorBgColor); - const QRectF bounding_rect = - QRectF(pp.left(), INT_MIN / 2 + y, pp.right(), INT_MAX); - const QRectF text_rect = p.boundingRect(bounding_rect, - Qt::AlignCenter, message); + const QRectF bounding_rect = QRectF(pp.left(), INT_MIN / 2 + y, pp.right(), INT_MAX); + + const QRectF text_rect = p.boundingRect(bounding_rect, Qt::AlignCenter, message); const qreal r = text_rect.height() / 4; - p.drawRoundedRect(text_rect.adjusted(-r, -r, r, r), r, r, - Qt::AbsoluteSize); + p.drawRoundedRect(text_rect.adjusted(-r, -r, r, r), r, r, Qt::AbsoluteSize); p.setPen(Qt::black); p.drawText(text_rect, message); @@ -580,7 +728,7 @@ void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left, int right if (sample_count == 0) return; - const int64_t samples_decoded = decode_signal_->get_decoded_sample_count(current_segment_); + const int64_t samples_decoded = decode_signal_->get_decoded_sample_count(current_segment_, true); if (sample_count == samples_decoded) return; @@ -625,7 +773,7 @@ pair DecodeTrace::get_pixels_offset_samples_per_pixel() const return make_pair(pixels_offset, samplerate * scale); } -pair DecodeTrace::get_sample_range( +pair DecodeTrace::get_view_sample_range( int x_start, int x_end) const { double samples_per_pixel, pixels_offset; @@ -695,12 +843,12 @@ const QString DecodeTrace::get_annotation_at_point(const QPoint &point) return QString(); const pair sample_range = - get_sample_range(point.x(), point.x() + 1); + get_view_sample_range(point.x(), point.x() + 1); const int row = get_row_at_point(point); if (row < 0) return QString(); - vector annotations; + vector annotations; decode_signal_->get_annotation_subset(annotations, visible_rows_[row], current_segment_, sample_range.first, sample_range.second); @@ -725,8 +873,6 @@ void DecodeTrace::hover_point_changed(const QPoint &hp) QString ann = get_annotation_at_point(hp); - assert(view); - if (!row_height_ || ann.isEmpty()) { QToolTip::hideText(); return; @@ -790,7 +936,7 @@ void DecodeTrace::create_decoder_form(int index, const vector channels = decode_signal_->get_channels(); // Add the channels - for (DecodeChannel ch : channels) { + for (const DecodeChannel& ch : channels) { // Ignore channels not part of the decoder we create the form for if (ch.decoder_ != dec) continue; @@ -878,6 +1024,70 @@ QComboBox* DecodeTrace::create_channel_selector_init_state(QWidget *parent, return selector; } +void DecodeTrace::export_annotations(vector *annotations) const +{ + using namespace pv::data::decode; + + GlobalSettings settings; + const QString dir = settings.value("MainWindow/SaveDirectory").toString(); + + const QString file_name = QFileDialog::getSaveFileName( + owner_->view(), tr("Export annotations"), dir, tr("Text Files (*.txt);;All Files (*)")); + + if (file_name.isEmpty()) + return; + + QString format = settings.value(GlobalSettings::Key_Dec_ExportFormat).toString(); + const QString quote = format.contains("%q") ? "\"" : ""; + format = format.remove("%q"); + + QFile file(file_name); + if (file.open(QIODevice::WriteOnly | QIODevice::Truncate | QIODevice::Text)) { + QTextStream out_stream(&file); + + for (Annotation &ann : *annotations) { + const QString sample_range = QString("%1-%2") \ + .arg(QString::number(ann.start_sample()), QString::number(ann.end_sample())); + + const QString class_name = quote + ann.row()->class_name() + quote; + + QString all_ann_text; + for (const QString &s : ann.annotations()) + all_ann_text = all_ann_text + quote + s + quote + ","; + all_ann_text.chop(1); + + const QString first_ann_text = quote + ann.annotations().front() + quote; + + QString out_text = format; + out_text = out_text.replace("%s", sample_range); + out_text = out_text.replace("%d", + quote + QString::fromUtf8(ann.row()->decoder()->name) + quote); + out_text = out_text.replace("%c", class_name); + out_text = out_text.replace("%1", first_ann_text); + out_text = out_text.replace("%a", all_ann_text); + out_stream << out_text << '\n'; + } + + if (out_stream.status() == QTextStream::Ok) + return; + } + + QMessageBox msg(owner_->view()); + msg.setText(tr("Error") + "\n\n" + tr("File %1 could not be written to.").arg(file_name)); + msg.setStandardButtons(QMessageBox::Ok); + msg.setIcon(QMessageBox::Warning); + msg.exec(); +} + +void DecodeTrace::on_setting_changed(const QString &key, const QVariant &value) +{ + if (key == GlobalSettings::Key_Dec_AlwaysShowAllRows) { + visible_rows_.clear(); + max_visible_rows_ = 0; + always_show_all_rows_ = value.toBool(); + } +} + void DecodeTrace::on_new_annotations() { if (!delayed_trace_updater_.isActive()) @@ -905,6 +1115,14 @@ void DecodeTrace::on_decode_finished() owner_->row_item_appearance_changed(false, true); } +void DecodeTrace::on_pause_decode() +{ + if (decode_signal_->is_paused()) + decode_signal_->resume_decode(); + else + decode_signal_->pause_decode(); +} + void DecodeTrace::delete_pressed() { on_delete(); @@ -984,6 +1202,125 @@ void DecodeTrace::on_show_hide_decoder(int index) owner_->row_item_appearance_changed(false, true); } +void DecodeTrace::on_copy_annotation_to_clipboard() +{ + using namespace pv::data::decode; + + if (!selected_row_) + return; + + vector *annotations = new vector(); + + decode_signal_->get_annotation_subset(*annotations, *selected_row_, + current_segment_, selected_sample_range_.first, selected_sample_range_.first); + + if (annotations->empty()) + return; + + QClipboard *clipboard = QGuiApplication::clipboard(); + clipboard->setText(annotations->front().annotations().front()); + + delete annotations; +} + +void DecodeTrace::on_export_row() +{ + selected_sample_range_ = make_pair(0, numeric_limits::max()); + on_export_row_from_here(); +} + +void DecodeTrace::on_export_all_rows() +{ + selected_sample_range_ = make_pair(0, numeric_limits::max()); + on_export_all_rows_from_here(); +} + +void DecodeTrace::on_export_row_with_cursor() +{ + const View *view = owner_->view(); + assert(view); + + if (!view->cursors()->enabled()) + return; + + const double samplerate = session_.get_samplerate(); + + const pv::util::Timestamp& start_time = view->cursors()->first()->time(); + const pv::util::Timestamp& end_time = view->cursors()->second()->time(); + + const uint64_t start_sample = (uint64_t)max( + 0.0, start_time.convert_to() * samplerate); + const uint64_t end_sample = (uint64_t)max( + 0.0, end_time.convert_to() * samplerate); + + // Are both cursors negative and thus were clamped to 0? + if ((start_sample == 0) && (end_sample == 0)) + return; + + selected_sample_range_ = make_pair(start_sample, end_sample); + on_export_row_from_here(); +} + +void DecodeTrace::on_export_all_rows_with_cursor() +{ + const View *view = owner_->view(); + assert(view); + + if (!view->cursors()->enabled()) + return; + + const double samplerate = session_.get_samplerate(); + + const pv::util::Timestamp& start_time = view->cursors()->first()->time(); + const pv::util::Timestamp& end_time = view->cursors()->second()->time(); + + const uint64_t start_sample = (uint64_t)max( + 0.0, start_time.convert_to() * samplerate); + const uint64_t end_sample = (uint64_t)max( + 0.0, end_time.convert_to() * samplerate); + + // Are both cursors negative and thus were clamped to 0? + if ((start_sample == 0) && (end_sample == 0)) + return; + + selected_sample_range_ = make_pair(start_sample, end_sample); + on_export_all_rows_from_here(); +} + +void DecodeTrace::on_export_row_from_here() +{ + using namespace pv::data::decode; + + if (!selected_row_) + return; + + vector *annotations = new vector(); + + decode_signal_->get_annotation_subset(*annotations, *selected_row_, + current_segment_, selected_sample_range_.first, selected_sample_range_.second); + + if (annotations->empty()) + return; + + export_annotations(annotations); + delete annotations; +} + +void DecodeTrace::on_export_all_rows_from_here() +{ + using namespace pv::data::decode; + + vector *annotations = new vector(); + + decode_signal_->get_annotation_subset(*annotations, current_segment_, + selected_sample_range_.first, selected_sample_range_.second); + + if (!annotations->empty()) + export_annotations(annotations); + + delete annotations; +} + } // namespace trace } // namespace views } // namespace pv