X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=pv%2Fview%2Fviewport.cpp;h=d555a792ed5f1ad8a09093709919c1c25c75e48d;hb=4b0af0b67fe57e0880bcb8aa13b4fa807f3aaac0;hp=2150182f543dd4a52eb974f3352198e8b2b24b66;hpb=8e21a82cac5eb399dc7158da4b34c664cb4958cd;p=pulseview.git

diff --git a/pv/view/viewport.cpp b/pv/view/viewport.cpp
index 2150182f..d555a792 100644
--- a/pv/view/viewport.cpp
+++ b/pv/view/viewport.cpp
@@ -36,7 +36,6 @@ using std::abs;
 using std::back_inserter;
 using std::copy;
 using std::dynamic_pointer_cast;
-using std::isnan;
 using std::max;
 using std::min;
 using std::none_of;
@@ -50,7 +49,6 @@ namespace view {
 
 Viewport::Viewport(View &parent) :
 	ViewWidget(parent),
-	drag_offset_(numeric_limits<double>::signaling_NaN()),
 	pinch_zoom_active_(false)
 {
 	setAutoFillBackground(true);
@@ -83,16 +81,16 @@ void Viewport::drag()
 
 void Viewport::drag_by(const QPoint &delta)
 {
-	if (isnan(drag_offset_))
+	if (drag_offset_ == boost::none)
 		return;
 
-	view_.set_scale_offset(view_.scale(), drag_offset_ -
-		delta.x() * view_.scale());
+	view_.set_scale_offset(view_.scale(),
+		(*drag_offset_ - delta.x() * view_.scale()));
 }
 
 void Viewport::drag_release()
 {
-	drag_offset_ = numeric_limits<double>::signaling_NaN();
+	drag_offset_ = boost::none;
 }
 
 vector< shared_ptr<ViewItem> > Viewport::items()
@@ -117,8 +115,8 @@ bool Viewport::touch_event(QTouchEvent *event)
 
 	if (!pinch_zoom_active_ ||
 	    (event->touchPointStates() & Qt::TouchPointPressed)) {
-		pinch_offset0_ = view_.offset() + view_.scale() * touchPoint0.pos().x();
-		pinch_offset1_ = view_.offset() + view_.scale() * touchPoint1.pos().x();
+		pinch_offset0_ = (view_.offset() + view_.scale() * touchPoint0.pos().x()).convert_to<double>();
+		pinch_offset1_ = (view_.offset() + view_.scale() * touchPoint1.pos().x()).convert_to<double>();
 		pinch_zoom_active_ = true;
 	}
 
@@ -195,18 +193,27 @@ void Viewport::mouseDoubleClickEvent(QMouseEvent *event)
 		view_.zoom(-2.0, event->x());
 }
 
-void Viewport::wheelEvent(QWheelEvent *event)
+void Viewport::wheelEvent(QWheelEvent *e)
 {
-	assert(event);
-
-	if (event->orientation() == Qt::Vertical) {
-		// Vertical scrolling is interpreted as zooming in/out
-		view_.zoom(event->delta() / 120, event->x());
-	} else if (event->orientation() == Qt::Horizontal) {
+	assert(e);
+
+	if (e->orientation() == Qt::Vertical)
+	{
+		if (e->modifiers() & Qt::ControlModifier) {
+			// Vertical scrolling with the control key pressed
+			// is intrepretted as vertical scrolling
+			view_.set_v_offset(-view_.owner_visual_v_offset() -
+				(e->delta() * height()) / (8 * 120));
+		} else {
+			// Vertical scrolling is interpreted as zooming in/out
+			view_.zoom(e->delta() / 120, e->x());
+		}
+	}
+	else if (e->orientation() == Qt::Horizontal)
+	{
 		// Horizontal scrolling is interpreted as moving left/right
 		view_.set_scale_offset(view_.scale(),
-				       event->delta() * view_.scale()
-				       + view_.offset());
+			e->delta() * view_.scale() + view_.offset());
 	}
 }