X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=pv%2Fprop%2Fdouble.cpp;h=f4e6e443a5bb6f2e7dcf27fe29053f6daed50090;hb=fd22c71c1a9cc470b53c71c0ee131a4b2d645f80;hp=39e205ee691f2910dd7899ac958ae5d9c69bde3f;hpb=f459c5400e067c4389c472b84194d760e7bfd585;p=pulseview.git

diff --git a/pv/prop/double.cpp b/pv/prop/double.cpp
index 39e205ee..f4e6e443 100644
--- a/pv/prop/double.cpp
+++ b/pv/prop/double.cpp
@@ -22,10 +22,10 @@
 
 #include <QDoubleSpinBox>
 
-#include "double.h"
+#include "double.hpp"
 
-using namespace std;
-using namespace boost;
+using boost::optional;
+using std::pair;
 
 namespace pv {
 namespace prop {
@@ -38,49 +38,59 @@ Double::Double(QString name,
 	Getter getter,
 	Setter setter) :
 	Property(name, getter, setter),
-	_decimals(decimals),
-	_suffix(suffix),
-	_range(range),
-	_step(step),
-	_spin_box(NULL)
+	decimals_(decimals),
+	suffix_(suffix),
+	range_(range),
+	step_(step),
+	spin_box_(nullptr)
 {
 }
 
-Double::~Double()
+QWidget* Double::get_widget(QWidget *parent, bool auto_commit)
 {
-}
+	if (spin_box_)
+		return spin_box_;
 
-QWidget* Double::get_widget(QWidget *parent)
-{
-	if (_spin_box)
-		return _spin_box;
+	if (!getter_)
+		return nullptr;
+
+	Glib::VariantBase variant = getter_();
+	if (!variant.gobj())
+		return nullptr;
+
+	double value = Glib::VariantBase::cast_dynamic<Glib::Variant<double>>(
+		variant).get();
 
-	_spin_box = new QDoubleSpinBox(parent);
-	_spin_box->setDecimals(_decimals);
-	_spin_box->setSuffix(_suffix);
-	if (_range)
-		_spin_box->setRange(_range->first, _range->second);
-	if (_step)
-		_spin_box->setSingleStep(*_step);
+	spin_box_ = new QDoubleSpinBox(parent);
+	spin_box_->setDecimals(decimals_);
+	spin_box_->setSuffix(suffix_);
+	if (range_)
+		spin_box_->setRange(range_->first, range_->second);
+	if (step_)
+		spin_box_->setSingleStep(*step_);
 
-	GVariant *const value = _getter ? _getter() : NULL;
+	spin_box_->setValue(value);
 
-	if (value) {
-		_spin_box->setValue(g_variant_get_double(value));
-		g_variant_unref(value);
-	}
+	if (auto_commit)
+		connect(spin_box_, SIGNAL(valueChanged(double)),
+			this, SLOT(on_value_changed(double)));
 
-	return _spin_box;
+	return spin_box_;
 }
 
 void Double::commit()
 {
-	assert(_setter);
+	assert(setter_);
 
-	if (!_spin_box)
+	if (!spin_box_)
 		return;
 
-	_setter(g_variant_new_double(_spin_box->value()));
+	setter_(Glib::Variant<double>::create(spin_box_->value()));
+}
+
+void Double::on_value_changed(double)
+{
+	commit();
 }
 
 } // prop