X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=output%2Ftext%2Fbits.c;h=ffaf30d6faa387946623f0d82326b4eb09058829;hb=c73d2ea421c2b425c3f0ae33bce2bfd0c448ca5f;hp=43eb7d0200633cd0c86ff462eadc4c6668053721;hpb=9688b443f65c7779a07b0e3ef2b9f9721ff742cd;p=libsigrok.git

diff --git a/output/text/bits.c b/output/text/bits.c
index 43eb7d02..ffaf30d6 100644
--- a/output/text/bits.c
+++ b/output/text/bits.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the sigrok project.
  *
- * Copyright (C) 2011 Bert Vermeulen <bert@biot.com>
+ * Copyright (C) 2010-2012 Bert Vermeulen <bert@biot.com>
  * Copyright (C) 2011 HÃ¥vard Espeland <gus@ping.uio.no>
  *
  * This program is free software: you can redistribute it and/or modify
@@ -21,17 +21,17 @@
 #include <stdlib.h>
 #include <string.h>
 #include <glib.h>
-#include <sigrok.h>
+#include "sigrok.h"
+#include "sigrok-internal.h"
 #include "text.h"
 
-
-int init_bits(struct sr_output *o)
+SR_PRIV int init_bits(struct sr_output *o)
 {
 	return init(o, DEFAULT_BPL_BITS, MODE_BITS);
 }
 
-int data_bits(struct sr_output *o, const char *data_in, uint64_t length_in,
-	      char **data_out, uint64_t *length_out)
+SR_PRIV int data_bits(struct sr_output *o, const char *data_in,
+		      uint64_t length_in, char **data_out, uint64_t *length_out)
 {
 	struct context *ctx;
 	unsigned int outsize, offset, p;
@@ -49,14 +49,16 @@ int data_bits(struct sr_output *o, const char *data_in, uint64_t length_in,
 	outsize = 512 + (1 + (length_in / ctx->unitsize) / ctx->samples_per_line)
             * (ctx->num_enabled_probes * max_linelen);
 
-	if (!(outbuf = calloc(1, outsize + 1)))
+	if (!(outbuf = g_try_malloc0(outsize + 1))) {
+		sr_err("bits out: %s: outbuf malloc failed", __func__);
 		return SR_ERR_MALLOC;
+	}
 
 	outbuf[0] = '\0';
 	if (ctx->header) {
 		/* The header is still here, this must be the first packet. */
 		strncpy(outbuf, ctx->header, outsize);
-		free(ctx->header);
+		g_free(ctx->header);
 		ctx->header = NULL;
 
 		/* Ensure first transition. */
@@ -92,7 +94,7 @@ int data_bits(struct sr_output *o, const char *data_in, uint64_t length_in,
 			}
 		}
 	} else {
-		g_message("short buffer (length_in=%" PRIu64 ")", length_in);
+		sr_info("short buffer (length_in=%" PRIu64 ")", length_in);
 	}
 
 	*data_out = outbuf;
@@ -101,13 +103,11 @@ int data_bits(struct sr_output *o, const char *data_in, uint64_t length_in,
 	return SR_OK;
 }
 
-
-struct sr_output_format output_text_bits = {
-	"bits",
-	"Bits (takes argument, default 64)",
-	SR_DF_LOGIC,
-	init_bits,
-	data_bits,
-	event,
+SR_PRIV struct sr_output_format output_text_bits = {
+	.id = "bits",
+	.description = "Bits (takes argument, default 64)",
+	.df_type = SR_DF_LOGIC,
+	.init = init_bits,
+	.data = data_bits,
+	.event = event,
 };
-