X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=output%2Fgnuplot.c;h=e93556f834b0aebed65a7b8a75f110ae8b99f6ba;hb=d3c74a6fb05118e32ad421443251b7b3288918f9;hp=77ca39fe59c4d90da234201621bdb85b16ad464b;hpb=1a081ca67d63a0bd933a3d715792d85afd437296;p=libsigrok.git diff --git a/output/gnuplot.c b/output/gnuplot.c index 77ca39fe..e93556f8 100644 --- a/output/gnuplot.c +++ b/output/gnuplot.c @@ -1,5 +1,5 @@ /* - * This file is part of the sigrok project. + * This file is part of the libsigrok project. * * Copyright (C) 2010 Uwe Hermann * @@ -21,20 +21,26 @@ #include #include #include -#include "config.h" -#include "sigrok.h" -#include "sigrok-internal.h" +#include "config.h" /* Needed for PACKAGE_STRING and others. */ +#include "libsigrok.h" +#include "libsigrok-internal.h" + +/* Message logging helpers with subsystem-specific prefix string. */ +#define LOG_PREFIX "output/gnuplot: " +#define sr_log(l, s, args...) sr_log(l, LOG_PREFIX s, ## args) +#define sr_spew(s, args...) sr_spew(LOG_PREFIX s, ## args) +#define sr_dbg(s, args...) sr_dbg(LOG_PREFIX s, ## args) +#define sr_info(s, args...) sr_info(LOG_PREFIX s, ## args) +#define sr_warn(s, args...) sr_warn(LOG_PREFIX s, ## args) +#define sr_err(s, args...) sr_err(LOG_PREFIX s, ## args) struct context { unsigned int num_enabled_probes; unsigned int unitsize; - char *probelist[SR_MAX_NUM_PROBES + 1]; char *header; + uint8_t *old_sample; }; -#define MAX_HEADER_LEN \ - (1024 + (SR_MAX_NUM_PROBES * (SR_MAX_PROBENAME_LEN + 10))) - static const char *gnuplot_header = "\ # Sample data in space-separated columns format usable by gnuplot\n\ #\n\ @@ -54,132 +60,114 @@ static int init(struct sr_output *o) struct context *ctx; struct sr_probe *probe; GSList *l; + GVariant *gvar; uint64_t samplerate; unsigned int i; - int b, num_probes; + int num_probes; char *c, *frequency_s; char wbuf[1000], comment[128]; time_t t; if (!o) { - sr_warn("gnuplot out: %s: o was NULL", __func__); - return SR_ERR_ARG; - } - - if (!o->device) { - sr_warn("gnuplot out: %s: o->device was NULL", __func__); + sr_err("%s: o was NULL", __func__); return SR_ERR_ARG; } - if (!o->device->plugin) { - sr_warn("gnuplot out: %s: o->device->plugin was NULL", - __func__); + if (!o->sdi) { + sr_err("%s: o->sdi was NULL", __func__); return SR_ERR_ARG; } - if (!(ctx = calloc(1, sizeof(struct context)))) { - sr_warn("gnuplot out: %s: ctx calloc failed", __func__); - return SR_ERR_MALLOC; - } - - if (!(ctx->header = calloc(1, MAX_HEADER_LEN + 1))) { - sr_warn("gnuplot out: %s: ctx->header calloc failed", - __func__); - free(ctx); + if (!(ctx = g_try_malloc0(sizeof(struct context)))) { + sr_err("%s: ctx malloc failed", __func__); return SR_ERR_MALLOC; } o->internal = ctx; ctx->num_enabled_probes = 0; - for (l = o->device->probes; l; l = l->next) { - probe = l->data; /* TODO: Error checks. */ - if (!probe->enabled) - continue; - ctx->probelist[ctx->num_enabled_probes++] = probe->name; + for (l = o->sdi->probes; l; l = l->next) { + probe = l->data; + if (probe->enabled) + ctx->num_enabled_probes++; } - ctx->probelist[ctx->num_enabled_probes] = 0; ctx->unitsize = (ctx->num_enabled_probes + 7) / 8; - num_probes = g_slist_length(o->device->probes); + num_probes = g_slist_length(o->sdi->probes); comment[0] = '\0'; - if (sr_device_has_hwcap(o->device, SR_HWCAP_SAMPLERATE)) { - samplerate = *((uint64_t *) o->device->plugin->get_device_info( - o->device->plugin_index, SR_DI_CUR_SAMPLERATE)); + samplerate = 0; + if (sr_config_get(o->sdi->driver, o->sdi, NULL, SR_CONF_SAMPLERATE, + &gvar) == SR_OK) { + samplerate = g_variant_get_uint64(gvar); + g_variant_unref(gvar); if (!(frequency_s = sr_samplerate_string(samplerate))) { - sr_warn("gnuplot out: %s: sr_samplerate_string failed", - __func__); - free(ctx->header); - free(ctx); + sr_err("%s: sr_samplerate_string failed", __func__); + g_free(ctx); return SR_ERR; } snprintf(comment, 127, gnuplot_header_comment, ctx->num_enabled_probes, num_probes, frequency_s); - free(frequency_s); + g_free(frequency_s); } /* Columns / channels */ wbuf[0] = '\0'; - for (i = 0; i < ctx->num_enabled_probes; i++) { - c = (char *)&wbuf + strlen((char *)&wbuf); - sprintf(c, "# %d\t\t%s\n", i + 1, ctx->probelist[i]); + for (i = 0, l = o->sdi->probes; l; l = l->next, i++) { + probe = l->data; + if (!probe->enabled) + continue; + c = (char *)&wbuf + strlen((const char *)&wbuf); + sprintf(c, "# %d\t\t%s\n", i + 1, probe->name); } if (!(frequency_s = sr_period_string(samplerate))) { - sr_warn("gnuplot out: %s: sr_period_string failed", __func__); - free(ctx->header); - free(ctx); + sr_err("%s: sr_period_string failed", __func__); + g_free(ctx); return SR_ERR; } t = time(NULL); - b = snprintf(ctx->header, MAX_HEADER_LEN, gnuplot_header, - PACKAGE_STRING, ctime(&t), comment, frequency_s, - (char *)&wbuf); - free(frequency_s); - - if (b < 0) { - sr_warn("gnuplot out: %s: sprintf failed", __func__); - free(ctx->header); - free(ctx); - return SR_ERR; + ctx->header = g_strdup_printf(gnuplot_header, PACKAGE_STRING, + ctime(&t), comment, frequency_s, (char *)&wbuf); + g_free(frequency_s); + + if (!(ctx->old_sample = g_try_malloc0(ctx->unitsize))) { + sr_err("%s: ctx->old_sample malloc failed", __func__); + g_free(ctx->header); + g_free(ctx); + return SR_ERR_MALLOC; } return 0; } -static int event(struct sr_output *o, int event_type, char **data_out, +static int event(struct sr_output *o, int event_type, uint8_t **data_out, uint64_t *length_out) { - struct context *ctx; - if (!o) { - sr_warn("gnuplot out: %s: o was NULL", __func__); + sr_err("%s: o was NULL", __func__); return SR_ERR_ARG; } if (!data_out) { - sr_warn("gnuplot out: %s: data_out was NULL", __func__); + sr_err("%s: data_out was NULL", __func__); return SR_ERR_ARG; } if (!length_out) { - sr_warn("gnuplot out: %s: length_out was NULL", __func__); + sr_err("%s: length_out was NULL", __func__); return SR_ERR_ARG; } - ctx = o->internal; - switch (event_type) { case SR_DF_TRIGGER: /* TODO: Can a trigger mark be in a gnuplot data file? */ break; case SR_DF_END: - free(o->internal); + g_free(o->internal); o->internal = NULL; break; default: - sr_warn("gnuplot out: %s: unsupported event type: %d", - __func__, event_type); + sr_err("%s: unsupported event type: %d", __func__, event_type); break; } @@ -189,37 +177,37 @@ static int event(struct sr_output *o, int event_type, char **data_out, return SR_OK; } -static int data(struct sr_output *o, const char *data_in, uint64_t length_in, - char **data_out, uint64_t *length_out) +static int data(struct sr_output *o, const uint8_t *data_in, + uint64_t length_in, uint8_t **data_out, uint64_t *length_out) { struct context *ctx; unsigned int max_linelen, outsize, p, curbit, i; - uint64_t sample; - static uint64_t samplecount = 0, old_sample = 0; - char *outbuf, *c; + const uint8_t *sample; + static uint64_t samplecount = 0; + uint8_t *outbuf, *c; if (!o) { - sr_warn("gnuplot out: %s: o was NULL", __func__); + sr_err("%s: o was NULL", __func__); return SR_ERR_ARG; } if (!o->internal) { - sr_warn("gnuplot out: %s: o->internal was NULL", __func__); + sr_err("%s: o->internal was NULL", __func__); return SR_ERR_ARG; } if (!data_in) { - sr_warn("gnuplot out: %s: data_in was NULL", __func__); + sr_err("%s: data_in was NULL", __func__); return SR_ERR_ARG; } if (!data_out) { - sr_warn("gnuplot out: %s: data_out was NULL", __func__); + sr_err("%s: data_out was NULL", __func__); return SR_ERR_ARG; } if (!length_out) { - sr_warn("gnuplot out: %s: length_out was NULL", __func__); + sr_err("%s: length_out was NULL", __func__); return SR_ERR_ARG; } @@ -229,55 +217,56 @@ static int data(struct sr_output *o, const char *data_in, uint64_t length_in, if (ctx->header) outsize += strlen(ctx->header); - if (!(outbuf = calloc(1, outsize))) { - sr_warn("gnuplot out: %s: outbuf calloc failed", __func__); + if (!(outbuf = g_try_malloc0(outsize))) { + sr_err("%s: outbuf malloc failed", __func__); return SR_ERR_MALLOC; } outbuf[0] = '\0'; if (ctx->header) { /* The header is still here, this must be the first packet. */ - strncpy(outbuf, ctx->header, outsize); - free(ctx->header); + strncpy((char *)outbuf, ctx->header, outsize); + g_free(ctx->header); ctx->header = NULL; } for (i = 0; i <= length_in - ctx->unitsize; i += ctx->unitsize) { - memcpy(&sample, data_in + i, ctx->unitsize); + sample = data_in + i; /* * Don't output the same samples multiple times. However, make * sure to output at least the first and last sample. */ - if (samplecount++ != 0 && sample == old_sample) { + if (samplecount++ != 0 && + !memcmp(sample, ctx->old_sample, ctx->unitsize)) { if (i != (length_in - ctx->unitsize)) continue; } - old_sample = sample; + memcpy(ctx->old_sample, sample, ctx->unitsize); /* The first column is a counter (needed for gnuplot). */ - c = outbuf + strlen(outbuf); - sprintf(c, "%" PRIu64 "\t", samplecount++); + c = outbuf + strlen((const char *)outbuf); + sprintf((char *)c, "%" PRIu64 "\t", samplecount++); /* The next columns are the values of all channels. */ for (p = 0; p < ctx->num_enabled_probes; p++) { - curbit = (sample & ((uint64_t) (1 << p))) >> p; - c = outbuf + strlen(outbuf); - sprintf(c, "%d ", curbit); + curbit = (sample[p / 8] & ((uint8_t) (1 << (p % 8)))) >> (p % 8); + c = outbuf + strlen((const char *)outbuf); + sprintf((char *)c, "%d ", curbit); } - c = outbuf + strlen(outbuf); - sprintf(c, "\n"); + c = outbuf + strlen((const char *)outbuf); + sprintf((char *)c, "\n"); } *data_out = outbuf; - *length_out = strlen(outbuf); + *length_out = strlen((const char *)outbuf); return SR_OK; } -struct sr_output_format output_gnuplot = { +SR_PRIV struct sr_output_format output_gnuplot = { .id = "gnuplot", .description = "Gnuplot", .df_type = SR_DF_LOGIC, @@ -285,150 +274,3 @@ struct sr_output_format output_gnuplot = { .data = data, .event = event, }; - -/* Temporarily disabled. */ -#if 0 -static int analog_init(struct sr_output *o) -{ - struct context *ctx; - struct sr_probe *probe; - GSList *l; - uint64_t samplerate; - unsigned int i; - int b, num_probes; - char *c, *frequency_s; - char wbuf[1000], comment[128]; - time_t t; - - if (!(ctx = calloc(1, sizeof(struct context)))) - return SR_ERR_MALLOC; - - if (!(ctx->header = calloc(1, MAX_HEADER_LEN + 1))) { - free(ctx); - return SR_ERR_MALLOC; - } - - o->internal = ctx; - ctx->num_enabled_probes = 0; - for (l = o->device->probes; l; l = l->next) { - probe = l->data; - if (!probe->enabled) - continue; - ctx->probelist[ctx->num_enabled_probes++] = probe->name; - } - ctx->probelist[ctx->num_enabled_probes] = 0; -// ctx->unitsize = (ctx->num_enabled_probes + 7) / 8; - ctx->unitsize = sizeof(struct sr_analog_sample) + - (ctx->num_enabled_probes * sizeof(struct sr_analog_probe)); - - num_probes = g_slist_length(o->device->probes); - comment[0] = '\0'; - if (o->device->plugin && sr_device_has_hwcap(o->device, SR_HWCAP_SAMPLERATE)) { - samplerate = *((uint64_t *) o->device->plugin->get_device_info( - o->device->plugin_index, SR_DI_CUR_SAMPLERATE)); - if (!(frequency_s = sr_samplerate_string(samplerate))) { - free(ctx->header); - free(ctx); - return SR_ERR; - } - snprintf(comment, 127, gnuplot_header_comment, - ctx->num_enabled_probes, num_probes, frequency_s); - free(frequency_s); - } - - /* Columns / channels */ - wbuf[0] = '\0'; - for (i = 0; i < ctx->num_enabled_probes; i++) { - c = (char *)&wbuf + strlen((char *)&wbuf); - sprintf(c, "# %d\t\t%s\n", i + 1, ctx->probelist[i]); - } - - if (!(frequency_s = sr_period_string(samplerate))) { - free(ctx->header); - free(ctx); - return SR_ERR; - } - t = time(NULL); - b = snprintf(ctx->header, MAX_HEADER_LEN, gnuplot_header, - PACKAGE_STRING, ctime(&t), comment, frequency_s, - (char *)&wbuf); - free(frequency_s); - - if (b < 0) { - free(ctx->header); - free(ctx); - return SR_ERR; - } - - return 0; -} - -static int analog_data(struct sr_output *o, char *data_in, uint64_t length_in, - char **data_out, uint64_t *length_out) -{ - struct context *ctx; - unsigned int max_linelen, outsize, p, /* curbit, */ i; -// uint64_t sample; - static uint64_t samplecount = 0; - char *outbuf, *c; - struct sr_analog_sample *sample; - - ctx = o->internal; -// max_linelen = 16 + ctx->num_enabled_probes * 2; - max_linelen = 16 + ctx->num_enabled_probes * 30; - outsize = length_in / ctx->unitsize * max_linelen; - if (ctx->header) - outsize += strlen(ctx->header); - - if (!(outbuf = calloc(1, outsize))) - return SR_ERR_MALLOC; - - outbuf[0] = '\0'; - if (ctx->header) { - /* The header is still here, this must be the first packet. */ - strncpy(outbuf, ctx->header, outsize); - free(ctx->header); - ctx->header = NULL; - } - - for (i = 0; i <= length_in - ctx->unitsize; i += ctx->unitsize) { -// memcpy(&sample, data_in + i, ctx->unitsize); - sample = (struct sr_analog_sample *) (data_in + i); - - /* The first column is a counter (needed for gnuplot). */ - c = outbuf + strlen(outbuf); - sprintf(c, "%" PRIu64 "\t", samplecount++); - - /* The next columns are the values of all channels. */ - for (p = 0; p < ctx->num_enabled_probes; p++) { -// curbit = (sample & ((uint64_t) (1 << p))) >> p; - c = outbuf + strlen(outbuf); -// sprintf(c, "%d ", curbit); - /* - * FIXME: Should be doing proper raw->voltage conversion - * here, casting to int16_t isn't it. Remember that if - * res = 1 conversion isn't necessary. - */ - sprintf(c, "%f ", (double) ((int16_t) (sample->probes[p].val & - ((1 << sample->probes[p].res) - 1)))); - } - - c = outbuf + strlen(outbuf); - sprintf(c, "\n"); - } - - *data_out = outbuf; - *length_out = strlen(outbuf); - - return SR_OK; -} - -struct sr_output_format output_analog_gnuplot = { - .id = "analog_gnuplot", - .description = "Gnuplot analog", - .df_type = SR_DF_ANALOG, - .init = analog_init, - .data = analog_data, - .event = event, -}; -#endif