X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=log.c;h=de7360398456d2f087155f712281b6ed8ee53360;hb=76b64d3a64c61f4de996d40c55d44c77471a48d8;hp=9d0bc73d5fb18891d12222c0d4e15f922d998533;hpb=f6c7eade2b8853b3d525b5cc0402e89ca74c1908;p=libsigrokdecode.git
diff --git a/log.c b/log.c
index 9d0bc73..de73603 100644
--- a/log.c
+++ b/log.c
@@ -14,14 +14,15 @@
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ * along with this program; if not, see .
*/
+#include
#include "libsigrokdecode-internal.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
#include "libsigrokdecode.h"
#include
#include
+#include
/**
* @file
@@ -53,13 +54,6 @@ static srd_log_callback srd_log_cb = srd_logv;
*/
static void *srd_log_cb_data = NULL;
-/* Log domain (a short string that is used as prefix for all messages). */
-/** @cond PRIVATE */
-#define LOGDOMAIN_MAXLEN 30
-#define LOGDOMAIN_DEFAULT "srd: "
-/** @endcond */
-static char srd_log_domain[LOGDOMAIN_MAXLEN + 1] = LOGDOMAIN_DEFAULT;
-
/**
* Set the libsigrokdecode loglevel.
*
@@ -104,50 +98,6 @@ SRD_API int srd_log_loglevel_get(void)
return cur_loglevel;
}
-/**
- * Set the libsigrokdecode logdomain string.
- *
- * @param logdomain The string to use as logdomain for libsigrokdecode log
- * messages from now on. Must not be NULL. The maximum
- * length of the string is 30 characters (this does not
- * include the trailing NUL-byte). Longer strings are
- * silently truncated.
- * In order to not use a logdomain, pass an empty string.
- * The function makes its own copy of the input string, i.e.
- * the caller does not need to keep it around.
- *
- * @return SRD_OK upon success, SRD_ERR_ARG upon invalid logdomain.
- *
- * @since 0.1.0
- */
-SRD_API int srd_log_logdomain_set(const char *logdomain)
-{
- if (!logdomain) {
- srd_err("log: %s: logdomain was NULL", __func__);
- return SRD_ERR_ARG;
- }
-
- snprintf((char *)&srd_log_domain, LOGDOMAIN_MAXLEN, "%s", logdomain);
-
- srd_dbg("Log domain set to '%s'.", (const char *)&srd_log_domain);
-
- return SRD_OK;
-}
-
-/**
- * Get the currently configured libsigrokdecode logdomain.
- *
- * @return A copy of the currently configured libsigrokdecode logdomain
- * string. The caller is responsible for g_free()ing the string when
- * it is no longer needed.
- *
- * @since 0.1.0
- */
-SRD_API char *srd_log_logdomain_get(void)
-{
- return g_strdup((const char *)&srd_log_domain);
-}
-
/**
* Set the libsigrokdecode log callback to the specified function.
*
@@ -179,6 +129,28 @@ SRD_API int srd_log_callback_set(srd_log_callback cb, void *cb_data)
return SRD_OK;
}
+/**
+ * Get the libsigrokdecode log callback routine and callback data.
+ *
+ * @param[out] cb Pointer to a function pointer to receive the log callback
+ * function. Optional, can be NULL.
+ * @param[out] cb_data Pointer to a void pointer to receive the log callback's
+ * additional arguments. Optional, can be NULL.
+ *
+ * @return SRD_OK upon success.
+ *
+ * @since 0.5.2
+ */
+SRD_API int srd_log_callback_get(srd_log_callback *cb, void **cb_data)
+{
+ if (cb)
+ *cb = srd_log_cb;
+ if (cb_data)
+ *cb_data = srd_log_cb_data;
+
+ return SRD_OK;
+}
+
/**
* Set the libsigrokdecode log callback to the default built-in one.
*
@@ -203,96 +175,33 @@ SRD_API int srd_log_callback_set_default(void)
static int srd_logv(void *cb_data, int loglevel, const char *format,
va_list args)
{
- int ret;
-
/* This specific log callback doesn't need the void pointer data. */
(void)cb_data;
- /* Only output messages of at least the selected loglevel(s). */
- if (loglevel > cur_loglevel)
- return SRD_OK;
+ (void)loglevel;
- if (srd_log_domain[0] != '\0')
- fprintf(stderr, "%s", srd_log_domain);
- ret = vfprintf(stderr, format, args);
- fprintf(stderr, "\n");
+ if (fputs("srd: ", stderr) < 0
+ || g_vfprintf(stderr, format, args) < 0
+ || putc('\n', stderr) < 0)
+ return SRD_ERR;
- return ret;
-}
-
-/** @private */
-SRD_PRIV int srd_log(int loglevel, const char *format, ...)
-{
- int ret;
- va_list args;
-
- va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, loglevel, format, args);
- va_end(args);
+ fflush(stderr);
- return ret;
-}
-
-/** @private */
-SRD_PRIV int srd_spew(const char *format, ...)
-{
- int ret;
- va_list args;
-
- va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, SRD_LOG_SPEW, format, args);
- va_end(args);
-
- return ret;
-}
-
-/** @private */
-SRD_PRIV int srd_dbg(const char *format, ...)
-{
- int ret;
- va_list args;
-
- va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, SRD_LOG_DBG, format, args);
- va_end(args);
-
- return ret;
-}
-
-/** @private */
-SRD_PRIV int srd_info(const char *format, ...)
-{
- int ret;
- va_list args;
-
- va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, SRD_LOG_INFO, format, args);
- va_end(args);
-
- return ret;
+ return SRD_OK;
}
/** @private */
-SRD_PRIV int srd_warn(const char *format, ...)
+SRD_PRIV int srd_log(int loglevel, const char *format, ...)
{
int ret;
va_list args;
- va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, SRD_LOG_WARN, format, args);
- va_end(args);
-
- return ret;
-}
-
-/** @private */
-SRD_PRIV int srd_err(const char *format, ...)
-{
- int ret;
- va_list args;
+ /* Only output messages of at least the selected loglevel(s). */
+ if (loglevel > cur_loglevel)
+ return SRD_OK;
va_start(args, format);
- ret = srd_log_cb(srd_log_cb_data, SRD_LOG_ERR, format, args);
+ ret = srd_log_cb(srd_log_cb_data, loglevel, format, args);
va_end(args);
return ret;