X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=device.c;h=cfa5492f179a7ec5e3f2a14fc2ec997917b47849;hb=37e8b4c4f7eaa6132a25448bccc690ac764f9a63;hp=6b56da3a7ad7a727ef0fe56a5defb2caf4458e61;hpb=bf978d355345a7cc3ae7dc6199cc25952aaa182f;p=libsigrok.git diff --git a/device.c b/device.c index 6b56da3a..cfa5492f 100644 --- a/device.c +++ b/device.c @@ -19,218 +19,8 @@ #include #include -#include "sigrok.h" -#include "sigrok-internal.h" - -static GSList *devs = NULL; - -/** - * Scan the system for attached logic analyzers / devices. - * - * This will try to autodetect all supported logic analyzer devices: - * - * - Those attached via USB (can be reliably detected via USB VID/PID). - * - * - Those using a (real or virtual) serial port (detected by sending - * device-specific commands to all OS-specific serial port devices such - * as /dev/ttyS*, /dev/ttyUSB*, /dev/ttyACM*, and others). - * The autodetection for this kind of devices can potentially be unreliable. - * - * Also, sending various bytes/commands to (all!) devices which happen to - * be attached to the system via a (real or virtual) serial port can be - * problematic. There is no way for libsigrok to know how unknown devices - * react to the bytes libsigrok sends. Potentially they could lead to the - * device getting into invalid/error states, losing/overwriting data, or... - * - * In addition to the detection, the devices that are found are also - * initialized automatically. On some devices, this involves a firmware upload, - * or other such measures. - * - * The order in which the system is scanned for devices is not specified. The - * caller should not assume or rely on any specific order. - * - * After the system has been scanned for devices, the list of detected (and - * supported) devices can be acquired via sr_dev_list(). - * - * TODO: Error checks? - * TODO: Option to only scan for specific devices or device classes. - * - * @return SR_OK upon success, SR_ERR_BUG upon internal errors. - */ -SR_API int sr_dev_scan(void) -{ - int i; - struct sr_dev_driver **drivers; - - drivers = sr_driver_list(); - if (!drivers[0]) { - sr_err("dev: %s: no supported hardware drivers", __func__); - return SR_ERR_BUG; - } - - /* - * Initialize all drivers first. Since the init() call may involve - * a firmware upload and associated delay, we may as well get all - * of these out of the way first. - */ - for (i = 0; drivers[i]; i++) - sr_driver_init(drivers[i]); - - return SR_OK; -} - -/** - * Return the list of logic analyzer devices libsigrok has detected. - * - * If the libsigrok-internal device list is empty, a scan for attached - * devices -- via a call to sr_dev_scan() -- is performed first. - * - * TODO: Error handling? - * - * @return The list (GSList) of detected devices, or NULL if none were found. - */ -SR_API GSList *sr_dev_list(void) -{ - if (!devs) - sr_dev_scan(); - - return devs; -} - -/** - * Create a new device. - * - * The device is added to the (libsigrok-internal) list of devices, but - * additionally a pointer to the newly created device is also returned. - * - * The device has no probes attached to it yet after this call. You can - * use sr_dev_probe_add() to add one or more probes. - * - * TODO: Should return int, so that we can return SR_OK, SR_ERR_* etc. - * - * It is the caller's responsibility to g_free() the allocated memory when - * no longer needed. TODO: Using which API function? - * - * @param driver TODO. - * If 'driver' is NULL, the created device is a "virtual" one. - * @param driver_index TODO - * - * @return Pointer to the newly allocated device, or NULL upon errors. - */ -SR_API struct sr_dev *sr_dev_new(const struct sr_dev_driver *driver, - int driver_index) -{ - struct sr_dev *dev; - - /* TODO: Check if driver_index valid? */ - - if (!(dev = g_try_malloc0(sizeof(struct sr_dev)))) { - sr_err("dev: %s: dev malloc failed", __func__); - return NULL; - } - - dev->driver = (struct sr_dev_driver *)driver; - dev->driver_index = driver_index; - devs = g_slist_append(devs, dev); - - return dev; -} - -/** - * Add a probe with the specified name to the specified device. - * - * The added probe is automatically enabled (the 'enabled' field is TRUE). - * - * The 'trigger' field of the added probe is set to NULL. A trigger can be - * added via sr_dev_trigger_set(). - * - * TODO: Are duplicate names allowed? - * TODO: Do we enforce a maximum probe number for a device? - * TODO: Error if the max. probe number for the specific LA is reached, e.g. - * if the caller tries to add more probes than the device actually has. - * - * @param dev The device to which to add a probe with the specified name. - * Must not be NULL. - * @param name The name of the probe to add to this device. Must not be NULL. - * TODO: Maximum length, allowed characters, etc. - * - * @return SR_OK upon success, SR_ERR_MALLOC upon memory allocation errors, - * or SR_ERR_ARG upon invalid arguments. - * If something other than SR_OK is returned, 'dev' is unchanged. - */ -SR_API int sr_dev_probe_add(struct sr_dev *dev, const char *name) -{ - struct sr_probe *p; - int probenum; - - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); - return SR_ERR_ARG; - } - - if (!name) { - sr_err("dev: %s: name was NULL", __func__); - return SR_ERR_ARG; - } - - /* TODO: Further checks to ensure name is valid. */ - - probenum = g_slist_length(dev->probes) + 1; - - if (!(p = g_try_malloc0(sizeof(struct sr_probe)))) { - sr_err("dev: %s: p malloc failed", __func__); - return SR_ERR_MALLOC; - } - - p->index = probenum; - p->enabled = TRUE; - p->name = g_strdup(name); - p->trigger = NULL; - dev->probes = g_slist_append(dev->probes, p); - - return SR_OK; -} - -/** - * Find the probe with the specified number in the specified device. - * - * TODO - * - * @param dev TODO. Must not be NULL. - * @param probenum The number of the probe whose 'struct sr_probe' we want. - * Note that the probe numbers start at 1 (not 0!). - * - * TODO: Should return int. - * TODO: probenum should be unsigned. - * - * @return A pointer to the requested probe's 'struct sr_probe', or NULL - * if the probe could not be found. - */ -SR_API struct sr_probe *sr_dev_probe_find(const struct sr_dev *dev, - int probenum) -{ - GSList *l; - struct sr_probe *p, *found_probe; - - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); - return NULL; /* TODO: SR_ERR_ARG */ - } - - /* TODO: Sanity check on probenum. */ - - found_probe = NULL; - for (l = dev->probes; l; l = l->next) { - p = l->data; - /* TODO: Check for p != NULL. */ - if (p->index == probenum) { - found_probe = p; - break; - } - } - - return found_probe; -} +#include "libsigrok.h" +#include "libsigrok-internal.h" /** * Set the name of the specified probe in the specified device. @@ -238,76 +28,70 @@ SR_API struct sr_probe *sr_dev_probe_find(const struct sr_dev *dev, * If the probe already has a different name assigned to it, it will be * removed, and the new name will be saved instead. * - * @param dev TODO + * @param sdi The device instance the probe is connected to. * @param probenum The number of the probe whose name to set. - * Note that the probe numbers start at 1 (not 0!). - * @param name The new name that the specified probe should get. + * Note that the probe numbers start at 0. + * @param name The new name that the specified probe should get. A copy + * of the string is made. * - * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments, or SR_ERR - * upon other errors. - * If something other than SR_OK is returned, 'dev' is unchanged. + * @return SR_OK on success, or SR_ERR_ARG on invalid arguments. */ -SR_API int sr_dev_probe_name_set(struct sr_dev *dev, int probenum, - const char *name) +SR_API int sr_dev_probe_name_set(const struct sr_dev_inst *sdi, + int probenum, const char *name) { - struct sr_probe *p; + GSList *l; + struct sr_probe *probe; + int ret; - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); + if (!sdi) { + sr_err("%s: sdi was NULL", __func__); return SR_ERR_ARG; } - p = sr_dev_probe_find(dev, probenum); - if (!p) { - sr_err("dev: %s: probe %d not found", __func__, probenum); - return SR_ERR; /* TODO: More specific error? */ + ret = SR_ERR_ARG; + for (l = sdi->probes; l; l = l->next) { + probe = l->data; + if (probe->index == probenum) { + g_free(probe->name); + probe->name = g_strdup(name); + ret = SR_OK; + break; + } } - /* TODO: Sanity check on 'name'. */ - - /* If the probe already has a name, kill it first. */ - g_free(p->name); - - p->name = g_strdup(name); - - return SR_OK; + return ret; } /** - * Remove all triggers set up for the specified device. + * Enable or disable a probe on the specified device. * - * TODO: Better description. + * @param sdi The device instance the probe is connected to. + * @param probenum The probe number, starting from 0. + * @param state TRUE to enable the probe, FALSE to disable. * - * @param dev TODO - * - * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments. - * If something other than SR_OK is returned, 'dev' is unchanged. + * @return SR_OK on success, or SR_ERR_ARG on invalid arguments. */ -SR_API int sr_dev_trigger_remove_all(struct sr_dev *dev) +SR_API int sr_dev_probe_enable(const struct sr_dev_inst *sdi, int probenum, + gboolean state) { - struct sr_probe *p; - unsigned int pnum; /* TODO: uint16_t? */ - - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); - return SR_ERR_ARG; - } + GSList *l; + struct sr_probe *probe; + int ret; - if (!dev->probes) { - sr_err("dev: %s: dev->probes was NULL", __func__); + if (!sdi) return SR_ERR_ARG; - } - for (pnum = 1; pnum <= g_slist_length(dev->probes); pnum++) { - p = sr_dev_probe_find(dev, pnum); - /* TODO: Silently ignore probes which cannot be found? */ - if (p) { - g_free(p->trigger); - p->trigger = NULL; + ret = SR_ERR_ARG; + for (l = sdi->probes; l; l = l->next) { + probe = l->data; + if (probe->index == probenum) { + probe->enabled = state; + ret = SR_OK; + break; } } - return SR_OK; + return ret; } /** @@ -316,53 +100,42 @@ SR_API int sr_dev_trigger_remove_all(struct sr_dev *dev) * If the specified probe of this device already has a trigger, it will * be silently replaced. * - * TODO: Better description. - * TODO: Describe valid format of the 'trigger' string. - * - * @param dev TODO. Must not be NULL. - * @param probenum The number of the probe. TODO. + * @param sdi Must not be NULL. + * @param probenum The number of the probe. * Note that the probe numbers start at 1 (not 0!). - * @param trigger TODO. - * TODO: Is NULL allowed? + * @param trigger trigger string, in the format used by sigrok-cli * - * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments, or SR_ERR - * upon other errors. - * If something other than SR_OK is returned, 'dev' is unchanged. + * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments. */ -SR_API int sr_dev_trigger_set(struct sr_dev *dev, int probenum, - const char *trigger) +SR_API int sr_dev_trigger_set(const struct sr_dev_inst *sdi, int probenum, + const char *trigger) { - struct sr_probe *p; + GSList *l; + struct sr_probe *probe; + int ret; - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); + if (!sdi) return SR_ERR_ARG; - } - - /* TODO: Sanity check on 'probenum'. */ - /* TODO: Sanity check on 'trigger'. */ - - p = sr_dev_probe_find(dev, probenum); - if (!p) { - sr_err("dev: %s: probe %d not found", __func__, probenum); - return SR_ERR; /* TODO: More specific error? */ + ret = SR_ERR_ARG; + for (l = sdi->probes; l; l = l->next) { + probe = l->data; + if (probe->index == probenum) { + /* If the probe already has a trigger, kill it first. */ + g_free(probe->trigger); + probe->trigger = g_strdup(trigger); + ret = SR_OK; + break; + } } - /* If the probe already has a trigger, kill it first. */ - g_free(p->trigger); - - p->trigger = g_strdup(trigger); - sr_dbg("dev: %s: Setting '%s' trigger for probe %d.", __func__, - p->trigger, probenum); - - return SR_OK; + return ret; } /** * Determine whether the specified device has the specified capability. * - * @param dev Pointer to the device to be checked. Must not be NULL. + * @param dev Pointer to the device instance to be checked. Must not be NULL. * If the device's 'driver' field is NULL (virtual device), this * function will always return FALSE (virtual devices don't have * a hardware capabilities list). @@ -373,69 +146,23 @@ SR_API int sr_dev_trigger_set(struct sr_dev *dev, int probenum, * FALSE is also returned upon invalid input parameters or other * error conditions. */ -SR_API gboolean sr_dev_has_hwcap(const struct sr_dev *dev, int hwcap) +SR_API gboolean sr_dev_has_hwcap(const struct sr_dev_inst *sdi, int hwcap) { - int *hwcaps, i; - - sr_spew("dev: %s: requesting hwcap %d", __func__, hwcap); + const int *hwcaps; + int i; - if (!dev) { - sr_err("dev: %s: dev was NULL", __func__); + if (!sdi || !sdi->driver) return FALSE; - } - /* - * Virtual devices (which have dev->driver set to NULL) always say that - * they don't have the capability (they can't call hwcap_get_all()). - */ - if (!dev->driver) { - sr_dbg("dev: %s: dev->driver was NULL, this seems to be " - "a virtual device without capabilities", __func__); + if (sdi->driver->info_get(SR_DI_HWCAPS, + (const void **)&hwcaps, NULL) != SR_OK) return FALSE; - } - - /* TODO: Sanity check on 'hwcap'. */ - - if (!(hwcaps = dev->driver->hwcap_get_all())) { - sr_err("dev: %s: dev has no capabilities", __func__); - return FALSE; - } for (i = 0; hwcaps[i]; i++) { - if (hwcaps[i] != hwcap) - continue; - sr_spew("dev: %s: found hwcap %d", __func__, hwcap); - return TRUE; + if (hwcaps[i] == hwcap) + return TRUE; } - sr_spew("dev: %s: hwcap %d not found", __func__, hwcap); - return FALSE; } -/** - * Returns information about the given device. - * - * @param dev Pointer to the device to be checked. Must not be NULL. - * The device's 'driver' field must not be NULL either. - * @param id The type of information. - * @param data The return value. Must not be NULL. - * - * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments, or SR_ERR - * upon other errors. - */ -SR_API int sr_dev_info_get(const struct sr_dev *dev, int id, const void **data) -{ - if ((dev == NULL) || (dev->driver == NULL)) - return SR_ERR_ARG; - - if (data == NULL) - return SR_ERR_ARG; - - *data = dev->driver->dev_info_get(dev->driver_index, id); - - if (*data == NULL) - return SR_ERR; - - return SR_OK; -}