X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=device.c;h=15809e17e9625e6fbffd6a115a6c7212dd71b93d;hb=c03f045004a340bd418206cbd02eaefcede91a5b;hp=3166ea8e0c087d72431ab7269d80e0308109c2cf;hpb=0abee5076fd7751bd77d0fee940d617a1a40ea34;p=libsigrok.git

diff --git a/device.c b/device.c
index 3166ea8e..15809e17 100644
--- a/device.c
+++ b/device.c
@@ -283,7 +283,7 @@ SR_API int sr_dev_probe_name_set(struct sr_dev *dev, int probenum,
  * @return SR_OK upon success, SR_ERR_ARG upon invalid arguments.
  *         If something other than SR_OK is returned, 'dev' is unchanged.
  */
-SR_API int sr_dev_trigger_clear(struct sr_dev *dev)
+SR_API int sr_dev_trigger_remove_all(struct sr_dev *dev)
 {
 	struct sr_probe *p;
 	unsigned int pnum; /* TODO: uint16_t? */
@@ -311,7 +311,10 @@ SR_API int sr_dev_trigger_clear(struct sr_dev *dev)
 }
 
 /**
- * Add a trigger to the specified device.
+ * Add a trigger to the specified device (and the specified probe).
+ *
+ * If the specified probe of this device already has a trigger, it will
+ * be silently replaced.
  *
  * TODO: Better description.
  * TODO: Describe valid format of the 'trigger' string.
@@ -350,6 +353,8 @@ SR_API int sr_dev_trigger_set(struct sr_dev *dev, int probenum,
 	g_free(p->trigger);
 
 	p->trigger = g_strdup(trigger);
+	sr_dbg("dev: %s: Setting '%s' trigger for probe %d.", __func__,
+	       p->trigger, probenum);
 
 	return SR_OK;
 }
@@ -357,10 +362,10 @@ SR_API int sr_dev_trigger_set(struct sr_dev *dev, int probenum,
 /**
  * Determine whether the specified device has the specified capability.
  *
- * TODO: Should return int?
- *
  * @param dev Pointer to the device to be checked. Must not be NULL.
- *            The device's 'driver' field must not be NULL either.
+ *            If the device's 'driver' field is NULL (virtual device), this
+ *            function will always return FALSE (virtual devices don't have
+ *            a hardware capabilities list).
  * @param hwcap The capability that should be checked (whether it's supported
  *              by the specified device).
  *
@@ -370,23 +375,31 @@ SR_API int sr_dev_trigger_set(struct sr_dev *dev, int probenum,
  */
 SR_API gboolean sr_dev_has_hwcap(const struct sr_dev *dev, int hwcap)
 {
-	int *hwcaps, i;
+	const int *hwcaps;
+	int i;
+
+	sr_spew("dev: %s: requesting hwcap %d", __func__, hwcap);
 
 	if (!dev) {
 		sr_err("dev: %s: dev was NULL", __func__);
-		return FALSE; /* TODO: SR_ERR_ARG. */
+		return FALSE;
 	}
 
+	/*
+	 * Virtual devices (which have dev->driver set to NULL) always say that
+	 * they don't have the capability (they can't call hwcap_get_all()).
+	 */
 	if (!dev->driver) {
-		sr_err("dev: %s: dev->driver was NULL", __func__);
-		return FALSE; /* TODO: SR_ERR_ARG. */
+		sr_dbg("dev: %s: dev->driver was NULL, this seems to be "
+		       "a virtual device without capabilities", __func__);
+		return FALSE;
 	}
 
 	/* TODO: Sanity check on 'hwcap'. */
 
 	if (!(hwcaps = dev->driver->hwcap_get_all())) {
 		sr_err("dev: %s: dev has no capabilities", __func__);
-		return FALSE; /* TODO: SR_ERR*. */
+		return FALSE;
 	}
 
 	for (i = 0; hwcaps[i]; i++) {