X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=decoders%2Fuart%2Fpd.py;h=0c6b839d21cc72abe889064924b7b192f1f057bc;hb=86f685145345cabef1373a1242016b769ff199b4;hp=18507cf7597924516342f0aceafcb2963af2c892;hpb=3dd546c15fc973b3495f0d2557333e9ef31ca7dd;p=libsigrokdecode.git

diff --git a/decoders/uart/pd.py b/decoders/uart/pd.py
index 18507cf..0c6b839 100644
--- a/decoders/uart/pd.py
+++ b/decoders/uart/pd.py
@@ -95,13 +95,25 @@ class Decoder(srd.Decoder):
         # TODO: Options to invert the signal(s).
     }
     annotations = [
-        ['rx-data', 'UART RX data'],
-        ['tx-data', 'UART TX data'],
-        ['start-bits', 'UART start bits'],
-        ['parity-bits', 'UART parity bits'],
-        ['stop-bits', 'UART stop bits'],
-        ['warnings', 'Warnings'],
+        ['rx-data', 'RX data'],
+        ['tx-data', 'TX data'],
+        ['rx-start', 'RX start bits'],
+        ['tx-start', 'TX start bits'],
+        ['rx-parity-ok', 'RX parity OK bits'],
+        ['tx-parity-ok', 'TX parity OK bits'],
+        ['rx-parity-err', 'RX parity error bits'],
+        ['tx-parity-err', 'TX parity error bits'],
+        ['rx-stop', 'RX stop bits'],
+        ['tx-stop', 'TX stop bits'],
+        ['rx-warnings', 'RX warnings'],
+        ['tx-warnings', 'TX warnings'],
     ]
+    annotation_rows = (
+        ('rx-data', 'RX', (0, 2, 4, 6, 8)),
+        ('tx-data', 'TX', (1, 3, 5, 7, 9)),
+        ('rx-warnings', 'RX warnings', (10,)),
+        ('tx-warnings', 'TX warnings', (11,)),
+    )
     binary = (
         ('rx', 'RX dump'),
         ('tx', 'TX dump'),
@@ -196,7 +208,7 @@ class Decoder(srd.Decoder):
         self.state[rxtx] = 'GET DATA BITS'
 
         self.putp(['STARTBIT', rxtx, self.startbit[rxtx]])
-        self.putg([2, ['Start bit', 'Start', 'S']])
+        self.putg([rxtx + 2, ['Start bit', 'Start', 'S']])
 
     def get_data_bits(self, rxtx, signal):
         # Skip samples until we're in the middle of the desired data bit.
@@ -263,11 +275,11 @@ class Decoder(srd.Decoder):
         if parity_ok(self.options['parity_type'], self.paritybit[rxtx],
                      self.databyte[rxtx], self.options['num_data_bits']):
             self.putp(['PARITYBIT', rxtx, self.paritybit[rxtx]])
-            self.putg([3, ['Parity bit', 'Parity', 'P']])
+            self.putg([rxtx + 4, ['Parity bit', 'Parity', 'P']])
         else:
             # TODO: Return expected/actual parity values.
             self.putp(['PARITY ERROR', rxtx, (0, 1)]) # FIXME: Dummy tuple...
-            self.putg([5, ['Parity error', 'Parity err', 'PE']])
+            self.putg([rxtx + 6, ['Parity error', 'Parity err', 'PE']])
 
     # TODO: Currently only supports 1 stop bit.
     def get_stop_bits(self, rxtx, signal):
@@ -282,13 +294,13 @@ class Decoder(srd.Decoder):
         # Stop bits must be 1. If not, we report an error.
         if self.stopbit1[rxtx] != 1:
             self.putp(['INVALID STOPBIT', rxtx, self.stopbit1[rxtx]])
-            self.putg([5, ['Frame error', 'Frame err', 'FE']])
+            self.putg([rxtx + 8, ['Frame error', 'Frame err', 'FE']])
             # TODO: Abort? Ignore the frame? Other?
 
         self.state[rxtx] = 'WAIT FOR START BIT'
 
         self.putp(['STOPBIT', rxtx, self.stopbit1[rxtx]])
-        self.putg([4, ['Stop bit', 'Stop', 'T']])
+        self.putg([rxtx + 4, ['Stop bit', 'Stop', 'T']])
 
     def decode(self, ss, es, data):
         if self.samplerate is None: