X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=decoders%2Fmx25lxx05d%2Fmx25lxx05d.py;h=80b1a658872351062bc7effcf0ff73f489f2a596;hb=6d990fe1dbf441eb9f090898e7c3a57889b26aef;hp=61ec185fc184597e70d11b39a7922c7d2280e7f9;hpb=385508e9b12d87519f9144a67e7682b46a592200;p=libsigrokdecode.git

diff --git a/decoders/mx25lxx05d/mx25lxx05d.py b/decoders/mx25lxx05d/mx25lxx05d.py
index 61ec185..80b1a65 100644
--- a/decoders/mx25lxx05d/mx25lxx05d.py
+++ b/decoders/mx25lxx05d/mx25lxx05d.py
@@ -18,17 +18,9 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 ##
 
-#
-# Macronix MX25Lxx05D SPI (NOR) flash chip decoder.
-# Works for MX25L1605D/MX25L3205D/MX25L6405D.
-#
+# Macronix MX25Lxx05D SPI (NOR) flash chip protocol decoder
 
-#
-# TODO: Description
-#
-# Details:
-# http://www.macronix.com/QuickPlace/hq/PageLibrary4825740B00298A3B.nsf/h_Index/3F21BAC2E121E17848257639003A3146/$File/MX25L1605D-3205D-6405D-1.5.pdf
-#
+# Note: Works for MX25L1605D/MX25L3205D/MX25L6405D.
 
 import sigrokdecode as srd
 
@@ -107,12 +99,11 @@ class Decoder(srd.Decoder):
     name = 'MX25Lxx05D'
     longname = 'Macronix MX25Lxx05D'
     desc = 'Macronix MX25Lxx05D SPI flash chip decoder'
-    longdesc = 'TODO'
     license = 'gplv2+'
     inputs = ['spi', 'logic']
     outputs = ['mx25lxx05d']
     probes = []
-    extra_probes = [
+    optional_probes = [
         {'id': 'hold', 'name': 'HOLD#', 'desc': 'TODO.'},
         {'id': 'wp_acc', 'name': 'WP#/ACC', 'desc': 'TODO.'},
     ]
@@ -218,7 +209,7 @@ class Decoder(srd.Decoder):
             self.putx([0, ['%s ID' % d]])
         elif self.cmdstate == 6:
             # Byte 6: Slave sends device ID (or manufacturer ID).
-            self.ids += [miso]
+            self.ids.append(miso)
             d = 'Manufacturer' if self.manufacturer_id_first else 'Device'
             self.putx([0, ['%s ID' % d]])
         else:
@@ -256,8 +247,6 @@ class Decoder(srd.Decoder):
                 self.cmdstate = 1
             else:
                 pass # TODO
-        else:
-            pass
 
         # Handle commands.
         # TODO: Use some generic way to invoke the resp. method.