X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=src%2Fhardware%2Ffx2lafw%2Fdslogic.c;h=ec8d53427b9536e798ad9503657104070dc1963b;hb=5faebab2903dc91949edc31f0a4b118d86090a30;hp=715ca8a571bcb69cc2963fbe6a3e5497901004cb;hpb=98fec29ecbb5093856b69311be8e937c162edded;p=libsigrok.git diff --git a/src/hardware/fx2lafw/dslogic.c b/src/hardware/fx2lafw/dslogic.c index 715ca8a5..ec8d5342 100644 --- a/src/hardware/fx2lafw/dslogic.c +++ b/src/hardware/fx2lafw/dslogic.c @@ -18,10 +18,7 @@ * along with this program. If not, see . */ -#include -#include -#include -#include +#include #include #include #include @@ -30,56 +27,67 @@ #define FW_BUFSIZE (4 * 1024) -int dslogic_fpga_firmware_upload(const struct sr_dev_inst *sdi, - const char *filename) +#define FPGA_UPLOAD_DELAY (10 * 1000) + +#define USB_TIMEOUT (3 * 1000) + +SR_PRIV int dslogic_fpga_firmware_upload(const struct sr_dev_inst *sdi, + const char *name) { - FILE *fw; - struct stat st; + uint64_t sum; + struct sr_resource bitstream; + struct drv_context *drvc; struct sr_usb_dev_inst *usb; - int chunksize, result, ret; unsigned char *buf; - int sum, transferred; - - sr_dbg("Uploading FPGA firmware at %s.", filename); + ssize_t chunksize; + int transferred; + int result, ret; + uint8_t cmd[3]; + drvc = sdi->driver->context; usb = sdi->conn; - if (stat(filename, &st) < 0) { - sr_err("Unable to upload FPGA firmware: %s", strerror(errno)); - return SR_ERR; - } + + sr_dbg("Uploading FPGA firmware '%s'.", name); + + result = sr_resource_open(drvc->sr_ctx, &bitstream, + SR_RESOURCE_FIRMWARE, name); + if (result != SR_OK) + return result; /* Tell the device firmware is coming. */ + memset(cmd, 0, sizeof(cmd)); if ((ret = libusb_control_transfer(usb->devhdl, LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT, DS_CMD_FPGA_FW, 0x0000, 0x0000, - NULL, 0, 3000)) < 0) { + (unsigned char *)&cmd, sizeof(cmd), USB_TIMEOUT)) < 0) { sr_err("Failed to upload FPGA firmware: %s.", libusb_error_name(ret)); - return SR_ERR; - } - buf = g_malloc(FW_BUFSIZE); - - if (!(fw = g_fopen(filename, "rb"))) { - sr_err("Unable to open %s for reading: %s.", filename, strerror(errno)); + sr_resource_close(drvc->sr_ctx, &bitstream); return SR_ERR; } /* Give the FX2 time to get ready for FPGA firmware upload. */ - g_usleep(10 * 1000); + g_usleep(FPGA_UPLOAD_DELAY); + buf = g_malloc(FW_BUFSIZE); sum = 0; result = SR_OK; while (1) { - if ((chunksize = fread(buf, 1, FW_BUFSIZE, fw)) == 0) + chunksize = sr_resource_read(drvc->sr_ctx, &bitstream, + buf, FW_BUFSIZE); + if (chunksize < 0) + result = SR_ERR; + if (chunksize <= 0) break; if ((ret = libusb_bulk_transfer(usb->devhdl, 2 | LIBUSB_ENDPOINT_OUT, - buf, chunksize, &transferred, 1000)) < 0) { + buf, chunksize, &transferred, USB_TIMEOUT)) < 0) { sr_err("Unable to configure FPGA firmware: %s.", libusb_error_name(ret)); result = SR_ERR; break; } sum += transferred; - sr_spew("Uploaded %d/%d bytes.", sum, st.st_size); + sr_spew("Uploaded %" PRIu64 "/%" PRIu64 " bytes.", + sum, bitstream.size); if (transferred != chunksize) { sr_err("Short transfer while uploading FPGA firmware."); @@ -87,15 +95,16 @@ int dslogic_fpga_firmware_upload(const struct sr_dev_inst *sdi, break; } } - fclose(fw); g_free(buf); + sr_resource_close(drvc->sr_ctx, &bitstream); + if (result == SR_OK) sr_dbg("FPGA firmware upload done."); return result; } -int dslogic_start_acquisition(const struct sr_dev_inst *sdi) +SR_PRIV int dslogic_start_acquisition(const struct sr_dev_inst *sdi) { struct dev_context *devc; struct sr_usb_dev_inst *usb; @@ -111,7 +120,7 @@ int dslogic_start_acquisition(const struct sr_dev_inst *sdi) usb = sdi->conn; ret = libusb_control_transfer(usb->devhdl, LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT, DS_CMD_START, 0x0000, 0x0000, - (unsigned char *)&mode, sizeof(mode), 3000); + (unsigned char *)&mode, sizeof(mode), USB_TIMEOUT); if (ret < 0) { sr_err("Failed to send start command: %s.", libusb_error_name(ret)); return SR_ERR; @@ -120,7 +129,7 @@ int dslogic_start_acquisition(const struct sr_dev_inst *sdi) return SR_OK; } -int dslogic_stop_acquisition(const struct sr_dev_inst *sdi) +SR_PRIV int dslogic_stop_acquisition(const struct sr_dev_inst *sdi) { struct sr_usb_dev_inst *usb; struct dslogic_mode mode; @@ -132,7 +141,7 @@ int dslogic_stop_acquisition(const struct sr_dev_inst *sdi) usb = sdi->conn; ret = libusb_control_transfer(usb->devhdl, LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT, DS_CMD_START, 0x0000, 0x0000, - (unsigned char *)&mode, sizeof(struct dslogic_mode), 3000); + (unsigned char *)&mode, sizeof(struct dslogic_mode), USB_TIMEOUT); if (ret < 0) { sr_err("Failed to send stop command: %s.", libusb_error_name(ret)); return SR_ERR; @@ -141,7 +150,7 @@ int dslogic_stop_acquisition(const struct sr_dev_inst *sdi) return SR_OK; } -int dslogic_fpga_configure(const struct sr_dev_inst *sdi) +SR_PRIV int dslogic_fpga_configure(const struct sr_dev_inst *sdi) { struct dev_context *devc; struct sr_usb_dev_inst *usb; @@ -183,7 +192,7 @@ int dslogic_fpga_configure(const struct sr_dev_inst *sdi) ret = libusb_control_transfer(usb->devhdl, LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT, DS_CMD_CONFIG, 0x0000, 0x0000, - c, 3, 100); + c, 3, USB_TIMEOUT); if (ret < 0) { sr_err("Failed to send FPGA configure command: %s.", libusb_error_name(ret)); return SR_ERR; @@ -219,8 +228,7 @@ int dslogic_fpga_configure(const struct sr_dev_inst *sdi) len = sizeof(struct dslogic_fpga_config); ret = libusb_bulk_transfer(usb->devhdl, 2 | LIBUSB_ENDPOINT_OUT, - (unsigned char *)&cfg, len, - &transferred, 100); + (unsigned char *)&cfg, len, &transferred, USB_TIMEOUT); if (ret < 0 || transferred != len) { sr_err("Failed to send FPGA configuration: %s.", libusb_error_name(ret)); return SR_ERR;