X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=pv%2Fview%2Fview.cpp;h=04bb99205636fd50ffe18872f56dd3ba2dcd3bb5;hb=820ce18a827fe02f5ed73e2bbd16ecad9c8e2e94;hp=15dd05812637d054287b605fc919374e7c150edd;hpb=1a2288a1b2479be9001fab6ced8385cfc86c3f69;p=pulseview.git
diff --git a/pv/view/view.cpp b/pv/view/view.cpp
index 15dd0581..04bb9920 100644
--- a/pv/view/view.cpp
+++ b/pv/view/view.cpp
@@ -14,8 +14,7 @@
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ * along with this program; if not, see .
*/
#ifdef ENABLE_DECODE
@@ -28,13 +27,18 @@
#include
#include
#include
+#include
#include
#include
#include
+#include
+#include
+#include
#include
#include
+#include
#include
#include
#include
@@ -42,7 +46,7 @@
#include
-#include "decodetrace.hpp"
+#include "analogsignal.hpp"
#include "header.hpp"
#include "logicsignal.hpp"
#include "ruler.hpp"
@@ -53,11 +57,16 @@
#include "viewport.hpp"
#include "pv/session.hpp"
+#include "pv/globalsettings.hpp"
#include "pv/devices/device.hpp"
#include "pv/data/logic.hpp"
#include "pv/data/logicsegment.hpp"
#include "pv/util.hpp"
+#ifdef ENABLE_DECODE
+#include "decodetrace.hpp"
+#endif
+
using boost::shared_lock;
using boost::shared_mutex;
@@ -87,7 +96,8 @@ using std::vector;
using std::weak_ptr;
namespace pv {
-namespace view {
+namespace views {
+namespace TraceView {
const Timestamp View::MaxScale("1e9");
const Timestamp View::MinScale("1e-12");
@@ -97,12 +107,41 @@ const int View::MaxViewAutoUpdateRate = 25; // No more than 25 Hz with sticky sc
const int View::ScaleUnits[3] = {1, 2, 5};
-View::View(Session &session, QWidget *parent) :
- QAbstractScrollArea(parent),
- session_(session),
+
+CustomAbstractScrollArea::CustomAbstractScrollArea(QWidget *parent) :
+ QAbstractScrollArea(parent)
+{
+}
+
+void CustomAbstractScrollArea::setViewportMargins(int left, int top, int right, int bottom)
+{
+ QAbstractScrollArea::setViewportMargins(left, top, right, bottom);
+}
+
+bool CustomAbstractScrollArea::viewportEvent(QEvent *event)
+{
+ switch (event->type()) {
+ case QEvent::Paint:
+ case QEvent::MouseButtonPress:
+ case QEvent::MouseButtonRelease:
+ case QEvent::MouseButtonDblClick:
+ case QEvent::MouseMove:
+ case QEvent::Wheel:
+ case QEvent::TouchBegin:
+ case QEvent::TouchUpdate:
+ case QEvent::TouchEnd:
+ return false;
+ default:
+ return QAbstractScrollArea::viewportEvent(event);
+ }
+}
+
+View::View(Session &session, bool is_main_view, QWidget *parent) :
+ ViewBase(session, is_main_view, parent),
viewport_(new Viewport(*this)),
ruler_(new Ruler(*this)),
header_(new Header(*this)),
+ scrollarea_(this),
scale_(1e-3),
offset_(0),
updating_scroll_(false),
@@ -115,23 +154,20 @@ View::View(Session &session, QWidget *parent) :
show_cursors_(false),
cursors_(new CursorPair(*this)),
next_flag_text_('A'),
- trigger_marker_(nullptr),
- hover_point_(-1, -1)
+ trigger_markers_(),
+ hover_point_(-1, -1),
+ scroll_needs_defaults_(false),
+ saved_v_offset_(0),
+ size_finalized_(false)
{
- connect(horizontalScrollBar(), SIGNAL(valueChanged(int)),
+ GlobalSettings settings;
+ coloured_bg_ = settings.value(GlobalSettings::Key_View_ColouredBG).toBool();
+
+ connect(scrollarea_.horizontalScrollBar(), SIGNAL(valueChanged(int)),
this, SLOT(h_scroll_value_changed(int)));
- connect(verticalScrollBar(), SIGNAL(valueChanged(int)),
+ connect(scrollarea_.verticalScrollBar(), SIGNAL(valueChanged(int)),
this, SLOT(v_scroll_value_changed()));
- connect(&session_, SIGNAL(signals_changed()),
- this, SLOT(signals_changed()));
- connect(&session_, SIGNAL(capture_state_changed(int)),
- this, SLOT(capture_state_updated(int)));
- connect(&session_, SIGNAL(data_received()),
- this, SLOT(data_updated()));
- connect(&session_, SIGNAL(frame_ended()),
- this, SLOT(data_updated()));
-
connect(header_, SIGNAL(selection_changed()),
ruler_, SLOT(clear_selection()));
connect(ruler_, SIGNAL(selection_changed()),
@@ -154,7 +190,13 @@ View::View(Session &session, QWidget *parent) :
delayed_view_updater_.setSingleShot(true);
delayed_view_updater_.setInterval(1000 / MaxViewAutoUpdateRate);
- setViewport(viewport_);
+ /* To let the scroll area fill up the parent QWidget (this), we need a layout */
+ QHBoxLayout *layout = new QHBoxLayout(this);
+ setLayout(layout);
+ layout->setContentsMargins(0, 0, 0, 0);
+ layout->addWidget(&scrollarea_);
+
+ scrollarea_.setViewport(viewport_);
viewport_->installEventFilter(this);
ruler_->installEventFilter(this);
@@ -182,6 +224,45 @@ const Session& View::session() const
return session_;
}
+std::unordered_set< std::shared_ptr > View::signals() const
+{
+ return signals_;
+}
+
+void View::clear_signals()
+{
+ signals_.clear();
+}
+
+void View::add_signal(const shared_ptr signal)
+{
+ signals_.insert(signal);
+}
+
+#ifdef ENABLE_DECODE
+void View::clear_decode_signals()
+{
+ decode_traces_.clear();
+}
+
+void View::add_decode_signal(shared_ptr signalbase)
+{
+ shared_ptr d(
+ new DecodeTrace(session_, signalbase, decode_traces_.size()));
+ decode_traces_.push_back(d);
+}
+
+void View::remove_decode_signal(shared_ptr signalbase)
+{
+ for (auto i = decode_traces_.begin(); i != decode_traces_.end(); i++)
+ if ((*i)->base() == signalbase) {
+ decode_traces_.erase(i);
+ signals_changed();
+ return;
+ }
+}
+#endif
+
View* View::view()
{
return this;
@@ -202,6 +283,57 @@ const Viewport* View::viewport() const
return viewport_;
}
+void View::save_settings(QSettings &settings) const
+{
+ settings.setValue("scale", scale_);
+ settings.setValue("v_offset",
+ scrollarea_.verticalScrollBar()->sliderPosition());
+
+ std::stringstream ss;
+ boost::archive::text_oarchive oa(ss);
+ oa << boost::serialization::make_nvp("offset", offset_);
+ settings.setValue("offset", QString::fromStdString(ss.str()));
+
+ for (shared_ptr signal : signals_) {
+ settings.beginGroup(signal->base()->internal_name());
+ signal->save_settings(settings);
+ settings.endGroup();
+ }
+}
+
+void View::restore_settings(QSettings &settings)
+{
+ // Note: It is assumed that this function is only called once,
+ // immediately after restoring a previous session.
+
+ if (settings.contains("scale"))
+ set_scale(settings.value("scale").toDouble());
+
+ if (settings.contains("offset")) {
+ util::Timestamp offset;
+ std::stringstream ss;
+ ss << settings.value("offset").toString().toStdString();
+
+ boost::archive::text_iarchive ia(ss);
+ ia >> boost::serialization::make_nvp("offset", offset);
+
+ set_offset(offset);
+ }
+
+ for (shared_ptr signal : signals_) {
+ settings.beginGroup(signal->base()->internal_name());
+ signal->restore_settings(settings);
+ settings.endGroup();
+ }
+
+ if (settings.contains("v_offset")) {
+ saved_v_offset_ = settings.value("v_offset").toInt();
+ set_v_offset(saved_v_offset_);
+ scroll_needs_defaults_ = false;
+ // Note: see resizeEvent() for additional information
+ }
+}
+
vector< shared_ptr > View::time_items() const
{
const vector> f(flags());
@@ -210,8 +342,8 @@ vector< shared_ptr > View::time_items() const
items.push_back(cursors_->first());
items.push_back(cursors_->second());
- if (trigger_marker_)
- items.push_back(trigger_marker_);
+ for (auto trigger_marker : trigger_markers_)
+ items.push_back(trigger_marker);
return items;
}
@@ -244,12 +376,12 @@ void View::set_offset(const pv::util::Timestamp& offset)
int View::owner_visual_v_offset() const
{
- return -verticalScrollBar()->sliderPosition();
+ return -scrollarea_.verticalScrollBar()->sliderPosition();
}
void View::set_v_offset(int offset)
{
- verticalScrollBar()->setSliderPosition(offset);
+ scrollarea_.verticalScrollBar()->setSliderPosition(offset);
header_->update();
viewport_->update();
}
@@ -393,11 +525,9 @@ void View::set_scale_offset(double scale, const Timestamp& offset)
set< shared_ptr > View::get_visible_data() const
{
- const unordered_set< shared_ptr > sigs(session().signals());
-
// Make a set of all the visible data objects
set< shared_ptr > visible_data;
- for (const shared_ptr sig : sigs)
+ for (const shared_ptr sig : signals_)
if (sig->enabled())
visible_data.insert(sig->data());
@@ -408,8 +538,7 @@ pair View::get_time_extents() const
{
boost::optional left_time, right_time;
const set< shared_ptr > visible_data = get_visible_data();
- for (const shared_ptr d : visible_data)
- {
+ for (const shared_ptr d : visible_data) {
const vector< shared_ptr > segments =
d->segments();
for (const shared_ptr &s : segments) {
@@ -438,6 +567,38 @@ void View::enable_sticky_scrolling(bool state)
sticky_scrolling_ = state;
}
+void View::toggle_sticky_scrolling(void)
+{
+ sticky_scrolling_ = !sticky_scrolling_;
+}
+
+void View::enable_coloured_bg(bool state)
+{
+ const vector> items(
+ list_by_type());
+
+ for (shared_ptr i : items) {
+ // Can't cast to Trace because it's abstract, so we need to
+ // check for any derived classes individually
+
+ shared_ptr a = dynamic_pointer_cast(i);
+ if (a)
+ a->set_coloured_bg(state);
+
+ shared_ptr l = dynamic_pointer_cast(i);
+ if (l)
+ l->set_coloured_bg(state);
+
+#ifdef ENABLE_DECODE
+ shared_ptr d = dynamic_pointer_cast(i);
+ if (d)
+ d->set_coloured_bg(state);
+#endif
+ }
+
+ viewport_->update();
+}
+
bool View::cursors_shown() const
{
return show_cursors_;
@@ -497,13 +658,6 @@ const QPoint& View::hover_point() const
return hover_point_;
}
-void View::update_viewport()
-{
- assert(viewport_);
- viewport_->update();
- header_->update();
-}
-
void View::restack_all_trace_tree_items()
{
// Make a list of owners that is sorted from deepest first
@@ -521,6 +675,12 @@ void View::restack_all_trace_tree_items()
for (auto &o : sorted_owners)
o->restack_items();
+ // Re-assign background colors
+ bool next_bgcolour_state = 0;
+
+ for (auto &o : sorted_owners)
+ next_bgcolour_state = o->reassign_bgcolour_states(next_bgcolour_state);
+
// Animate the items to their destination
for (const auto &i : items)
i->animate_to_layout_v_offset();
@@ -528,10 +688,8 @@ void View::restack_all_trace_tree_items()
void View::trigger_event(util::Timestamp location)
{
- if (trigger_marker_)
- trigger_marker_->set_time(location);
- else
- trigger_marker_ = std::shared_ptr(new TriggerMarker(*this, location));
+ trigger_markers_.push_back(shared_ptr(
+ new TriggerMarker(*this, location)));
}
void View::get_scroll_layout(double &length, Timestamp &offset) const
@@ -623,6 +781,8 @@ void View::calculate_tick_spacing()
void View::update_scroll()
{
assert(viewport_);
+ QScrollBar *hscrollbar = scrollarea_.horizontalScrollBar();
+ QScrollBar *vscrollbar = scrollarea_.verticalScrollBar();
const QSize areaSize = viewport_->size();
@@ -634,35 +794,70 @@ void View::update_scroll()
int major_tick_distance = (tick_period_ / scale_).convert_to();
- horizontalScrollBar()->setPageStep(areaSize.width() / 2);
- horizontalScrollBar()->setSingleStep(major_tick_distance);
+ hscrollbar->setPageStep(areaSize.width() / 2);
+ hscrollbar->setSingleStep(major_tick_distance);
updating_scroll_ = true;
if (length < MaxScrollValue) {
- horizontalScrollBar()->setRange(0, length);
- horizontalScrollBar()->setSliderPosition(offset.convert_to());
+ hscrollbar->setRange(0, length);
+ hscrollbar->setSliderPosition(offset.convert_to());
} else {
- horizontalScrollBar()->setRange(0, MaxScrollValue);
- horizontalScrollBar()->setSliderPosition(
+ hscrollbar->setRange(0, MaxScrollValue);
+ hscrollbar->setSliderPosition(
(offset_ * MaxScrollValue / (scale_ * length)).convert_to());
}
updating_scroll_ = false;
// Set the vertical scrollbar
- verticalScrollBar()->setPageStep(areaSize.height());
- verticalScrollBar()->setSingleStep(areaSize.height() / 8);
+ vscrollbar->setPageStep(areaSize.height());
+ vscrollbar->setSingleStep(areaSize.height() / 8);
+
+ const pair extents = v_extents();
+
+ // Don't change the scrollbar range if there are no traces
+ if (extents.first != extents.second)
+ vscrollbar->setRange(extents.first - areaSize.height(),
+ extents.second);
+
+ if (scroll_needs_defaults_)
+ set_scroll_default();
+}
+
+void View::reset_scroll()
+{
+ scrollarea_.verticalScrollBar()->setRange(0, 0);
+}
+
+void View::set_scroll_default()
+{
+ assert(viewport_);
+
+ const QSize areaSize = viewport_->size();
const pair extents = v_extents();
- verticalScrollBar()->setRange(extents.first - (areaSize.height() / 2),
- extents.second - (areaSize.height() / 2));
+ const int trace_height = extents.second - extents.first;
+
+ // Do all traces fit in the view?
+ if (areaSize.height() >= trace_height)
+ // Center all traces vertically
+ set_v_offset(extents.first -
+ ((areaSize.height() - trace_height) / 2));
+ else
+ // Put the first trace at the top, letting the bottom ones overflow
+ set_v_offset(extents.first);
+
+ // If we're not sure whether setting the defaults worked as
+ // the window wasn't set up entirely yet, we want to be called
+ // again later to make sure
+ scroll_needs_defaults_ = !size_finalized_;
}
void View::update_layout()
{
- setViewportMargins(
- header_->sizeHint().width() - pv::view::Header::BaselineOffset,
+ scrollarea_.setViewportMargins(
+ header_->sizeHint().width() - Header::BaselineOffset,
ruler_->sizeHint().height(), 0, 0);
ruler_->setGeometry(viewport_->x(), 0,
viewport_->width(), ruler_->extended_size_hint().height());
@@ -671,22 +866,9 @@ void View::update_layout()
update_scroll();
}
-void View::paint_label(QPainter &p, const QRect &rect, bool hover)
-{
- (void)p;
- (void)rect;
- (void)hover;
-}
-
-QRectF View::label_rect(const QRectF &rect)
-{
- (void)rect;
- return QRectF();
-}
-
TraceTreeItemOwner* View::find_prevalent_trace_group(
const shared_ptr &group,
- const unordered_map, shared_ptr >
+ const unordered_map, shared_ptr >
&signal_map)
{
assert(group);
@@ -696,13 +878,13 @@ TraceTreeItemOwner* View::find_prevalent_trace_group(
// Make a set and a list of all the owners
for (const auto &channel : group->channels()) {
- const auto iter = signal_map.find(channel);
- if (iter == signal_map.end())
- continue;
-
- TraceTreeItemOwner *const o = (*iter).second->owner();
- owner_list.push_back(o);
- owners.insert(o);
+ for (auto entry : signal_map) {
+ if (entry.first->channel() == channel) {
+ TraceTreeItemOwner *const o = (entry.second)->owner();
+ owner_list.push_back(o);
+ owners.insert(o);
+ }
+ }
}
// Iterate through the list of owners, and find the most prevalent
@@ -723,25 +905,24 @@ TraceTreeItemOwner* View::find_prevalent_trace_group(
vector< shared_ptr > View::extract_new_traces_for_channels(
const vector< shared_ptr > &channels,
- const unordered_map, shared_ptr >
+ const unordered_map, shared_ptr >
&signal_map,
set< shared_ptr > &add_list)
{
vector< shared_ptr > filtered_traces;
- for (const auto &channel : channels)
- {
- const auto map_iter = signal_map.find(channel);
- if (map_iter == signal_map.end())
- continue;
-
- shared_ptr trace = (*map_iter).second;
- const auto list_iter = add_list.find(trace);
- if (list_iter == add_list.end())
- continue;
-
- filtered_traces.push_back(trace);
- add_list.erase(list_iter);
+ for (const auto &channel : channels) {
+ for (auto entry : signal_map) {
+ if (entry.first->channel() == channel) {
+ shared_ptr trace = entry.second;
+ const auto list_iter = add_list.find(trace);
+ if (list_iter == add_list.end())
+ continue;
+
+ filtered_traces.push_back(trace);
+ add_list.erase(list_iter);
+ }
+ }
}
return filtered_traces;
@@ -751,10 +932,8 @@ void View::determine_time_unit()
{
// Check whether we know the sample rate and hence can use time as the unit
if (time_unit_ == util::TimeUnit::Samples) {
- const unordered_set< shared_ptr > sigs(session().signals());
-
// Check all signals but...
- for (const shared_ptr signal : sigs) {
+ for (const shared_ptr signal : signals_) {
const shared_ptr data = signal->data();
// ...only check first segment of each
@@ -793,28 +972,30 @@ bool View::eventFilter(QObject *object, QEvent *event)
return QObject::eventFilter(object, event);
}
-bool View::viewportEvent(QEvent *e)
+void View::resizeEvent(QResizeEvent*)
{
- switch(e->type()) {
- case QEvent::Paint:
- case QEvent::MouseButtonPress:
- case QEvent::MouseButtonRelease:
- case QEvent::MouseButtonDblClick:
- case QEvent::MouseMove:
- case QEvent::Wheel:
- case QEvent::TouchBegin:
- case QEvent::TouchUpdate:
- case QEvent::TouchEnd:
- return false;
+ update_layout();
- default:
- return QAbstractScrollArea::viewportEvent(e);
+ // This is somewhat of a hack, unfortunately. We cannot use
+ // set_v_offset() from within restore_settings() as the view
+ // at that point is neither visible nor properly sized.
+ // This is the least intrusive workaround I could come up
+ // with: set the vertical offset (or scroll defaults) when
+ // the view is visible and resized to its final size.
+ // Resize events that are sent when the view is not visible
+ // must be ignored as they have wrong sizes, potentially
+ // preventing the v offset from being set successfully.
+
+ if (isVisible())
+ size_finalized_ = true;
+
+ if (size_finalized_ && saved_v_offset_) {
+ set_v_offset(saved_v_offset_);
+ saved_v_offset_ = 0;
}
-}
-void View::resizeEvent(QResizeEvent*)
-{
- update_layout();
+ if (size_finalized_ && scroll_needs_defaults_)
+ set_scroll_default();
}
void View::row_item_appearance_changed(bool label, bool content)
@@ -853,7 +1034,7 @@ void View::h_scroll_value_changed(int value)
sticky_scrolling_changed(false);
}
- const int range = horizontalScrollBar()->maximum();
+ const int range = scrollarea_.horizontalScrollBar()->maximum();
if (range < MaxScrollValue)
set_offset(scale_ * value);
else {
@@ -877,17 +1058,25 @@ void View::signals_changed()
{
using sigrok::Channel;
- vector< shared_ptr > new_top_level_items;
+ vector< shared_ptr > channels;
+ shared_ptr sr_dev;
- const auto device = session_.device();
- if (!device)
- return;
+ // Do we need to set the vertical scrollbar to its default position later?
+ // We do if there are no traces, i.e. the scroll bar has no range set
+ bool reset_scrollbar =
+ (scrollarea_.verticalScrollBar()->minimum() ==
+ scrollarea_.verticalScrollBar()->maximum());
- shared_ptr sr_dev = device->device();
- assert(sr_dev);
+ if (!session_.device()) {
+ reset_scroll();
+ signals_.clear();
+ } else {
+ sr_dev = session_.device()->device();
+ assert(sr_dev);
+ channels = sr_dev->channels();
+ }
- const vector< shared_ptr > channels(
- sr_dev->channels());
+ vector< shared_ptr > new_top_level_items;
// Make a list of traces that are being added, and a list of traces
// that are being removed
@@ -895,14 +1084,10 @@ void View::signals_changed()
const set> prev_traces(
prev_trace_list.begin(), prev_trace_list.end());
- const unordered_set< shared_ptr > sigs(session_.signals());
-
- set< shared_ptr > traces(sigs.begin(), sigs.end());
+ set< shared_ptr > traces(signals_.begin(), signals_.end());
#ifdef ENABLE_DECODE
- const vector< shared_ptr > decode_traces(
- session().get_decode_signals());
- traces.insert(decode_traces.begin(), decode_traces.end());
+ traces.insert(decode_traces_.begin(), decode_traces_.end());
#endif
set< shared_ptr > add_traces;
@@ -916,75 +1101,84 @@ void View::signals_changed()
inserter(remove_traces, remove_traces.begin()));
// Make a look-up table of sigrok Channels to pulseview Signals
- unordered_map, shared_ptr >
+ unordered_map, shared_ptr >
signal_map;
- for (const shared_ptr &sig : sigs)
- signal_map[sig->channel()] = sig;
+ for (const shared_ptr &sig : signals_)
+ signal_map[sig->base()] = sig;
// Populate channel groups
- for (auto entry : sr_dev->channel_groups())
- {
- const shared_ptr &group = entry.second;
-
- if (group->channels().size() <= 1)
- continue;
-
- // Find best trace group to add to
- TraceTreeItemOwner *owner = find_prevalent_trace_group(
- group, signal_map);
-
- // If there is no trace group, create one
- shared_ptr new_trace_group;
- if (!owner) {
- new_trace_group.reset(new TraceGroup());
- owner = new_trace_group.get();
- }
-
- // Extract traces for the trace group, removing them from
- // the add list
- const vector< shared_ptr > new_traces_in_group =
- extract_new_traces_for_channels(group->channels(),
- signal_map, add_traces);
-
- // Add the traces to the group
- const pair prev_v_extents = owner->v_extents();
- int offset = prev_v_extents.second - prev_v_extents.first;
- for (shared_ptr trace : new_traces_in_group) {
- assert(trace);
- owner->add_child_item(trace);
-
- const pair extents = trace->v_extents();
- if (trace->enabled())
- offset += -extents.first;
- trace->force_to_v_offset(offset);
- if (trace->enabled())
- offset += extents.second;
+ if (sr_dev)
+ for (auto entry : sr_dev->channel_groups()) {
+ const shared_ptr &group = entry.second;
+
+ if (group->channels().size() <= 1)
+ continue;
+
+ // Find best trace group to add to
+ TraceTreeItemOwner *owner = find_prevalent_trace_group(
+ group, signal_map);
+
+ // If there is no trace group, create one
+ shared_ptr new_trace_group;
+ if (!owner) {
+ new_trace_group.reset(new TraceGroup());
+ owner = new_trace_group.get();
+ }
+
+ // Extract traces for the trace group, removing them from
+ // the add list
+ const vector< shared_ptr > new_traces_in_group =
+ extract_new_traces_for_channels(group->channels(),
+ signal_map, add_traces);
+
+ // Add the traces to the group
+ const pair prev_v_extents = owner->v_extents();
+ int offset = prev_v_extents.second - prev_v_extents.first;
+ for (shared_ptr trace : new_traces_in_group) {
+ assert(trace);
+ owner->add_child_item(trace);
+
+ const pair extents = trace->v_extents();
+ if (trace->enabled())
+ offset += -extents.first;
+ trace->force_to_v_offset(offset);
+ if (trace->enabled())
+ offset += extents.second;
+ }
+
+ if (new_trace_group) {
+ // Assign proper vertical offsets to each channel in the group
+ new_trace_group->restack_items();
+
+ // If this is a new group, enqueue it in the new top level
+ // items list
+ if (!new_traces_in_group.empty())
+ new_top_level_items.push_back(new_trace_group);
+ }
}
- // If this is a new group, enqueue it in the new top level
- // items list
- if (!new_traces_in_group.empty() && new_trace_group)
- new_top_level_items.push_back(new_trace_group);
- }
-
// Enqueue the remaining logic channels in a group
vector< shared_ptr > logic_channels;
copy_if(channels.begin(), channels.end(), back_inserter(logic_channels),
[](const shared_ptr& c) {
return c->type() == sigrok::ChannelType::LOGIC; });
+
const vector< shared_ptr > non_grouped_logic_signals =
- extract_new_traces_for_channels(logic_channels,
- signal_map, add_traces);
- const shared_ptr non_grouped_trace_group(
- make_shared());
- for (shared_ptr trace : non_grouped_logic_signals)
- non_grouped_trace_group->add_child_item(trace);
- new_top_level_items.push_back(non_grouped_trace_group);
+ extract_new_traces_for_channels(logic_channels, signal_map, add_traces);
+
+ if (non_grouped_logic_signals.size() > 0) {
+ const shared_ptr non_grouped_trace_group(
+ make_shared());
+ for (shared_ptr trace : non_grouped_logic_signals)
+ non_grouped_trace_group->add_child_item(trace);
+
+ non_grouped_trace_group->restack_items();
+ new_top_level_items.push_back(non_grouped_trace_group);
+ }
// Enqueue the remaining channels as free ungrouped traces
const vector< shared_ptr > new_top_level_signals =
- extract_new_traces_for_channels(channels,
- signal_map, add_traces);
+ extract_new_traces_for_channels(channels, signal_map, add_traces);
new_top_level_items.insert(new_top_level_items.end(),
new_top_level_signals.begin(), new_top_level_signals.end());
@@ -999,16 +1193,26 @@ void View::signals_changed()
owner->remove_child_item(trace);
}
+ // Remove any empty trace groups
+ for (shared_ptr group : list_by_type())
+ if (group->child_items().size() == 0) {
+ remove_child_item(group);
+ group.reset();
+ }
+
// Add and position the pending top levels items
+ int offset = v_extents().second;
for (auto item : new_top_level_items) {
add_child_item(item);
- // Position the item after the last present item
- int offset = v_extents().second;
+ // Position the item after the last item or at the top if there is none
const pair extents = item->v_extents();
+
if (item->enabled())
offset += -extents.first;
+
item->force_to_v_offset(offset);
+
if (item->enabled())
offset += extents.second;
}
@@ -1017,13 +1221,29 @@ void View::signals_changed()
header_->update();
viewport_->update();
+
+ if (reset_scrollbar)
+ set_scroll_default();
}
void View::capture_state_updated(int state)
{
- if (state == Session::Running)
+ if (state == Session::Running) {
set_time_unit(util::TimeUnit::Samples);
+ trigger_markers_.clear();
+
+ // Activate "always zoom to fit" if the setting is enabled and we're
+ // the main view of this session (other trace views may be used for
+ // zooming and we don't want to mess them up)
+ GlobalSettings settings;
+ bool state = settings.value(GlobalSettings::Key_View_AlwaysZoomToFit).toBool();
+ if (is_main_view_ && state) {
+ always_zoom_to_fit_ = true;
+ always_zoom_to_fit_changed(always_zoom_to_fit_);
+ }
+ }
+
if (state == Session::Stopped) {
// After acquisition has stopped we need to re-calculate the ticks once
// as it's otherwise done when the user pans or zooms, which is too late
@@ -1032,7 +1252,7 @@ void View::capture_state_updated(int state)
// Reset "always zoom to fit", the acquisition has stopped
if (always_zoom_to_fit_) {
always_zoom_to_fit_ = false;
- always_zoom_to_fit_changed(false);
+ always_zoom_to_fit_changed(always_zoom_to_fit_);
}
}
}
@@ -1094,5 +1314,6 @@ void View::on_hover_point_changed()
r->hover_point_changed();
}
-} // namespace view
+} // namespace TraceView
+} // namespace views
} // namespace pv