X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=pv%2Fsubwindows%2Fdecoder_selector%2Fsubwindow.cpp;h=ff2a6c8acad28856b7ee6eacdf5b9efcff3c8102;hb=e352126139ca6ba64ef8bc0a4611cdb1c58c6a1b;hp=96da710fb052ca9228214eff5a36a3772efba75f;hpb=0e2ba0cc745e763279510d943593abce52a36040;p=pulseview.git

diff --git a/pv/subwindows/decoder_selector/subwindow.cpp b/pv/subwindows/decoder_selector/subwindow.cpp
index 96da710f..ff2a6c8a 100644
--- a/pv/subwindows/decoder_selector/subwindow.cpp
+++ b/pv/subwindows/decoder_selector/subwindow.cpp
@@ -32,14 +32,22 @@
 #include "pv/session.hpp"
 #include "pv/subwindows/decoder_selector/subwindow.hpp"
 
+#include <libsigrokdecode/libsigrokdecode.h>
+
+#define DECODERS_HAVE_TAGS \
+	((SRD_PACKAGE_VERSION_MAJOR > 0) || \
+	 (SRD_PACKAGE_VERSION_MAJOR == 0) && (SRD_PACKAGE_VERSION_MINOR > 5))
+
 using std::reverse;
-using std::shared_ptr;
 
 namespace pv {
 namespace subwindows {
 namespace decoder_selector {
 
-const QString initial_notice = QApplication::tr("Select a decoder to see its description here.");
+const char *initial_notice =
+	QT_TRANSLATE_NOOP("pv::subwindows::decoder_selector::SubWindow",
+		"Select a decoder to see its description here.");  // clazy:exclude=non-pod-global-static
+
 const int min_width_margin = 75;
 
 
@@ -100,7 +108,9 @@ SubWindow::SubWindow(Session& session, QWidget* parent) :
 	filter->setClearButtonEnabled(true);
 	filter->addAction(filter_icon, QLineEdit::LeadingPosition);
 
+
 	sort_filter_model_->setSourceModel(model_);
+	sort_filter_model_->setSortCaseSensitivity(Qt::CaseInsensitive);
 	sort_filter_model_->setFilterCaseSensitivity(Qt::CaseInsensitive);
 	sort_filter_model_->setFilterKeyColumn(-1);
 
@@ -117,6 +127,11 @@ SubWindow::SubWindow(Session& session, QWidget* parent) :
 
 	tree_view_->setIndentation(10);
 
+#if (!DECODERS_HAVE_TAGS)
+	tree_view_->expandAll();
+	tree_view_->setItemsExpandable(false);
+#endif
+
 	QScrollArea* info_label_body_container = new QScrollArea();
 	info_label_body_container->setWidget(info_label_body_);
 	info_label_body_container->setWidgetResizable(true);
@@ -132,13 +147,15 @@ SubWindow::SubWindow(Session& session, QWidget* parent) :
 	info_label_header_->setTextInteractionFlags(flags);
 	info_label_body_->setWordWrap(true);
 	info_label_body_->setTextInteractionFlags(flags);
-	info_label_body_->setText(initial_notice);
+	info_label_body_->setText(QString(tr(initial_notice)));
 	info_label_body_->setAlignment(Qt::AlignTop);
 	info_label_footer_->setWordWrap(true);
 	info_label_footer_->setTextInteractionFlags(flags);
 
 	connect(filter, SIGNAL(textChanged(const QString&)),
 		this, SLOT(on_filter_changed(const QString&)));
+	connect(filter, SIGNAL(returnPressed()),
+		this, SLOT(on_filter_return_pressed()));
 
 	connect(tree_view_, SIGNAL(currentChanged(const QModelIndex&)),
 		this, SLOT(on_item_changed(const QModelIndex&)));
@@ -167,7 +184,7 @@ QToolBar* SubWindow::create_toolbar(QWidget *parent) const
 int SubWindow::minimum_width() const
 {
 	QFontMetrics m(info_label_body_->font());
-	const int label_width = m.width(initial_notice);
+	const int label_width = m.width(QString(tr(initial_notice)));
 
 	return label_width + min_width_margin;
 }
@@ -222,17 +239,21 @@ void SubWindow::on_item_changed(const QModelIndex& index)
 	const QString doc = QString::fromUtf8(srd_decoder_doc_get(d)).trimmed();
 
 	QString tags;
+#if DECODERS_HAVE_TAGS
 	for (GSList* li = (GSList*)d->tags; li; li = li->next) {
 		QString s = (li == (GSList*)d->tags) ?
 			tr((char*)li->data) :
 			QString(tr(", %1")).arg(tr((char*)li->data));
 		tags.append(s);
 	}
+#endif
 
 	info_label_header_->setText(QString("<span style='font-size:large'><b>%1 (%2)</b></span><br><i>%3</i>")
 		.arg(longname, id, desc));
 	info_label_body_->setText(doc);
-	info_label_footer_->setText(tr("<p align='right'>Tags: %1</p>").arg(tags));
+
+	if (!tags.isEmpty())
+		info_label_footer_->setText(tr("<p align='right'>Tags: %1</p>").arg(tags));
 }
 
 void SubWindow::on_item_activated(const QModelIndex& index)
@@ -311,6 +332,28 @@ void SubWindow::on_filter_changed(const QString& text)
 	tree_view_->setExpanded(tree_view_->model()->index(0, 0), !text.isEmpty());
 }
 
+void SubWindow::on_filter_return_pressed()
+{
+	int num_visible_decoders = 0;
+	QModelIndex last_valid_index;
+
+	QModelIndex index = tree_view_->model()->index(0, 0);
+
+	while (index.isValid()) {
+		QModelIndex id_index = index.model()->index(index.row(), 2, index.parent());
+		QString decoder_name = index.model()->data(id_index, Qt::DisplayRole).toString();
+		if (!decoder_name.isEmpty()) {
+			last_valid_index = index;
+			num_visible_decoders++;
+		}
+		index = tree_view_->indexBelow(index);
+	}
+
+	// If only one decoder matches the filter, apply it when the user presses enter
+	if (num_visible_decoders == 1)
+		tree_view_->activated(last_valid_index);
+}
+
 } // namespace decoder_selector
 } // namespace subwindows
 } // namespace pv