Uwe Hermann [Sat, 23 Nov 2019 18:38:46 +0000 (19:38 +0100)]
views/trace: Fix two -fsanitize=undefined issues.
Two variables were being accessed before initialization in some cases.
pv/views/trace/view.cpp:1199:6: runtime error: load of value 124, which is not a valid value for type 'bool'
pv/views/trace/view.cpp:1199:6: runtime error: load of value 105, which is not a valid value for type 'bool'
pv/views/trace/cursorpair.cpp:252:7: runtime error: load of value 24, which is not a valid value for type 'bool'
pv/views/trace/cursorpair.cpp:252:7: runtime error: load of value 200, which is not a valid value for type 'bool'
Soeren Apel [Wed, 6 Nov 2019 21:43:51 +0000 (22:43 +0100)]
Fix #1107 by implementing a copy-to-clipboard menu entry
In the process, it turned out that the sample range for
cursor position-based menu commands was wrong: it didn't
take the width of the viewport header into account. This
is now fixed as well.
Uwe Hermann [Thu, 8 Aug 2019 19:46:25 +0000 (21:46 +0200)]
org.sigrok.PulseView.appdata.xml: Fix a few warnings.
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:20
Consider using a secure (HTTPS) URL for 'http://sigrok.org/wiki/FAQ'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:19
Consider using a secure (HTTPS) URL for
'http://sigrok.org/bugzilla/enter_bug.cgi?format=guided&product=PulseView'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:18
Consider using a secure (HTTPS) URL for 'http://sigrok.org/wiki/PulseView'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:23
Consider using a secure (HTTPS) URL for
'http://sigrok.org/wimg/e/ee/PulseView_I2C_DS1307_Decode.png'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:10
First 'description/p' paragraph might be too short (< 80 characters).
Uwe Hermann [Fri, 5 Jul 2019 20:58:08 +0000 (22:58 +0200)]
Connect dialog: Fix scan for certain USB devices.
Before the fix, selecting "USB" (it's selected by default) in the
"Connect to device" dialog would incorrectly set a conn parameter to
some serial or HID devices, even for scans for pure USB devices which are
neither of those.
jaseg [Mon, 10 Jun 2019 03:56:32 +0000 (12:56 +0900)]
Show relative time of flags on hover
With this change, when the mouse hovers over any flag or cursor, the
flags change labels to show their time relative to the item being
hovered over. When hovering over the interval label of a cursor pair,
the relative time to the nearest end of the interval is shown. While
pressing shift, the regular labels are shown again.
jaseg [Sun, 9 Jun 2019 10:35:20 +0000 (19:35 +0900)]
Make cursor pair drop precision when too small
Currently, often the label just displays "...". With this change, it
will gracefully drop precision and less important parts (frequency,
unit) when there's not enough space to print the full string. The full
string is still available in the tooltip appearing on hover.
Uwe Hermann [Sun, 30 Jun 2019 18:04:00 +0000 (20:04 +0200)]
decoder_selector: Fix an issue with PD auto-stacking.
Before the fix, PDs with common prefix would incorrectly be found as
a match. Example: Both "spi" and "spiflash" would be considered valid
candidates when looking for PDs which emit "spi" OUTPUT_PYTHON output.
Uwe Hermann [Thu, 14 Mar 2019 20:22:47 +0000 (21:22 +0100)]
DecoderSelector: Fix catching polymorphic types by value.
[...]/pv/subwindows/decoder_selector/item.cpp: In member function ‘std::shared_ptr<pv::subwindows::decoder_selector::DecoderCollectionItem> pv::subwindows::decoder_selector::DecoderCollectionItem::subItem(int) const’:
[...]/pv/subwindows/decoder_selector/item.cpp:44:11: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
} catch (out_of_range) {
^~~~~~~~~~~~
[...]/pv/subwindows/decoder_selector/item.cpp: In member function ‘QVariant pv::subwindows::decoder_selector::DecoderCollectionItem::data(int) const’:
[...]/pv/subwindows/decoder_selector/item.cpp:88:11: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
} catch (out_of_range) {
^~~~~~~~~~~~
Soeren Apel [Wed, 20 Feb 2019 08:40:42 +0000 (09:40 +0100)]
Fix #1338 ("show time zero at the trigger" option)
Before, successive runs were shifting the zero point for no valid reason
and markers created on the ruler/trace used the wrong time and thus
showed up at the wrong location.
Gerhard Sittig [Thu, 10 Jan 2019 19:30:24 +0000 (20:30 +0100)]
CMakeLists.txt: create NSIS file in binary directory not source
The sigrok-util scripts (mingw and msys2) expect the pulseview_cross.nsi
file in the build directory, and it's good tradition to not write into
the source directory during build. Adjust the configure_file() call.