Uwe Hermann [Sat, 23 Nov 2019 18:38:46 +0000 (19:38 +0100)]
views/trace: Fix two -fsanitize=undefined issues.
Two variables were being accessed before initialization in some cases.
pv/views/trace/view.cpp:1199:6: runtime error: load of value 124, which is not a valid value for type 'bool'
pv/views/trace/view.cpp:1199:6: runtime error: load of value 105, which is not a valid value for type 'bool'
pv/views/trace/cursorpair.cpp:252:7: runtime error: load of value 24, which is not a valid value for type 'bool'
pv/views/trace/cursorpair.cpp:252:7: runtime error: load of value 200, which is not a valid value for type 'bool'
Soeren Apel [Sat, 9 Nov 2019 22:16:49 +0000 (23:16 +0100)]
Fix typo
Soeren Apel [Sat, 9 Nov 2019 20:47:13 +0000 (21:47 +0100)]
DecodeTrace: Add fallback icon for edit-paste action
Soeren Apel [Fri, 8 Nov 2019 09:07:14 +0000 (10:07 +0100)]
Fix compiler warnings
Miklos Marton [Wed, 10 Jul 2019 07:55:47 +0000 (09:55 +0200)]
Add temporary snapping disable menu to markers and cursors
Add context menu to the cursors and time markers for temporary disabling
the snapping to digital edges of the markers.
Uwe Hermann [Thu, 7 Nov 2019 22:48:01 +0000 (23:48 +0100)]
Connect dialog: Fix an issue where serial ports can't be selected
Without this fix, clicking the "Serial Port" radio button would not
enable the serial port dropdown (it would remain grayed out).
Soeren Apel [Thu, 7 Nov 2019 21:53:00 +0000 (22:53 +0100)]
Fix #1107 more by copying also to the mouse selection buffer on X11
Soeren Apel [Thu, 7 Nov 2019 21:49:11 +0000 (22:49 +0100)]
Fix #1412 more by allowing the PD stack menu to be scrolled
Soeren Apel [Thu, 7 Nov 2019 21:40:07 +0000 (22:40 +0100)]
Fix #977 by introducing a setting for always showing all rows
Soeren Apel [Wed, 6 Nov 2019 21:43:51 +0000 (22:43 +0100)]
Fix #1107 by implementing a copy-to-clipboard menu entry
In the process, it turned out that the sample range for
cursor position-based menu commands was wrong: it didn't
take the width of the viewport header into account. This
is now fixed as well.
Soeren Apel [Wed, 6 Nov 2019 20:16:01 +0000 (21:16 +0100)]
Fix #1362 by also saving decoder visibility
Soeren Apel [Wed, 6 Nov 2019 19:43:56 +0000 (20:43 +0100)]
Fix #1412 by only showing suitable PDs, not all of them
Soeren Apel [Tue, 5 Nov 2019 21:25:50 +0000 (22:25 +0100)]
Fix #1400 by matching decoder selectors only for current session
Uwe Hermann [Thu, 3 Oct 2019 18:58:11 +0000 (20:58 +0200)]
CMakeLists.txt: Show detected Qt version.
Uwe Hermann [Sat, 7 Sep 2019 17:25:36 +0000 (19:25 +0200)]
Bump required Qt version to >= 5.3.
This is necessary since we now use QSignalBlocker, which was introduced
in Qt 5.3.
Soeren Apel [Tue, 13 Aug 2019 07:18:46 +0000 (09:18 +0200)]
Trace: Use scroll bars for popups with too much content
This fixes bug #183.
Uwe Hermann [Thu, 8 Aug 2019 19:46:25 +0000 (21:46 +0200)]
org.sigrok.PulseView.appdata.xml: Fix a few warnings.
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:20
Consider using a secure (HTTPS) URL for 'http://sigrok.org/wiki/FAQ'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:19
Consider using a secure (HTTPS) URL for
'http://sigrok.org/bugzilla/enter_bug.cgi?format=guided&product=PulseView'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:18
Consider using a secure (HTTPS) URL for 'http://sigrok.org/wiki/PulseView'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:23
Consider using a secure (HTTPS) URL for
'http://sigrok.org/wimg/e/ee/PulseView_I2C_DS1307_Decode.png'
I - org.sigrok.PulseView.appdata.xml:org.sigrok.PulseView.desktop:10
First 'description/p' paragraph might be too short (< 80 characters).
Miklos Marton [Fri, 2 Aug 2019 11:46:20 +0000 (13:46 +0200)]
Extend .gitignore
Uwe Hermann [Wed, 31 Jul 2019 20:46:12 +0000 (22:46 +0200)]
manpage: Update keyboard shortcuts.
Joe FitzPatrick [Wed, 24 Jul 2019 14:53:24 +0000 (07:53 -0700)]
adding up/down to zoom in/out for quick navigation
Miklos Marton [Wed, 10 Jul 2019 14:15:33 +0000 (16:15 +0200)]
Add home and end shortcuts
Uwe Hermann [Sat, 6 Jul 2019 13:58:20 +0000 (15:58 +0200)]
cursors: Fix mouse cursor shape to be horizontal arrows.
Miklos Marton [Mon, 20 May 2019 09:27:37 +0000 (11:27 +0200)]
Add shortcuts to + and - buttons for zooming in and out horizontally
Uwe Hermann [Fri, 5 Jul 2019 20:58:08 +0000 (22:58 +0200)]
Connect dialog: Fix scan for certain USB devices.
Before the fix, selecting "USB" (it's selected by default) in the
"Connect to device" dialog would incorrectly set a conn parameter to
some serial or HID devices, even for scans for pure USB devices which are
neither of those.
This fixes bug #1403.
Soeren Apel [Wed, 3 Jul 2019 07:45:09 +0000 (09:45 +0200)]
Don't return valid time() for the cursor pair
Soeren Apel [Sun, 30 Jun 2019 11:29:10 +0000 (13:29 +0200)]
Style and architecture fixes
jaseg [Mon, 10 Jun 2019 03:56:32 +0000 (12:56 +0900)]
Show relative time of flags on hover
With this change, when the mouse hovers over any flag or cursor, the
flags change labels to show their time relative to the item being
hovered over. When hovering over the interval label of a cursor pair,
the relative time to the nearest end of the interval is shown. While
pressing shift, the regular labels are shown again.
jaseg [Sun, 9 Jun 2019 11:53:05 +0000 (20:53 +0900)]
Accept new position on enter press in cursor popups
jaseg [Sun, 9 Jun 2019 11:52:35 +0000 (20:52 +0900)]
Fix ruler double-click to add cursor in right position
Soeren Apel [Wed, 26 Jun 2019 20:20:25 +0000 (22:20 +0200)]
Trace View: Move ruler time conversion from View to Ruler
jaseg [Sun, 9 Jun 2019 11:07:55 +0000 (20:07 +0900)]
Show ruler timestamps in cursors and popups
Prior to this absolute timestamps would be shown, even with the zero
point set somewhere else.
Soeren Apel [Fri, 21 Jun 2019 20:53:17 +0000 (22:53 +0200)]
Fixes
jaseg [Sun, 9 Jun 2019 10:35:20 +0000 (19:35 +0900)]
Make cursor pair drop precision when too small
Currently, often the label just displays "...". With this change, it
will gracefully drop precision and less important parts (frequency,
unit) when there's not enough space to print the full string. The full
string is still available in the tooltip appearing on hover.
Soeren Apel [Thu, 20 Jun 2019 18:03:02 +0000 (20:03 +0200)]
Fixes
jaseg [Sat, 8 Jun 2019 02:19:48 +0000 (11:19 +0900)]
Trace view: Allow setting cursors via shift-drag
Uwe Hermann [Sun, 30 Jun 2019 21:04:00 +0000 (23:04 +0200)]
decoder_selector: Apply decoder upon pressing enter.
If only one decoder matches the filter, apply it when the user presses enter.
Uwe Hermann [Sun, 30 Jun 2019 18:04:00 +0000 (20:04 +0200)]
decoder_selector: Fix an issue with PD auto-stacking.
Before the fix, PDs with common prefix would incorrectly be found as
a match. Example: Both "spi" and "spiflash" would be considered valid
candidates when looking for PDs which emit "spi" OUTPUT_PYTHON output.
Uwe Hermann [Sat, 29 Jun 2019 20:58:13 +0000 (22:58 +0200)]
decoder_selector: Expand "All Decoders" if the user filtered
Uwe Hermann [Sat, 29 Jun 2019 18:59:32 +0000 (20:59 +0200)]
decoder_selector: Auto-place the keyboard cursor in the filter.
Tilman Sauerbeck [Sat, 4 May 2019 19:14:24 +0000 (21:14 +0200)]
Session: Use a monotonic clock to measure acquisition time.
Tilman Sauerbeck [Sat, 4 May 2019 19:11:08 +0000 (21:11 +0200)]
Session: Print duration of last acquisition only.
This resets the timer at the start of a new acquisition.
Soeren Apel [Mon, 22 Apr 2019 13:39:13 +0000 (15:39 +0200)]
Style fixes
Devan Lai [Fri, 19 Apr 2019 05:15:19 +0000 (22:15 -0700)]
Remove redundant isNull() check - isEmpty is a superset of isNull
Devan Lai [Fri, 19 Apr 2019 04:38:15 +0000 (21:38 -0700)]
Add -s / --settings parameter to load a session setup file
Soeren Apel [Sun, 21 Apr 2019 06:44:10 +0000 (08:44 +0200)]
Fix #1375 by searching across all model columns
This way, a search for "i2c" includes the ID field, not just the name.
Soeren Apel [Thu, 18 Apr 2019 21:02:31 +0000 (23:02 +0200)]
Session: Measure acquisition time
Soeren Apel [Mon, 25 Mar 2019 17:03:02 +0000 (18:03 +0100)]
Merge RowItem() into ViewItem()
Ryan Govostes [Mon, 25 Mar 2019 16:50:25 +0000 (17:50 +0100)]
Use multiple drawLine() calls instead of drawPolyline()
Soeren Apel [Wed, 20 Mar 2019 08:43:01 +0000 (09:43 +0100)]
Fix variable naming
Ryan Govostes [Tue, 19 Mar 2019 23:30:24 +0000 (19:30 -0400)]
Disable antialiasing on high-DPI displays
Uwe Hermann [Thu, 21 Mar 2019 22:28:26 +0000 (23:28 +0100)]
DecoderSelector: Set alignment=top for the PD info text.
Soeren Apel [Tue, 19 Mar 2019 20:27:08 +0000 (21:27 +0100)]
DecoderSelector: Make window as wide as necessary when opening
Soeren Apel [Tue, 19 Mar 2019 09:14:12 +0000 (10:14 +0100)]
DecoderSelector: Put body label into a QScrollArea
Uwe Hermann [Sat, 16 Mar 2019 18:50:03 +0000 (19:50 +0100)]
INSTALL: Bump libsigrokdecode requirement to >= 0.6.0.
We now depend on the decoder tags feature introduced in the
libsigrokdecode 0.6.x series.
Uwe Hermann [Thu, 14 Mar 2019 21:25:29 +0000 (22:25 +0100)]
DecoderSelector: Make first line of PD info italic too.
Uwe Hermann [Thu, 14 Mar 2019 20:49:39 +0000 (21:49 +0100)]
DecoderSelector: Avoid non-standard variable type.
Uwe Hermann [Thu, 14 Mar 2019 20:48:07 +0000 (21:48 +0100)]
DecoderSelector: Reduce indentation from 20 to 10.
This wastes a little less screen space.
Uwe Hermann [Thu, 14 Mar 2019 20:42:42 +0000 (21:42 +0100)]
DecoderSelector: Make decoder tag names fully visible
Uwe Hermann [Thu, 14 Mar 2019 20:40:52 +0000 (21:40 +0100)]
DecoderSelector: Set alignment=top for the PD info text.
This looks nicer if the text area is resized to be larger than the
PD info text itself.
Uwe Hermann [Thu, 14 Mar 2019 20:33:36 +0000 (21:33 +0100)]
DecoderSelector: Make PD info text selectable.
This allows for e.g. highlighting and copy-pasting.
Uwe Hermann [Thu, 14 Mar 2019 20:27:30 +0000 (21:27 +0100)]
DecoderSelector: Allow word-wrap for PD header/footer as well.
Without this, resizing would be unnecessarily limited by the header/footer
length in some cases.
Uwe Hermann [Thu, 14 Mar 2019 20:22:47 +0000 (21:22 +0100)]
DecoderSelector: Fix catching polymorphic types by value.
[...]/pv/subwindows/decoder_selector/item.cpp: In member function ‘std::shared_ptr<pv::subwindows::decoder_selector::DecoderCollectionItem> pv::subwindows::decoder_selector::DecoderCollectionItem::subItem(int) const’:
[...]/pv/subwindows/decoder_selector/item.cpp:44:11: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
} catch (out_of_range) {
^~~~~~~~~~~~
[...]/pv/subwindows/decoder_selector/item.cpp: In member function ‘QVariant pv::subwindows::decoder_selector::DecoderCollectionItem::data(int) const’:
[...]/pv/subwindows/decoder_selector/item.cpp:88:11: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
} catch (out_of_range) {
^~~~~~~~~~~~
Soeren Apel [Thu, 14 Mar 2019 21:45:03 +0000 (22:45 +0100)]
Fix build without decoders enabled
Soeren Apel [Thu, 14 Mar 2019 18:50:24 +0000 (19:50 +0100)]
DecoderSelector: Use srd_decoder_get_by_id()
Soeren Apel [Thu, 14 Mar 2019 18:47:02 +0000 (19:47 +0100)]
DecoderSelector: Make PD names italic
Soeren Apel [Thu, 14 Mar 2019 11:31:16 +0000 (12:31 +0100)]
DecoderSelector: Properly name utility methods
Soeren Apel [Thu, 14 Mar 2019 11:24:04 +0000 (12:24 +0100)]
DecoderSelector: Rework GSList usage to remove unnecessary list copying
Soeren Apel [Thu, 14 Mar 2019 11:08:44 +0000 (12:08 +0100)]
Manual: Add session save/restore, PD selector dialog
Soeren Apel [Mon, 11 Mar 2019 16:55:44 +0000 (17:55 +0100)]
ViewBase: Add missing constructor call
Soeren Apel [Sun, 10 Mar 2019 19:11:48 +0000 (20:11 +0100)]
DecoderSelector: Implement filtering
Soeren Apel [Sun, 10 Mar 2019 10:39:32 +0000 (11:39 +0100)]
DecoderSelector: Use proxy model to permit sorting
Soeren Apel [Sun, 10 Mar 2019 10:23:04 +0000 (11:23 +0100)]
DecodeSelector: Use custom treeview to hook into selection changes
Soeren Apel [Sun, 10 Mar 2019 10:07:33 +0000 (11:07 +0100)]
Fix #1309 by adding a PD info box
Soeren Apel [Sun, 10 Mar 2019 09:43:22 +0000 (10:43 +0100)]
DecodeSignal: Use name of last stacked PD unless the name was changed
Soeren Apel [Sat, 9 Mar 2019 15:29:10 +0000 (16:29 +0100)]
Fix #1147 by implementing decoder selector subwindow
chrysn [Thu, 29 Nov 2018 12:36:27 +0000 (13:36 +0100)]
views: Increase precision on analog views
Closes #1335.
Soeren Apel [Sun, 24 Feb 2019 14:20:24 +0000 (15:20 +0100)]
Auto-load session setups if they exist and auto-save them if desired
Soeren Apel [Sat, 23 Feb 2019 13:33:22 +0000 (14:33 +0100)]
Fix #971: Allow saving/restoring of session setups
Soeren Apel [Wed, 20 Feb 2019 08:40:42 +0000 (09:40 +0100)]
Fix #1338 ("show time zero at the trigger" option)
Before, successive runs were shifting the zero point for no valid reason
and markers created on the ruler/trace used the wrong time and thus
showed up at the wrong location.
Gerhard Sittig [Thu, 10 Jan 2019 19:30:24 +0000 (20:30 +0100)]
CMakeLists.txt: create NSIS file in binary directory not source
The sigrok-util scripts (mingw and msys2) expect the pulseview_cross.nsi
file in the build directory, and it's good tradition to not write into
the source directory during build. Adjust the configure_file() call.
Bartosz Golaszewski [Mon, 3 Dec 2018 14:35:35 +0000 (15:35 +0100)]
mainbar: fix build without libsigrokdecode
We must not include decodesignal.hpp if we're not using libsigrokdecode
or the build will fail due to libsigrokdecode.hpp not being present in
the system.
Signed-off-by: Bartosz Golaszewski <redacted>
Soeren Apel [Sat, 29 Dec 2018 21:58:57 +0000 (22:58 +0100)]
Session: Enable logic data acquisition using gstreamer
For now, reading data from /tmp/dummy_binary
Uwe Hermann [Thu, 10 Jan 2019 01:32:51 +0000 (02:32 +0100)]
CMakeLists.txt: Set ENABLE_FLOW to FALSE by default.
Uwe Hermann [Thu, 10 Jan 2019 01:27:09 +0000 (02:27 +0100)]
flow: Call Srf::init() early in main().
Uwe Hermann [Thu, 10 Jan 2019 01:26:18 +0000 (02:26 +0100)]
Rename ENABLE_GSTREAMERMM to ENABLE_FLOW.
Uwe Hermann [Sat, 29 Dec 2018 17:21:19 +0000 (18:21 +0100)]
Add libsigrokflow build system integration.
Uwe Hermann [Fri, 28 Dec 2018 18:14:16 +0000 (19:14 +0100)]
Add ENABLE_GSTREAMERMM, make gstreamermm support optional.
Uwe Hermann [Fri, 28 Dec 2018 18:10:41 +0000 (19:10 +0100)]
Add new dependency: libgstreamermm >= 1.8.0.
Also, initialize gstreamermm in main().
Soeren Apel [Sat, 29 Dec 2018 09:32:56 +0000 (10:32 +0100)]
Connect dialog: add baud rate combobox for serial ports
Soeren Apel [Thu, 27 Dec 2018 20:22:15 +0000 (21:22 +0100)]
Don't use QMessageBox::setInformativeText()
When using it, the extended error message text is not reliably appended
to the dialog text.
Soeren Apel [Thu, 27 Dec 2018 20:17:48 +0000 (21:17 +0100)]
Abort acquisition if there are more than 64 logic channels
Uwe Hermann [Wed, 5 Dec 2018 21:23:47 +0000 (22:23 +0100)]
logicsegment.cpp: Minor whitespace fix.
Alexandru Gagniuc [Wed, 28 Nov 2018 20:36:37 +0000 (14:36 -0600)]
cmake: Don't do a QUIET search for libsigrokcxx
libsigrokcxx is the most important dependency. A QUIET search means we
can miss important information, such as a version mismatch, and the
"libsigrokcxx not found" message is not at all helpful in determining
the cause of the problem.
Uwe Hermann [Mon, 29 Oct 2018 10:26:51 +0000 (11:26 +0100)]
manual: Bump date.
Uwe Hermann [Mon, 29 Oct 2018 09:10:34 +0000 (10:10 +0100)]
INSTALL: Mention both asciidoctor and asciidoctor-pdf.
Uwe Hermann [Mon, 29 Oct 2018 09:03:35 +0000 (10:03 +0100)]
Use more specific libsigrokcxx/libsigrokdecode minimum versions.
We require libsigrokcxx >= 0.5.1 e.g. due to Analog::get_logic_via_threshold(),
and libsigrokdecode >= 0.5.2 due to e.g. srd_log_callback_get().
Soeren Apel [Sun, 28 Oct 2018 22:26:25 +0000 (23:26 +0100)]
Ruler: Fix context menu for items on the ruler
Soeren Apel [Sun, 28 Oct 2018 22:11:52 +0000 (23:11 +0100)]
Installer: Add links to manual
Uwe Hermann [Sun, 28 Oct 2018 21:46:30 +0000 (22:46 +0100)]
INSTALL: Mention optional libboost-stacktrace.
Gerhard Sittig [Sun, 28 Oct 2018 21:15:49 +0000 (22:15 +0100)]
manual: allow manual conversion without source builds
Add a cmake_minimum_required() directive to the manual/ subdir's CMake
rules, such that the documentation can get built without involving the
application and its build dependencies.