]> sigrok.org Git - sigrok-cli.git/log
sigrok-cli.git
10 years agoAdapt to config key capabilities.
Bert Vermeulen [Wed, 17 Sep 2014 14:03:45 +0000 (16:03 +0200)]
Adapt to config key capabilities.

10 years agoReplace ann_format with ann_class.
Uwe Hermann [Mon, 15 Sep 2014 18:26:08 +0000 (20:26 +0200)]
Replace ann_format with ann_class.

The naming has been changed to "annotation class" a while ago.

10 years agoAlways save all channels to a session file.
Bert Vermeulen [Sat, 13 Sep 2014 13:17:49 +0000 (15:17 +0200)]
Always save all channels to a session file.

This works around limitations of the current API that screw up saving
only enabled channels. See bug 410.

10 years agoAdd --get option.
Bert Vermeulen [Wed, 10 Sep 2014 15:57:01 +0000 (17:57 +0200)]
Add --get option.

10 years agoFail on invalid channel group.
Bert Vermeulen [Tue, 9 Sep 2014 17:54:36 +0000 (19:54 +0200)]
Fail on invalid channel group.

10 years agoAdd missing --show pretty-printers.
Bert Vermeulen [Sun, 7 Sep 2014 12:58:16 +0000 (14:58 +0200)]
Add missing --show pretty-printers.

10 years agoSupport uint64 input/output module options.
Bert Vermeulen [Sat, 30 Aug 2014 18:17:34 +0000 (20:17 +0200)]
Support uint64 input/output module options.

10 years agoFix session file loading.
Bert Vermeulen [Fri, 29 Aug 2014 21:02:19 +0000 (23:02 +0200)]
Fix session file loading.

10 years agoUse sr_input_scan_*() API changes.
Bert Vermeulen [Wed, 27 Aug 2014 23:50:49 +0000 (01:50 +0200)]
Use sr_input_scan_*() API changes.

10 years agoAlways consider input from stdin as a non-session format.
Bert Vermeulen [Wed, 27 Aug 2014 22:17:05 +0000 (00:17 +0200)]
Always consider input from stdin as a non-session format.

10 years agoAllow input from stdin by specifying "-i -".
Bert Vermeulen [Tue, 19 Aug 2014 23:15:36 +0000 (01:15 +0200)]
Allow input from stdin by specifying "-i -".

10 years agoUse new input API.
Bert Vermeulen [Sun, 10 Aug 2014 14:58:36 +0000 (16:58 +0200)]
Use new input API.

10 years agoTrigger match on any edge is e, not c.
Peter Zotov [Sun, 24 Aug 2014 09:24:02 +0000 (13:24 +0400)]
Trigger match on any edge is e, not c.

10 years agoIf only one non-demo device is present, select it.
Peter Zotov [Sat, 23 Aug 2014 09:02:50 +0000 (13:02 +0400)]
If only one non-demo device is present, select it.

10 years agoFix generic sr_option enumeration.
Bert Vermeulen [Wed, 20 Aug 2014 15:31:17 +0000 (17:31 +0200)]
Fix generic sr_option enumeration.

10 years agoFix output module enumeration + code cleanup.
Bert Vermeulen [Mon, 18 Aug 2014 21:59:23 +0000 (23:59 +0200)]
Fix output module enumeration + code cleanup.

10 years agoEnumerate output module options according to API change.
Bert Vermeulen [Fri, 15 Aug 2014 20:32:17 +0000 (22:32 +0200)]
Enumerate output module options according to API change.

10 years agoBetter output module checking.
Bert Vermeulen [Sat, 2 Aug 2014 23:19:55 +0000 (01:19 +0200)]
Better output module checking.

10 years agoHandle floating point options for output modules.
Bert Vermeulen [Sat, 2 Aug 2014 01:43:53 +0000 (03:43 +0200)]
Handle floating point options for output modules.

10 years agoShow PD annotation row members by name, not number.
Bert Vermeulen [Fri, 1 Aug 2014 14:04:08 +0000 (16:04 +0200)]
Show PD annotation row members by name, not number.

This fixes bug 388.

10 years agoRemove stray debug output.
Bert Vermeulen [Sun, 27 Jul 2014 21:33:37 +0000 (23:33 +0200)]
Remove stray debug output.

10 years agoUse finished output API.
Bert Vermeulen [Fri, 25 Jul 2014 20:39:48 +0000 (22:39 +0200)]
Use finished output API.

10 years agoFree results of device scan as soon as possible.
Bert Vermeulen [Thu, 24 Jul 2014 18:31:55 +0000 (20:31 +0200)]
Free results of device scan as soon as possible.

10 years agoAdd analog output module to default output.
Bert Vermeulen [Thu, 24 Jul 2014 02:28:26 +0000 (04:28 +0200)]
Add analog output module to default output.

The default output module is bits, which only handles logic data.
When a user queries a device which outputs analog data, this results
in no output at all, which often confuses new users.

10 years agoProperly handle saving logic data packets of any size.
Bert Vermeulen [Wed, 23 Jul 2014 17:21:54 +0000 (19:21 +0200)]
Properly handle saving logic data packets of any size.

10 years agoDrop references to obsolete sigrok-commits mailing list.
Uwe Hermann [Tue, 22 Jul 2014 22:02:30 +0000 (00:02 +0200)]
Drop references to obsolete sigrok-commits mailing list.

10 years agoUse new session API.
Bert Vermeulen [Thu, 17 Jul 2014 20:49:20 +0000 (22:49 +0200)]
Use new session API.

10 years agooptions: Make sure there are no extra arguments.
Jens Steinhauser [Tue, 15 Jul 2014 21:40:20 +0000 (23:40 +0200)]
options: Make sure there are no extra arguments.

10 years agooptions: Allow input/output file names only once.
Jens Steinhauser [Tue, 15 Jul 2014 21:31:34 +0000 (23:31 +0200)]
options: Allow input/output file names only once.

10 years agooptions: String options are only allowed once.
Jens Steinhauser [Tue, 15 Jul 2014 20:52:35 +0000 (22:52 +0200)]
options: String options are only allowed once.

10 years agoRemove unnecessary extern option variable declarations.
Jens Steinhauser [Tue, 15 Jul 2014 15:19:55 +0000 (17:19 +0200)]
Remove unnecessary extern option variable declarations.

10 years agoPut option parsing into a separate file.
Jens Steinhauser [Tue, 15 Jul 2014 15:14:03 +0000 (17:14 +0200)]
Put option parsing into a separate file.

10 years agoAdd some missing headers.
Bert Vermeulen [Wed, 9 Jul 2014 23:53:17 +0000 (01:53 +0200)]
Add some missing headers.

10 years agomanpage: Document -M and -B options.
Bert Vermeulen [Sun, 10 Nov 2013 13:00:32 +0000 (14:00 +0100)]
manpage: Document -M and -B options.

10 years agoCheck srd_decoder_get_by_id() output.
Bert Vermeulen [Fri, 20 Jun 2014 15:01:48 +0000 (17:01 +0200)]
Check srd_decoder_get_by_id() output.

This fixes bug 370. Thanks to Sander Alberink for the bug report
and patch.

10 years agofix a potential use of uninitialized variable
Aurelien Jacobs [Tue, 3 Jun 2014 14:46:03 +0000 (16:46 +0200)]
fix a potential use of uninitialized variable

show.c: In function ‘show_dev_detail’:
show.c:214:11: warning: ‘c’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  char *s, c;
           ^

10 years agoUse sr_trigger_stage_add().
Bert Vermeulen [Sat, 31 May 2014 08:36:15 +0000 (10:36 +0200)]
Use sr_trigger_stage_add().

10 years agoUse new trigger API.
Bert Vermeulen [Sun, 25 May 2014 22:58:42 +0000 (00:58 +0200)]
Use new trigger API.

10 years agosigrok-cli: AC_ARG_WITH uses withval, not enableval
Cody P Schafer [Wed, 7 May 2014 04:18:38 +0000 (21:18 -0700)]
sigrok-cli: AC_ARG_WITH uses withval, not enableval

Signed-off-by: Cody P Schafer <redacted>
10 years agoconfigure.ac: Bump package version to 0.5.0. sigrok-cli-0.5.x sigrok-cli-0.5.0
Uwe Hermann [Tue, 6 May 2014 21:19:15 +0000 (23:19 +0200)]
configure.ac: Bump package version to 0.5.0.

10 years agoBump libsigrok/libsigrokdecode dependencies to 0.3.0 each.
Uwe Hermann [Tue, 6 May 2014 21:17:43 +0000 (23:17 +0200)]
Bump libsigrok/libsigrokdecode dependencies to 0.3.0 each.

10 years agoNEWS: Add list of user-visible changes so far.
Uwe Hermann [Tue, 6 May 2014 07:00:00 +0000 (09:00 +0200)]
NEWS: Add list of user-visible changes so far.

10 years agoAdapt to SR_T_CHAR -> SR_T_STRING rename.
Uwe Hermann [Tue, 6 May 2014 18:20:04 +0000 (20:20 +0200)]
Adapt to SR_T_CHAR -> SR_T_STRING rename.

10 years agomanpage: Document the --frames option.
Uwe Hermann [Sun, 4 May 2014 23:54:48 +0000 (01:54 +0200)]
manpage: Document the --frames option.

10 years agoUpdate the manpage.
Uwe Hermann [Sun, 4 May 2014 21:14:25 +0000 (23:14 +0200)]
Update the manpage.

 - Don't refer to the not yet existing nexus-osciprime driver.

 - Update an example sigrok-cli --scan output to match the current format.

 - Update some sections to honor that channels are now specified by
   name (not number). Example: "-P uart:rx=FTDIRX" instead of "-P uart:rx=6"
   (if channel 6 has been actually named "FTDIRX" by the user/frontend).

   This fixes bug #332.

 - SPI PD: The 'sck' pin is now called 'clk', update the manpage example.

 - Fix a typo in the -S documentation: s/-A/-P/.

 - The --time option currently only supports "ms" and "s" as units.

 - Various minor cosmetic changes.

10 years agoUse a non-recursive automake setup.
Uwe Hermann [Sun, 4 May 2014 14:49:01 +0000 (16:49 +0200)]
Use a non-recursive automake setup.

(fewer files, less clutter)

10 years agoFix compile without decoding support.
Bert Vermeulen [Sat, 26 Apr 2014 19:11:16 +0000 (12:11 -0700)]
Fix compile without decoding support.

This fixes bug 351.

10 years agosession: Show unitsize of the received data.
Uwe Hermann [Fri, 25 Apr 2014 17:32:01 +0000 (19:32 +0200)]
session: Show unitsize of the received data.

Also, minor consistency fixes.

10 years agoFix saving to session file.
Bert Vermeulen [Thu, 24 Apr 2014 18:58:35 +0000 (20:58 +0200)]
Fix saving to session file.

10 years agoDon't output anything else when decoding.
Bert Vermeulen [Tue, 22 Apr 2014 21:37:14 +0000 (23:37 +0200)]
Don't output anything else when decoding.

10 years agoUse new output module API wrappers.
Bert Vermeulen [Sun, 20 Apr 2014 21:13:16 +0000 (23:13 +0200)]
Use new output module API wrappers.

10 years agoDrop obsolete output API support.
Bert Vermeulen [Sat, 19 Apr 2014 13:34:14 +0000 (15:34 +0200)]
Drop obsolete output API support.

10 years agoRename 'probe' to 'channel' (libsigrokdecode change).
Uwe Hermann [Sat, 12 Apr 2014 11:42:30 +0000 (13:42 +0200)]
Rename 'probe' to 'channel' (libsigrokdecode change).

The -p|--probes option is renamed to -C|--channels.

Variables of type 'struct srd_channel *' are consistently named 'pdch' to
make them easily distinguishable from libsigrok's 'struct sr_channel *'
variables that are consistently named 'ch'.

10 years agoAlways get samplerate at the start of acquisition.
Bert Vermeulen [Sun, 13 Apr 2014 18:51:59 +0000 (20:51 +0200)]
Always get samplerate at the start of acquisition.

10 years agoDeal with empty sessions nicely.
Bert Vermeulen [Mon, 7 Apr 2014 13:26:39 +0000 (15:26 +0200)]
Deal with empty sessions nicely.

10 years agoconfigure.ac: Clearly mark required and optional libs.
Uwe Hermann [Sun, 13 Apr 2014 16:17:04 +0000 (18:17 +0200)]
configure.ac: Clearly mark required and optional libs.

10 years agonsis: Drop embedded Python installer, ship local DLL and modules.
Uwe Hermann [Fri, 4 Apr 2014 17:57:23 +0000 (19:57 +0200)]
nsis: Drop embedded Python installer, ship local DLL and modules.

10 years agoRename 'probe' to 'channel' in most places.
Uwe Hermann [Mon, 24 Mar 2014 21:32:47 +0000 (22:32 +0100)]
Rename 'probe' to 'channel' in most places.

This is an update related to bug #259.

10 years agoRename 'probe group' to 'channel group' everywhere.
Uwe Hermann [Fri, 14 Mar 2014 20:46:10 +0000 (21:46 +0100)]
Rename 'probe group' to 'channel group' everywhere.

This is required to adapt to the same rename in libsigrok.

The --probe-group command-line option is now called --channel-group
(however, the short version -g remains the same as it means "group").

This is an update related to bug #259.

10 years agoAdd support for setting double ranges.
Bert Vermeulen [Thu, 20 Mar 2014 23:50:30 +0000 (00:50 +0100)]
Add support for setting double ranges.

This is used for SR_CONF_VOLTAGE_THRESHOLD.

10 years agoconfigure.ac: Only check for things we actually use.
Uwe Hermann [Thu, 20 Mar 2014 13:01:22 +0000 (14:01 +0100)]
configure.ac: Only check for things we actually use.

Drop checks where we don't use the result (yet). We might bring back
some of those once we start actually using the result in the code.

10 years agonsis: Put sigrok-dumps *.sr files into the installer.
Uwe Hermann [Thu, 20 Mar 2014 12:15:50 +0000 (13:15 +0100)]
nsis: Put sigrok-dumps *.sr files into the installer.

These are useful for people to have around for conveniently testing
various frontend features and protocol decoders etc.

10 years agodecode: Show possible values for decoder options.
Bert Vermeulen [Thu, 13 Mar 2014 18:31:28 +0000 (19:31 +0100)]
decode: Show possible values for decoder options.

10 years agodecode: Allow for specifying multiple annotations.
Bert Vermeulen [Thu, 13 Mar 2014 15:39:16 +0000 (16:39 +0100)]
decode: Allow for specifying multiple annotations.

10 years agoSort probes by index.
Bert Vermeulen [Thu, 13 Mar 2014 09:54:10 +0000 (10:54 +0100)]
Sort probes by index.

10 years agosession: Always save in chunks, including in continuous mode.
Bert Vermeulen [Wed, 12 Mar 2014 18:12:20 +0000 (19:12 +0100)]
session: Always save in chunks, including in continuous mode.

10 years agonsis: Fix the "working dir" path for sigrok-cli.
Uwe Hermann [Tue, 11 Mar 2014 22:43:20 +0000 (23:43 +0100)]
nsis: Fix the "working dir" path for sigrok-cli.

For now, start the "DOS box" in the sigrok-cli installation directory,
so that the firmware files and decoder files are found correctly.
We'll probably use another solution that sets %PATH% later on, though.

Thanks to Peter Newman for bringing up this issue.

10 years agonsis: contrib/sigrok-cli.nsi.in: Drop obsolete file.
Uwe Hermann [Tue, 11 Mar 2014 21:09:53 +0000 (22:09 +0100)]
nsis: contrib/sigrok-cli.nsi.in: Drop obsolete file.

We're only using the cross-compile version sigrok-cli_cross.nsi.in these
days since it is much more convenient, and the old native build file
was not working and/or up-to-date anyway.

10 years agoshow: Sort ALL the things.
Bert Vermeulen [Tue, 11 Mar 2014 10:23:47 +0000 (11:23 +0100)]
show: Sort ALL the things.

10 years agoDon't try to set up probes for stacked protocol decoders.
Bert Vermeulen [Mon, 10 Mar 2014 19:29:56 +0000 (20:29 +0100)]
Don't try to set up probes for stacked protocol decoders.

10 years agodecode: Remove debug output.
Bert Vermeulen [Mon, 24 Feb 2014 00:35:31 +0000 (01:35 +0100)]
decode: Remove debug output.

10 years agosession: Do not derive unit size from enabled probes.
Daniel Elstner [Fri, 21 Feb 2014 21:56:44 +0000 (22:56 +0100)]
session: Do not derive unit size from enabled probes.

10 years agosession: Remove call to sr_filter_probes()
Daniel Elstner [Fri, 21 Feb 2014 21:40:38 +0000 (22:40 +0100)]
session: Remove call to sr_filter_probes()

10 years agodecode: Defer probe setup until after the input probes are known
Daniel Elstner [Fri, 21 Feb 2014 19:10:09 +0000 (20:10 +0100)]
decode: Defer probe setup until after the input probes are known

10 years agoparse_probestring: Return list of all probes by default.
Daniel Elstner [Fri, 21 Feb 2014 00:12:26 +0000 (01:12 +0100)]
parse_probestring: Return list of all probes by default.

10 years agoparse_probestring: Fix memory leak on error.
Daniel Elstner [Thu, 20 Feb 2014 23:50:22 +0000 (00:50 +0100)]
parse_probestring: Fix memory leak on error.

10 years agosession: Allow probe selection for session files.
Daniel Elstner [Thu, 20 Feb 2014 23:34:12 +0000 (00:34 +0100)]
session: Allow probe selection for session files.

10 years agoPass new unit_size argument to srd_inst_probe_set_all()
Daniel Elstner [Thu, 20 Feb 2014 05:31:40 +0000 (06:31 +0100)]
Pass new unit_size argument to srd_inst_probe_set_all()

10 years agoshow: Cosmetics and consistency fixes.
Uwe Hermann [Fri, 31 Jan 2014 17:33:51 +0000 (18:33 +0100)]
show: Cosmetics and consistency fixes.

10 years agoshow: Add support for showing PD annotation rows.
Uwe Hermann [Fri, 31 Jan 2014 17:23:13 +0000 (18:23 +0100)]
show: Add support for showing PD annotation rows.

10 years agomanpage: Break line that's too long.
Uwe Hermann [Fri, 31 Jan 2014 13:41:07 +0000 (14:41 +0100)]
manpage: Break line that's too long.

Otherwise "man" will auto-break it and add a confusing dash, etc. etc.

10 years agoman: Update uart decode example syntax
Karl Palsson [Fri, 31 Jan 2014 11:13:52 +0000 (11:13 +0000)]
man: Update uart decode example syntax

"parity" is no longer a valid option, it's parity_type

10 years agoFix more warnings when building without libsigrokdecode.
Uwe Hermann [Tue, 28 Jan 2014 14:55:24 +0000 (15:55 +0100)]
Fix more warnings when building without libsigrokdecode.

10 years agofix build without libsigrokdecode
Dan Horák [Sat, 25 Jan 2014 13:15:24 +0000 (14:15 +0100)]
fix build without libsigrokdecode

When built with libsigrokdecode additional headers are automagically included
via the Python.h header. When built without they must included explicitly.

10 years agoDon't use SR_CONF_MAX_UNCOMPRESSED_SAMPLES.
Bert Vermeulen [Sun, 19 Jan 2014 16:22:19 +0000 (17:22 +0100)]
Don't use SR_CONF_MAX_UNCOMPRESSED_SAMPLES.

This uses the new sr_config_list(SR_CONF_LIMIT_SAMPLES) method to
get the same information.

10 years agoRemove special handling of pattern mode options.
Bert Vermeulen [Sun, 12 Jan 2014 21:52:36 +0000 (22:52 +0100)]
Remove special handling of pattern mode options.

It's just a standard list of strings, better handled by the regular
mechanism.

10 years agoDon't leak GVariant.
Bert Vermeulen [Thu, 9 Jan 2014 15:48:17 +0000 (16:48 +0100)]
Don't leak GVariant.

10 years agoCheck device uncompressed memory size before running.
Bert Vermeulen [Thu, 9 Jan 2014 12:23:32 +0000 (13:23 +0100)]
Check device uncompressed memory size before running.

10 years agoBinary output type now contains [name, description]
Bert Vermeulen [Mon, 23 Dec 2013 23:11:32 +0000 (00:11 +0100)]
Binary output type now contains [name, description]

10 years agonsis: Install zadig (used for driver switching).
Uwe Hermann [Sun, 5 Jan 2014 10:42:34 +0000 (11:42 +0100)]
nsis: Install zadig (used for driver switching).

10 years agonsis: Install libusb0.dll with the application.
Uwe Hermann [Sun, 5 Jan 2014 00:59:32 +0000 (01:59 +0100)]
nsis: Install libusb0.dll with the application.

This fixes bug #243.

10 years agonsis: Mention firmware files in description.
Uwe Hermann [Thu, 2 Jan 2014 13:39:19 +0000 (14:39 +0100)]
nsis: Mention firmware files in description.

10 years agonsis: Fix File/RMDir copy-paste error.
Uwe Hermann [Wed, 1 Jan 2014 19:42:18 +0000 (20:42 +0100)]
nsis: Fix File/RMDir copy-paste error.

10 years agonsis: Also put firmware files into the installer.
Uwe Hermann [Wed, 1 Jan 2014 18:09:58 +0000 (19:09 +0100)]
nsis: Also put firmware files into the installer.

10 years agoAdd support for config keys of type G_VARIANT_TYPE_INT32.
Bert Vermeulen [Thu, 26 Dec 2013 11:08:34 +0000 (12:08 +0100)]
Add support for config keys of type G_VARIANT_TYPE_INT32.

10 years agoFix hardcoded home directory (pass -DHOME=$HOME to makensis).
Martin Ling [Fri, 6 Dec 2013 01:39:50 +0000 (01:39 +0000)]
Fix hardcoded home directory (pass -DHOME=$HOME to makensis).

10 years agoClean up annotation output.
Bert Vermeulen [Sun, 1 Dec 2013 10:55:36 +0000 (11:55 +0100)]
Clean up annotation output.

11 years agoRearrange protocol decoder output levels.
Bert Vermeulen [Wed, 27 Nov 2013 10:24:45 +0000 (11:24 +0100)]
Rearrange protocol decoder output levels.

The protocol decoder output now varies according to --loglevel:

WARN (--loglevel 2, default):
  - show only the first annotation string, without quotes

INFO (--loglevel 3):
  - add sample numbers
  - quotes around annotation

DBG (--loglevel 4 and up):
  - add protocol decoder id
  - add annotation class
  - show all annotation strings, not just the first

In all cases, all annotation classes are shown, unless restricted with
the --protocol-decoder-annotations (-A) option.

11 years agoFix a bunch of compiler warnings.
Uwe Hermann [Tue, 19 Nov 2013 10:48:06 +0000 (11:48 +0100)]
Fix a bunch of compiler warnings.

We need to ensure that libsigrokdecode.h is always the first #include,
otherwise some versions of Python will cause all kinds of compiler
warnings like these:

  CC       device.o
In file included from /usr/include/python3.2mu/Python.h:8:0,
                 from [...]/include/libsigrokdecode/libsigrokdecode.h:25,
                 from sigrok-cli.h:26,
                 from device.c:23:
/usr/include/python3.2mu/pyconfig.h:1182:0: warning: "_POSIX_C_SOURCE" redefined [enabled by default]
 #define _POSIX_C_SOURCE 200112L
 ^
In file included from /usr/include/limits.h:26:0,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed/limits.h:168,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed/syslimits.h:7,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed/limits.h:34,
                 from /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:11,
                 from /usr/include/glib-2.0/glib/gtypes.h:34,
                 from /usr/include/glib-2.0/glib/galloca.h:34,
                 from /usr/include/glib-2.0/glib.h:32,
                 from device.c:21:
/usr/include/features.h:231:0: note: this is the location of the previous definition
 #  define _POSIX_C_SOURCE 200809L
 ^

Since sigrok-cli.h already #includes libsigrok.h and libsigrokdecode.h,
just ensure that the latter is always the first #include by _only_
including it in sigrok-cli.h and nowhere else.

11 years agosigrok-cli: Fix memory leak if we save the default output format to a file.
poljar (Damir Jelić) [Tue, 19 Nov 2013 10:28:09 +0000 (11:28 +0100)]
sigrok-cli: Fix memory leak if we save the default output format to a file.

g_free_byte_array accepts as the second argument a gboolean which determines if
the actual byte data should also be freed:
https://developer.gnome.org/glib/2.28/glib-Byte-Arrays.html#g-byte-array-free

If we pass a FALSE here the data should be freed with g_free(), instead just
pass TRUE and the data will be automatically freed.