From: Uwe Hermann Date: Tue, 1 Aug 2017 20:19:56 +0000 (+0200) Subject: Fix some random clang-tidy warnings. X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=f529583485b54ae73401daf780f8a61d1716d5f1;p=pulseview.git Fix some random clang-tidy warnings. --- diff --git a/android/loghandler.cpp b/android/loghandler.cpp index 2c6674cd..137d2dff 100644 --- a/android/loghandler.cpp +++ b/android/loghandler.cpp @@ -23,7 +23,7 @@ #include -#include +#include #include #include "android/loghandler.hpp" diff --git a/pv/data/decode/annotation.hpp b/pv/data/decode/annotation.hpp index 2be8e88d..42a291a2 100644 --- a/pv/data/decode/annotation.hpp +++ b/pv/data/decode/annotation.hpp @@ -20,7 +20,8 @@ #ifndef PULSEVIEW_PV_VIEW_DECODE_ANNOTATION_HPP #define PULSEVIEW_PV_VIEW_DECODE_ANNOTATION_HPP -#include +#include +#include #include diff --git a/pv/data/decode/decoder.cpp b/pv/data/decode/decoder.cpp index cd3e97d6..511f7bff 100644 --- a/pv/data/decode/decoder.cpp +++ b/pv/data/decode/decoder.cpp @@ -113,7 +113,7 @@ srd_decoder_inst* Decoder::create_decoder_inst(srd_session *session) const return nullptr; // Setup the channels - GArray *const init_pin_states = g_array_sized_new(FALSE, TRUE, + GArray *const init_pin_states = g_array_sized_new(false, true, sizeof(uint8_t), channels_.size()); g_array_set_size(init_pin_states, channels_.size()); @@ -133,7 +133,7 @@ srd_decoder_inst* Decoder::create_decoder_inst(srd_session *session) const srd_inst_channel_set_all(decoder_inst, channels); srd_inst_initial_pins_set_all(decoder_inst, init_pin_states); - g_array_free(init_pin_states, TRUE); + g_array_free(init_pin_states, true); return decoder_inst; } diff --git a/pv/views/trace/signal.cpp b/pv/views/trace/signal.cpp index 3d6ee151..1e277f0d 100644 --- a/pv/views/trace/signal.cpp +++ b/pv/views/trace/signal.cpp @@ -36,7 +36,6 @@ #include "view.hpp" using std::shared_ptr; -using std::make_shared; namespace pv { namespace views {