From: Bert Vermeulen <redacted>
Date: Thu, 18 Apr 2013 19:37:38 +0000 (+0200)
Subject: hantek-dso: Consistently return SR_ERR_ARG if sdi is needed
X-Git-Tag: dsupstream~103
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=e2033d491753c5746ddbc0b8f29a5aa56c297ac3;p=libsigrok.git

hantek-dso: Consistently return SR_ERR_ARG if sdi is needed
---

diff --git a/hardware/hantek-dso/api.c b/hardware/hantek-dso/api.c
index 9e5629ee..fd4f6157 100644
--- a/hardware/hantek-dso/api.c
+++ b/hardware/hantek-dso/api.c
@@ -409,12 +409,10 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi)
 	struct sr_usb_dev_inst *usb;
 	char str[128];
 
-	(void)sdi;
-
 	switch (id) {
 	case SR_CONF_CONN:
 		if (!sdi || !sdi->conn)
-			return SR_ERR;
+			return SR_ERR_ARG;
 		usb = sdi->conn;
 		if (usb->address == 255)
 			/* Device still needs to re-enumerate after firmware