From: Gerhard Sittig <redacted>
Date: Sat, 5 Nov 2016 17:01:43 +0000 (+0100)
Subject: serial-dmm: comment nit on the UART bitrate for ES519xx chips
X-Git-Tag: libsigrok-0.5.0~175
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=d5b1b76d65c446bed0dbabdccd66e51d8cdc8298;p=libsigrok.git

serial-dmm: comment nit on the UART bitrate for ES519xx chips

Factor out identical comments on the UART bitrate of ES519xx based
multimeters. These probably got copied from the first item as of 2012
when new items were added in 2014 (the added devices were from the
same vendor and rebadged).

Expand on the fact that the bitrate still is within spec, and does not
harm at all. Strictly speaking the comment could get dropped.
---

diff --git a/src/hardware/serial-dmm/api.c b/src/hardware/serial-dmm/api.c
index aaf0066c..a9f9cff8 100644
--- a/src/hardware/serial-dmm/api.c
+++ b/src/hardware/serial-dmm/api.c
@@ -263,16 +263,20 @@ SR_REGISTER_DEV_DRIVER_LIST(serial_dmm_drivers,
 		sr_es519xx_2400_11b_packet_valid, sr_es519xx_2400_11b_parse,
 		NULL
 	),
+	/*
+	 * Note: ES51922 and ES51986 baudrate is actually 19230. This is
+	 * "out" by .15%, and so is well within the typical 1% margin
+	 * that is considered acceptable in UART communication, and thus
+	 * should not cause an issue.
+	 */
 	DMM(
 		"tenma-72-7750-ser", es519xx,
-		/* Note: ES51986 baudrate is actually 19230! */
 		"Tenma", "72-7750 (UT-D02 cable)", "19200/7o1/rts=0/dtr=1",
 		19200, ES519XX_11B_PACKET_SIZE, 0, 0, NULL,
 		sr_es519xx_19200_11b_packet_valid, sr_es519xx_19200_11b_parse,
 		NULL
 	),
 	DMM(
-		/* Note: ES51986 baudrate is actually 19230! */
 		"uni-t-ut60g-ser", es519xx,
 		"UNI-T", "UT60G (UT-D02 cable)", "19200/7o1/rts=0/dtr=1",
 		19200, ES519XX_11B_PACKET_SIZE, 0, 0, NULL,
@@ -281,7 +285,6 @@ SR_REGISTER_DEV_DRIVER_LIST(serial_dmm_drivers,
 	),
 	DMM(
 		"uni-t-ut61e-ser", es519xx,
-		/* Note: ES51922 baudrate is actually 19230! */
 		"UNI-T", "UT61E (UT-D02 cable)", "19200/7o1/rts=0/dtr=1",
 		19200, ES519XX_14B_PACKET_SIZE, 0, 0, NULL,
 		sr_es519xx_19200_14b_packet_valid, sr_es519xx_19200_14b_parse,