From: Soeren Apel Date: Sun, 14 Oct 2018 20:56:08 +0000 (+0200) Subject: Implement fixes proposed by clang-tidy X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=d2d0056dc4ff51ae814b136ff92c3458dfae27d3;p=pulseview.git Implement fixes proposed by clang-tidy --- diff --git a/pv/application.cpp b/pv/application.cpp index 1bc844a4..f588fa37 100644 --- a/pv/application.cpp +++ b/pv/application.cpp @@ -115,14 +115,14 @@ void Application::collect_version_info(shared_ptr context) // Firmware paths l_orig = sr_resourcepaths_get(SR_RESOURCE_FIRMWARE); for (GSList *l = l_orig; l; l = l->next) - fw_path_list_.push_back(QString((char*)l->data)); + fw_path_list_.emplace_back((char*)l->data); g_slist_free_full(l_orig, g_free); // PD paths #ifdef ENABLE_DECODE l_orig = srd_searchpaths_get(); for (GSList *l = l_orig; l; l = l->next) - pd_path_list_.push_back(QString((char*)l->data)); + pd_path_list_.emplace_back((char*)l->data); g_slist_free_full(l_orig, g_free); #endif diff --git a/pv/dialogs/settings.cpp b/pv/dialogs/settings.cpp index 07958796..d17f5d04 100644 --- a/pv/dialogs/settings.cpp +++ b/pv/dialogs/settings.cpp @@ -54,7 +54,6 @@ #include #endif -using std::shared_ptr; using pv::widgets::ColorButton; namespace pv {