From: Uwe Hermann <redacted>
Date: Wed, 11 Dec 2019 21:10:54 +0000 (+0100)
Subject: Remove the 'tags' feature since it's an ABI change.
X-Git-Tag: libsigrokdecode-0.5.3~3
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=b9bafaf82f7569af026ef3a5b10bec039c312c2c;p=libsigrokdecode.git

Remove the 'tags' feature since it's an ABI change.
---

diff --git a/HACKING b/HACKING
index a4698a6..30cd1fe 100644
--- a/HACKING
+++ b/HACKING
@@ -176,47 +176,6 @@ Protocol decoder guidelines
    Not recommended:
      'FIND_ADDRESS', 'Get Temperature', 'start'
 
- - Protocol decoder tags:
-
-   - Every decoder must have a "tags" list (>= 1 items, alphabetically sorted).
-
-   - All tag names start with a capital letter. Subsequent words of the name
-     are not capitalized, e.g. "Retro computing", "Debug/trace".
-
-   - All tag names should use singular form ("Sensor", not "Sensors").
-
-   Common tags:
-
-   - Analog/digital: Decoders related A/D conversion, e.g. ADCs and DACs.
-   - Audio: Decoders related to audio protocols, e.g. I²S, S/PDIF.
-   - Automotive: Decoders related to automotive protocols, e.g. CAN, FlexRay.
-   - Clock/timing: Decoders related to time keeping, timing, and clocks/RTCs.
-   - Debug/trace: Decoders related to microcontroller/CPU debugging, tracing,
-     programming/flashing protocols, e.g. SWD, JTAG, AVR ISP, ARM ETMv3.
-   - Display: Decoders related to display technologies, e.g. DVI, HDMI,
-     TFT, OLED, LCD, HD44780, EDID, and various LED protocols.
-   - Embedded/industrial: Decoders related to protocols used in embedded
-     systems, industrial systems, or automation (e.g. SPI, Modbus, Profibus).
-   - Encoding: Decoders related to generic encoding / line coding systems,
-     e.g. Manchester, Miller, Gray code, OOK, and similar.
-   - IC: Decoders for specific (families of) ICs (i.e. not IC-independent,
-     generic protocols like UART, SPI, CAN, or USB).
-   - IR: Decoders related to infrared (e.g. remote control) protocols.
-   - Lighting: Decoders related to lighting technologies, e.g. DALI, DMX512.
-   - Memory: Decoders related to memories (e.g. NOR/NAND flash, EEPROM,
-     SDRAM, SRAM, various other volatile or non-volatile memories).
-   - Networking: Decoders related to (wired) networking technologies.
-   - PC: Decoders related to protocols used in personal computers (desktop,
-     workstation, laptop, server). This is not meant to be restricted to
-     "IBM PC" or "x86/Intel", Apple/Commodore/Atari/SPARC etc. are fine too.
-   - RFID: Decoders related to RFID protocols, e.g. EM4100, T55xx.
-   - Retro computing: Decoders related to retro computing, e.g. MCS-48, Z80.
-   - Security/crypto: Decoders related to security or cryptography.
-   - Sensor: Decoders for sensors or all kinds, e.g. temperature or humidity.
-   - Util: Random utility/helper decoders.
-   - Wireless/RF: Decoders related to various wireless/RF technologies, e.g.
-     Bluetooth, BLE, Wifi, or 2.4GHz/433MHz custom protocols.
-
 
 Testsuite
 ---------
diff --git a/NEWS b/NEWS
index ad3622b..f61727f 100644
--- a/NEWS
+++ b/NEWS
@@ -22,9 +22,6 @@ require some adaptations on the user's side in some cases.
    - ir_rc6           RC-6 infrared remote control protocol
    - ieee488          IEEE-488 General Purpose Interface Bus (GPIB/HPIB or IEC)
    - hdcp             HDCP protocol over HDMI
- * Add a mandatory 'tags' decoder metadata field that can be used by frontends
-   for grouping various PDs together by topic, e.g. "Sensor", "Audio", etc.
-   The full list of currently used tags is documented in the HACKING file.
  * All decoders must implement a reset() method now. It should reset all
    PD-internal state and will be called when the decoder is restarted from
    scratch (by frontends) with new data.
diff --git a/decoder.c b/decoder.c
index cef4f29..1a9defb 100644
--- a/decoder.c
+++ b/decoder.c
@@ -171,7 +171,6 @@ static void decoder_free(struct srd_decoder *dec)
 
 	g_slist_free_full(dec->outputs, g_free);
 	g_slist_free_full(dec->inputs, g_free);
-	g_slist_free_full(dec->tags, g_free);
 	g_free(dec->license);
 	g_free(dec->desc);
 	g_free(dec->longname);
@@ -803,11 +802,6 @@ SRD_API int srd_decoder_load(const char *module_name)
 		goto err_out;
 	}
 
-	if (py_attr_as_strlist(d->py_dec, "tags", &(d->tags)) != SRD_OK) {
-		fail_txt = "missing or malformed 'tags' attribute";
-		goto err_out;
-	}
-
 	/* All options and their default values. */
 	if (get_options(d) != SRD_OK) {
 		fail_txt = "cannot get options";
diff --git a/libsigrokdecode.h b/libsigrokdecode.h
index b9cc921..287f2d5 100644
--- a/libsigrokdecode.h
+++ b/libsigrokdecode.h
@@ -161,9 +161,6 @@ struct srd_decoder {
 	/** List of possible decoder output IDs. */
 	GSList *outputs;
 
-	/** List of tags associated with this decoder. */
-	GSList *tags;
-
 	/** List of channels required by this decoder. */
 	GSList *channels;