From: Gerhard Sittig Date: Thu, 8 Feb 2018 22:11:59 +0000 (+0100) Subject: dreamsourcelab-dslogic: avoid NULL pointer dereference X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=8e2fd23acb61f8f7471e40ef7439568022485d25;p=libsigrok.git dreamsourcelab-dslogic: avoid NULL pointer dereference Check pointers' validity before dereferencing them. This was reported by clang's scan-build. --- diff --git a/src/hardware/dreamsourcelab-dslogic/api.c b/src/hardware/dreamsourcelab-dslogic/api.c index 66c81037..021d7023 100644 --- a/src/hardware/dreamsourcelab-dslogic/api.c +++ b/src/hardware/dreamsourcelab-dslogic/api.c @@ -514,12 +514,16 @@ static int config_list(uint32_t key, GVariant **data, case SR_CONF_DEVICE_OPTIONS: return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts); case SR_CONF_VOLTAGE_THRESHOLD: + if (!devc || !devc->profile) + return SR_ERR_ARG; if (!strcmp(devc->profile->model, "DSLogic")) *data = std_gvar_thresholds(ARRAY_AND_SIZE(thresholds)); else *data = std_gvar_min_max_step_thresholds(0.0, 5.0, 0.1); break; case SR_CONF_SAMPLERATE: + if (!devc) + return SR_ERR_ARG; *data = std_gvar_samplerates(devc->samplerates, devc->num_samplerates); break; case SR_CONF_TRIGGER_MATCH: