From: Uwe Hermann <redacted>
Date: Tue, 15 May 2018 23:27:30 +0000 (+0200)
Subject: type_decoder.c: Fix a memory leak reported by scan-build.
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=8ad9a3e48ddf79e08cd48073c953ea665c464005;p=libsigrokdecode.git

type_decoder.c: Fix a memory leak reported by scan-build.

  type_decoder.c:206:2: warning: Potential leak of memory pointed to by 'pdb'
          PyGILState_Release(gstate);
          ^~~~~~~~~~~~~~~~~~
---

diff --git a/type_decoder.c b/type_decoder.c
index dfa3fa9..35187a5 100644
--- a/type_decoder.c
+++ b/type_decoder.c
@@ -186,12 +186,12 @@ static int convert_binary(struct srd_decoder_inst *di, PyObject *obj,
 		goto err;
 	}
 
-	pdb = g_malloc(sizeof(struct srd_proto_data_binary));
 	if (PyBytes_AsStringAndSize(py_tmp, &buf, &size) == -1)
 		goto err;
 
 	PyGILState_Release(gstate);
 
+	pdb = g_malloc(sizeof(struct srd_proto_data_binary));
 	pdb->bin_class = bin_class;
 	pdb->size = size;
 	if (!(pdb->data = g_try_malloc(pdb->size))) {