From: Bert Vermeulen <redacted>
Date: Thu, 2 Oct 2014 12:58:57 +0000 (+0200)
Subject: chronovu-la8: Code cleanup.
X-Git-Tag: libsigrok-0.4.0~900
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=65c8d48f1418700dae72c8b6e39eb0d77b1ea17d;p=libsigrok.git

chronovu-la8: Code cleanup.

This cleans up a warning generated by clang's static analyzer.
---

diff --git a/src/hardware/chronovu-la/api.c b/src/hardware/chronovu-la/api.c
index 594a0649..d65dabb6 100644
--- a/src/hardware/chronovu-la/api.c
+++ b/src/hardware/chronovu-la/api.c
@@ -142,7 +142,8 @@ static int add_device(int idx, int model, GSList **devices)
 	*devices = g_slist_append(*devices, sdi);
 	drvc->instances = g_slist_append(drvc->instances, sdi);
 
-	return SR_OK;
+	if (ret == SR_OK)
+		return SR_OK;
 
 err_free_dev_inst:
 	sr_dev_inst_free(sdi);
@@ -210,8 +211,6 @@ static int dev_open(struct sr_dev_inst *sdi)
 	struct dev_context *devc;
 	int ret;
 
-	ret = SR_ERR;
-
 	if (!(devc = sdi->priv))
 		return SR_ERR_BUG;
 
@@ -254,7 +253,8 @@ static int dev_open(struct sr_dev_inst *sdi)
 
 	sdi->status = SR_ST_ACTIVE;
 
-	return SR_OK;
+	if (ret == SR_OK)
+		return SR_OK;
 
 err_ftdi_free:
 	ftdi_free(devc->ftdic); /* Close device (if open), free FTDI context. */