From: Gerhard Sittig <redacted>
Date: Sun, 14 May 2017 17:36:17 +0000 (+0200)
Subject: can: Convert to PD API version 3
X-Git-Tag: libsigrokdecode-0.5.0~18
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=64d8711976c3e74a4a19beabd505438ce91ac86c;p=libsigrokdecode.git

can: Convert to PD API version 3

Don't inspect each individual sample in the Python based PD. Instead use
the backend's query API to detect the start of a frame and to advance to
the sample point position.
---

diff --git a/decoders/can/pd.py b/decoders/can/pd.py
index f1adef1..46054cd 100644
--- a/decoders/can/pd.py
+++ b/decoders/can/pd.py
@@ -23,7 +23,7 @@ class SamplerateError(Exception):
     pass
 
 class Decoder(srd.Decoder):
-    api_version = 2
+    api_version = 3
     id = 'can'
     name = 'CAN'
     longname = 'Controller Area Network'
@@ -105,12 +105,10 @@ class Decoder(srd.Decoder):
         self.ss_bit12 = None
         self.ss_databytebits = []
 
-    # Return True if we reached the desired bit position, False otherwise.
-    def reached_bit(self, bitnum):
+    # Determine the position of the next desired bit's sample point.
+    def get_sample_point(self, bitnum):
         bitpos = int(self.sof + (self.bit_width * bitnum) + self.bitpos)
-        if self.samplenum >= bitpos:
-            return True
-        return False
+        return bitpos
 
     def is_stuff_bit(self):
         # CAN uses NRZ encoding and bit stuffing.
@@ -371,22 +369,19 @@ class Decoder(srd.Decoder):
 
         self.curbit += 1
 
-    def decode(self, ss, es, data):
+    def decode(self):
         if not self.samplerate:
             raise SamplerateError('Cannot decode without samplerate.')
-        for (self.samplenum, pins) in data:
-
-            (can_rx,) = pins
 
+        while True:
             # State machine.
             if self.state == 'IDLE':
                 # Wait for a dominant state (logic 0) on the bus.
-                if can_rx == 1:
-                    continue
+                (can_rx,) = self.wait({0: 'l'})
                 self.sof = self.samplenum
                 self.state = 'GET BITS'
             elif self.state == 'GET BITS':
                 # Wait until we're in the correct bit/sampling position.
-                if not self.reached_bit(self.curbit):
-                    continue
+                pos = self.get_sample_point(self.curbit)
+                (can_rx,) = self.wait({'skip': pos - self.samplenum})
                 self.handle_bit(can_rx)