From: Stefan BrĂ¼ns Date: Mon, 17 Jun 2019 17:56:51 +0000 (+0200) Subject: usb_request: Use separate annotation rows for IN, OUT and CONTROL X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=37c120b9629d6671273703166cce94a8200d9476;p=libsigrokdecode.git usb_request: Use separate annotation rows for IN, OUT and CONTROL E.g. CONTROL and BULK IN transfers may overlap each other, and as a result only one of the two can be seen in pulseview. Partly solves bug #1046. In case a device has multiple IN/OUT endpoints, transfers would still overlap, but many simple devices have just one each. --- diff --git a/decoders/usb_request/pd.py b/decoders/usb_request/pd.py index 25ee4c5..71097a1 100644 --- a/decoders/usb_request/pd.py +++ b/decoders/usb_request/pd.py @@ -129,7 +129,9 @@ class Decoder(srd.Decoder): ('errors', 'Unexpected packets'), ) annotation_rows = ( - ('request', 'USB requests', tuple(range(4))), + ('request-setup', 'USB SETUP', (0, 1)), + ('request-in', 'USB BULK IN', (2,)), + ('request-out', 'USB BULK OUT', (3,)), ('errors', 'Errors', (4,)), ) binary = (