From: Gerhard Sittig <redacted>
Date: Sun, 23 Oct 2016 09:55:07 +0000 (+0200)
Subject: output/wav: change default for scale factor from 0.0 to 1.0
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=23eeac46edef25d1be2ff4716cb388296b6222ac;p=libsigrok.git

output/wav: change default for scale factor from 0.0 to 1.0

The WAV output module supports an optional 'scale' factor, in its
absence the samples will pass unmodified. The builtin help text is
unexpected, and reads:

  $ sigrok-cli -O wav --show
  ...
  Options:
    scale: Scale values by factor (default 0.0)

Setup a default scale factor of 1.0, which results in identical
behaviour and better reflects what is happening.
---

diff --git a/src/output/wav.c b/src/output/wav.c
index 6984c03d..79ea31e2 100644
--- a/src/output/wav.c
+++ b/src/output/wav.c
@@ -305,7 +305,7 @@ static int receive(const struct sr_output *o, const struct sr_datafeed_packet *p
 				idx = chan_idx[j];
 				buf = outc->chanbuf[idx] + outc->chanbuf_used[idx]++ * 4;
 				f = data[i * num_channels + j];
-				if (outc->scale != 0.0)
+				if (outc->scale != 1.0)
 					f /= outc->scale;
 				float_to_le(buf, f);
 			}
@@ -338,7 +338,7 @@ static struct sr_option options[] = {
 static const struct sr_option *get_options(void)
 {
 	if (!options[0].def)
-		options[0].def = g_variant_ref_sink(g_variant_new_double(0.0));
+		options[0].def = g_variant_ref_sink(g_variant_new_double(1.0));
 
 	return options;
 }