From: Uwe Hermann <redacted>
Date: Sat, 28 Jul 2012 15:39:38 +0000 (+0200)
Subject: srd: avr_isp: Improve Chip Erase handling.
X-Git-Tag: libsigrokdecode-0.1.1~33
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=1fd698dcf076c62e53e089be50572efae6b68f15;p=libsigrokdecode.git

srd: avr_isp: Improve Chip Erase handling.
---

diff --git a/decoders/avr_isp/pd.py b/decoders/avr_isp/pd.py
index 4b496e0..9ecc280 100644
--- a/decoders/avr_isp/pd.py
+++ b/decoders/avr_isp/pd.py
@@ -116,9 +116,18 @@ class Decoder(srd.Decoder):
         self.xx, self.yy, self.zz, self.mm = 0, 0, 0, 0
 
     def handle_cmd_chip_erase(self, cmd, ret):
-        # TODO
+        # Chip erase (erases both flash an EEPROM).
+        # Upon successful chip erase, the lock bits will also be erased.
+        # The only way to end a Chip Erase cycle is to release RESET#.
         self.putx([0, ['Chip erase']])
 
+        # TODO: Check/handle RESET#.
+
+        # Sanity check on reply.
+        bit = (ret[2] & (1 << 7)) >> 7
+        if ret[1] != 0xac or bit != 1 or ret[3] != cmd[2]:
+            self.putx([1, ['Warning: Unexpected bytes in reply!']])
+
     def handle_cmd_read_fuse_bits(self, cmd, ret):
         # Read fuse bits.
         self.putx([0, ['Read fuse bits: 0x%02x' % ret[3]]])