From: Uwe Hermann <redacted>
Date: Fri, 22 Nov 2013 15:07:32 +0000 (+0100)
Subject: Temporarily disable USE_TERMIOX code (breaks the lib).
X-Git-Tag: libserialport-0.1.0~75
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=1d5d2a166f582e06aa2848fe9ca9c33f85acd45d;p=libserialport.git

Temporarily disable USE_TERMIOX code (breaks the lib).

On some systems the use of the code enabled by USE_TERMIOX leads to a
non-working sp_open() which breaks all functionality provided by the lib.

Thus, temporarily disable that code until the details are investigated.

This has been tested with a serial port DMM and the OLS logic analyzer
on an x86 64bit Linux system with kernel version 3.11. The code compiles
fine but doesn't work at runtime. The configure output included:

checking for struct termios2... yes
checking for struct termiox... yes

The root cause for the problem is that the ioctl(fd, TCGETX, data) call in
get_flow() returns -1 ("Invalid argument"), which in turn lets sp_open()
return SP_ERR_FAIL.
---

diff --git a/serialport.c b/serialport.c
index 5e77607..9697b7c 100644
--- a/serialport.c
+++ b/serialport.c
@@ -46,7 +46,8 @@
 #include "linux/serial.h"
 #include "linux_termios.h"
 #if defined(TCGETX) && defined(TCSETX) && defined(HAVE_TERMIOX)
-#define USE_TERMIOX
+// FIXME: Temporarily disabled, breaks all lib functionality on some systems.
+// #define USE_TERMIOX
 #endif
 #endif