From: Uwe Hermann <redacted>
Date: Sun, 22 Jul 2018 14:59:38 +0000 (+0200)
Subject: input/wav: Fix potential buffer overflow (and compiler warning).
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=19d816c54ad24d93b2af6ba2f0406d6f8df0a3af;p=libsigrok.git

input/wav: Fix potential buffer overflow (and compiler warning).

With gcc 8 this yielded:

  src/input/wav.c: In function ‘receive’:
  src/input/wav.c:345:51: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=]
       snprintf(channelname, sizeof(channelname), "CH%d", i + 1);
                                                     ^~
  src/input/wav.c:345:48: note: directive argument in the range [1, 2147483647]
       snprintf(channelname, sizeof(channelname), "CH%d", i + 1);
                                                  ^~~~~~
  src/input/wav.c:345:5: note: ‘snprintf’ output between 4 and 13 bytes into a destination of size 8
       snprintf(channelname, sizeof(channelname), "CH%d", i + 1);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---

diff --git a/src/input/wav.c b/src/input/wav.c
index 66dfce98..b6d55888 100644
--- a/src/input/wav.c
+++ b/src/input/wav.c
@@ -320,7 +320,7 @@ static int receive(struct sr_input *in, GString *buf)
 {
 	struct context *inc;
 	int ret;
-	char channelname[8];
+	char channelname[16];
 
 	g_string_append_len(in->buf, buf->str, buf->len);