From: Bert Vermeulen <redacted>
Date: Wed, 16 Oct 2013 12:21:05 +0000 (+0200)
Subject: Key strings passed to decoder options must be newly allocated
X-Git-Tag: pulseview-0.2.0~241
X-Git-Url: https://sigrok.org/gitaction?a=commitdiff_plain;h=1429b21db812b591699341712af2f1dd448363c5;p=pulseview.git

Key strings passed to decoder options must be newly allocated
---

diff --git a/pv/prop/binding/decoderoptions.cpp b/pv/prop/binding/decoderoptions.cpp
index 435d5f6d..dc3a8e97 100644
--- a/pv/prop/binding/decoderoptions.cpp
+++ b/pv/prop/binding/decoderoptions.cpp
@@ -80,8 +80,10 @@ GVariant* DecoderOptions::getter(const char *id)
 		{
 			const srd_decoder_option *const opt =
 				(srd_decoder_option*)l->data;
-			if (strcmp(opt->id, id) == 0)
+			if (strcmp(opt->id, id) == 0) {
 				val = opt->def;
+				break;
+			}
 		}
 	}
 
@@ -94,7 +96,7 @@ GVariant* DecoderOptions::getter(const char *id)
 void DecoderOptions::setter(const char *id, GVariant *value)
 {
 	g_variant_ref(value);
-	g_hash_table_insert(_options, (void*)id, value);
+	g_hash_table_insert(_options, (void*)g_strdup(id), value);
 }
 
 } // binding