]> sigrok.org Git - libsigrok.git/commitdiff
lecroy-xstream: Use best-effort strategy for unknown models
authorSoeren Apel <redacted>
Tue, 3 Oct 2017 11:29:46 +0000 (13:29 +0200)
committerSoeren Apel <redacted>
Tue, 3 Oct 2017 15:31:48 +0000 (17:31 +0200)
As there is a huge range of supported LeCroy scopes, naming
the IDN response for every single one of them is going to be
impossible. Hence, it makes more sense to treat all LeCroy
devices as if they were scopes and supported. This approach
lets users try to see how far they get and if they run into
issues, they can then be treated separately - e.g. by creating
a custom device profile.
Unless we do this, the vast majority of LeCroy scopes will
not be recognized by the driver.

src/hardware/lecroy-xstream/protocol.c

index 63459d0b8cb412daf850a7841ba59041c10f04c2..ce06c9b4cf7f66ccb78a53bb791935097c6198b8 100644 (file)
@@ -166,7 +166,8 @@ static const char *scope_analog_channel_names[] = {
 
 static const struct scope_config scope_models[] = {
        {
-               .name = { "WP7000", "WP7100", "WP7200", "WP7300" },
+                /* Default config */
+               .name = {NULL},
 
                .analog_channels = 4,
                .analog_names = &scope_analog_channel_names,
@@ -455,8 +456,10 @@ SR_PRIV int lecroy_xstream_init_device(struct sr_dev_inst *sdi)
        }
 
        if (model_index == -1) {
-               sr_dbg("Unsupported LeCroy device.");
-               return SR_ERR_NA;
+               sr_dbg("Unknown LeCroy device, using default config.");
+               for (i = 0; i < ARRAY_SIZE(scope_models); i++)
+                       if (scope_models[i].name[0] == NULL)
+                               model_index = i;
        }
 
        /* Set the desired response and format modes. */