Implement fixes proposed by clang-tidy

diff --git a/pv/application.cpp b/pv/application.cpp
index 1bc844a4420c98ccbcfb289ef3db40bedc589013..f588fa3714ea44b8a17d63dbd3957923742018da 100644 (file)
--- a/pv/application.cpp
+++ b/pv/application.cpp
@@ -115,14 +115,14 @@ void Application::collect_version_info(shared_ptr<sigrok::Context> context)
        // Firmware paths
        l_orig = sr_resourcepaths_get(SR_RESOURCE_FIRMWARE);
        for (GSList *l = l_orig; l; l = l->next)
-               fw_path_list_.push_back(QString((char*)l->data));
+               fw_path_list_.emplace_back((char*)l->data);
        g_slist_free_full(l_orig, g_free);
 
        // PD paths
 #ifdef ENABLE_DECODE
        l_orig = srd_searchpaths_get();
        for (GSList *l = l_orig; l; l = l->next)
-               pd_path_list_.push_back(QString((char*)l->data));
+               pd_path_list_.emplace_back((char*)l->data);
        g_slist_free_full(l_orig, g_free);
 #endif
 

diff --git a/pv/dialogs/settings.cpp b/pv/dialogs/settings.cpp
index 0795879675054403477a3744ebec6079c7a34246..d17f5d04c35cd61d02be0fec28da8af89750701f 100644 (file)
--- a/pv/dialogs/settings.cpp
+++ b/pv/dialogs/settings.cpp
@@ -54,7 +54,6 @@
 #include <libsigrokdecode/libsigrokdecode.h>
 #endif
 
-using std::shared_ptr;
 using pv::widgets::ColorButton;
 
 namespace pv {