radioshack-dmm: Check for valid mode before calculating checksum

The packet mode byte is akin to a signature. If that is invalid, there's
no point in calculating the checksum, so check the mode first.

Signed-off-by: Alexandru Gagniuc <redacted>

diff --git a/hardware/radioshack-dmm/protocol.c b/hardware/radioshack-dmm/protocol.c
index de925b56838ebd376bbecb723fb710cee2b8172b..f74e7017a473515d366b142a104bdf77a59dd273 100644 (file)
--- a/hardware/radioshack-dmm/protocol.c
+++ b/hardware/radioshack-dmm/protocol.c
@@ -176,10 +176,14 @@ static gboolean selection_good(const struct rs_22_812_packet *rs_packet)
  */
 SR_PRIV gboolean rs_22_812_packet_valid(const struct rs_22_812_packet *rs_packet)
 {
-       if (!checksum_valid(rs_packet))
+       /*
+        * Check for valid mode first, before calculating the checksum.
+        * No point calculating the checksum, if we know we'll reject the packet
+        * */
+       if (!(rs_packet->mode < MODE_INVALID))
                return FALSE;
 
-       if (!(rs_packet->mode < MODE_INVALID))
+       if (!checksum_valid(rs_packet))
                return FALSE;
 
        if (!selection_good(rs_packet))