]> sigrok.org Git - libsigrok.git/commitdiff
input/wav: Fix broken handling of float32 samples on big endian
authorMarcus Comstedt <redacted>
Tue, 2 Sep 2014 17:14:25 +0000 (19:14 +0200)
committerMarcus Comstedt <redacted>
Tue, 2 Sep 2014 17:14:25 +0000 (19:14 +0200)
Also, make sure that floats are 32 bit even in the case of an
extensible header.

src/input/wav.c

index c5abf235d70864ff67da82990ef9af3a855f28e6..fd1920e50181412e77466afb267d9e8516ed9aab 100644 (file)
@@ -102,6 +102,10 @@ static int parse_wav_header(GString *buf, struct context *inc)
                        sr_err("Only PCM and floating point samples are supported.");
                        return SR_ERR_DATA;
                }
+               if (fmt_code == WAVE_FORMAT_IEEE_FLOAT && unitsize != 4) {
+                       sr_err("only 32-bit floats supported.");
+                       return SR_ERR_DATA;
+               }
        } else {
                sr_err("Only PCM and floating point samples are supported.");
                return SR_ERR_DATA;
@@ -244,8 +248,9 @@ static void send_chunk(const struct sr_input *in, int offset, int num_samples)
                } else {
                        /* BINARY32 float */
 #ifdef WORDS_BIGENDIAN
+                       int i;
                        for (i = 0; i < inc->unitsize; i++)
-                               d[i] = s[inc->unitsize - i];
+                               d[i] = s[inc->unitsize - 1 - i];
 #else
                        memcpy(d, s, inc->unitsize);
 #endif