]> sigrok.org Git - sigrok-cli.git/commitdiff
show: pass NULL parameter to config_key_has_cap() instead of uninitialized cg.
authorAurelien Jacobs <redacted>
Thu, 12 Feb 2015 16:08:33 +0000 (17:08 +0100)
committerAurelien Jacobs <redacted>
Thu, 12 Feb 2015 16:08:33 +0000 (17:08 +0100)
It doesn't make sense to pass a cg to this config_key_has_cap() call
as it is trying to retrieve the device's global SR_CONF_LIMIT_SAMPLES.

This fixes the following warning:

show.c: In function ‘show_dev_detail’:
show.c:392:8: warning: ‘cg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     && config_key_has_cap(driver, sdi, cg, key, SR_CONF_LIST)) {
        ^

show.c

diff --git a/show.c b/show.c
index a5999a2b434d37a93c2f57de57a1f1f996aac5ea..d43c716ba52d4bde79af35b89af38d885a7c7268 100644 (file)
--- a/show.c
+++ b/show.c
@@ -389,7 +389,7 @@ void show_dev_detail(void)
                        g_variant_unref(gvar_list);
 
                } else if (key == SR_CONF_LIMIT_SAMPLES
-                               && config_key_has_cap(driver, sdi, cg, key, SR_CONF_LIST)) {
+                               && config_key_has_cap(driver, sdi, NULL, key, SR_CONF_LIST)) {
                        /* If implemented in config_list(), this denotes the
                         * maximum number of samples a device can send. This
                         * really applies only to logic analyzers, and then