tests: add (negative) "." test case for rational conversion

A naive implementation of the parse rational conversion helper could
have accepted invalid input. Check for the expected conversion failure.

diff --git a/tests/strutil.c b/tests/strutil.c
index 82856f1dd4a4d8e719bc0c5b5b9326fa6334a2a7..fca70eaaee36ef270d6725376391add9715197a2 100644 (file)
--- a/tests/strutil.c
+++ b/tests/strutil.c
@@ -125,6 +125,15 @@ static void test_rational(const char *input, struct sr_rational expected)
                    input, rational.p, rational.q);
 }
 
+static void test_rational_fail(const char *input)
+{
+       int ret;
+       struct sr_rational rational;
+
+       ret = sr_parse_rational(input, &rational);
+       fail_unless(ret != SR_OK, "Unexpected success for '%s'.", input);
+}
+
 static void test_voltage(uint64_t v_p, uint64_t v_q, const char *expected)
 {
        char *s;
@@ -395,6 +404,9 @@ START_TEST(test_fractional)
        test_rational("-.1", (struct sr_rational){-1, 10});
        test_rational(" .1", (struct sr_rational){1, 10});
        test_rational("+.1", (struct sr_rational){1, 10});
+       test_rational_fail(".");
+       test_rational_fail(".e");
+       test_rational_fail(".e1");
 }
 END_TEST