]> sigrok.org Git - libsigrok.git/commitdiff
ols: Fix endianness problems in protocol.
authorBert Vermeulen <redacted>
Wed, 29 Jan 2014 07:22:02 +0000 (08:22 +0100)
committerBert Vermeulen <redacted>
Wed, 29 Jan 2014 14:34:24 +0000 (15:34 +0100)
hardware/openbench-logic-sniffer/api.c
hardware/openbench-logic-sniffer/protocol.c
hardware/openbench-logic-sniffer/protocol.h

index 7852b6ce3ee473b43bcbb1e9f6b39ca0f2404ad8..a2d1f3a60bf3afb57fc12ff24c2adf02c7953929 100644 (file)
@@ -415,17 +415,52 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
        return SR_OK;
 }
 
+static int set_trigger(const struct sr_dev_inst *sdi, int stage)
+{
+       struct dev_context *devc;
+       struct sr_serial_dev_inst *serial;
+       uint8_t cmd, arg[4];
+
+       devc = sdi->priv;
+       serial = sdi->conn;
+
+       cmd = CMD_SET_TRIGGER_MASK + stage * 4;
+       arg[0] = devc->trigger_mask[stage] & 0xff;
+       arg[1] = (devc->trigger_mask[stage] >> 8) & 0xff;
+       arg[2] = (devc->trigger_mask[stage] >> 16) & 0xff;
+       arg[3] = (devc->trigger_mask[stage] >> 24) & 0xff;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       cmd = CMD_SET_TRIGGER_VALUE + stage * 4;
+       arg[0] = devc->trigger_value[stage] & 0xff;
+       arg[1] = (devc->trigger_value[stage] >> 8) & 0xff;
+       arg[2] = (devc->trigger_value[stage] >> 16) & 0xff;
+       arg[3] = (devc->trigger_value[stage] >> 24) & 0xff;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       cmd = CMD_SET_TRIGGER_CONFIG + stage * 4;
+       arg[0] = arg[1] = arg[3] = 0x00;
+       arg[2] = stage;
+       if (stage == devc->num_stages)
+               /* Last stage, fire when this one matches. */
+               arg[3] |= TRIGGER_START;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       return SR_OK;
+}
+
 static int dev_acquisition_start(const struct sr_dev_inst *sdi,
                void *cb_data)
 {
        struct dev_context *devc;
        struct sr_serial_dev_inst *serial;
-       uint32_t trigger_config[4];
-       uint32_t data;
        uint16_t samplecount, readcount, delaycount;
-       uint8_t changrp_mask;
+       uint8_t changrp_mask, arg[4];
        int num_channels;
-       int i;
+       int ret, i;
 
        if (sdi->status != SR_ST_ACTIVE)
                return SR_ERR_DEV_CLOSED;
@@ -458,92 +493,61 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi,
         */
        samplecount = MIN(devc->max_samples / num_channels, devc->limit_samples);
        readcount = samplecount / 4;
-       if (samplecount % 4)
+
+       /* Rather read too many samples than too few. */
+       if (samplecount % 4 != 0)
                readcount++;
 
-       memset(trigger_config, 0, 16);
-       trigger_config[devc->num_stages] |= 0x08;
-       if (devc->trigger_mask[0]) {
+       /* Basic triggers. */
+       if (devc->trigger_mask[0] != 0x00000000) {
+               /* At least one probe has a trigger on it. */
                delaycount = readcount * (1 - devc->capture_ratio / 100.0);
                devc->trigger_at = (readcount - delaycount) * 4 - devc->num_stages;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_0,
-                       reverse32(devc->trigger_mask[0])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_0,
-                       reverse32(devc->trigger_value[0])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_0,
-                       trigger_config[0]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_1,
-                       reverse32(devc->trigger_mask[1])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_1,
-                       reverse32(devc->trigger_value[1])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_1,
-                       trigger_config[1]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_2,
-                       reverse32(devc->trigger_mask[2])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_2,
-                       reverse32(devc->trigger_value[2])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_2,
-                       trigger_config[2]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_3,
-                       reverse32(devc->trigger_mask[3])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_3,
-                       reverse32(devc->trigger_value[3])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_3,
-                       trigger_config[3]) != SR_OK)
-                       return SR_ERR;
+               for (i = 0; i <= devc->num_stages; i++) {
+                       sr_dbg("Setting stage %d trigger.", i);
+                       if ((ret = set_trigger(sdi, i)) != SR_OK)
+                               return ret;
+               }
        } else {
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_0,
-                               devc->trigger_mask[0]) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_0,
-                               devc->trigger_value[0]) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_0,
-                    0x00000008) != SR_OK)
-                       return SR_ERR;
+               /* No triggers configured, force trigger on first stage. */
+               sr_dbg("Forcing trigger at stage 0.");
+               if ((ret = set_trigger(sdi, 0)) != SR_OK)
+                       return ret;
                delaycount = readcount;
        }
 
        /* Samplerate. */
-       sr_info("Setting samplerate to %" PRIu64 "Hz (divider %u)",
+       sr_dbg("Setting samplerate to %" PRIu64 "Hz (divider %u)",
                        devc->cur_samplerate, devc->cur_samplerate_divider);
-       if (send_longcommand(serial, CMD_SET_DIVIDER,
-                       reverse32(devc->cur_samplerate_divider)) != SR_OK)
+       arg[0] = devc->cur_samplerate_divider & 0xff;
+       arg[1] = (devc->cur_samplerate_divider & 0xff00) >> 8;
+       arg[2] = (devc->cur_samplerate_divider & 0xff0000) >> 16;
+       arg[3] = 0x00;
+       if (send_longcommand(serial, CMD_SET_DIVIDER, arg) != SR_OK)
                return SR_ERR;
 
        /* Send sample limit and pre/post-trigger capture ratio. */
-       sr_info("Setting sample limit %d, trigger point at %d",
+       sr_dbg("Setting sample limit %d, trigger point at %d",
                        (readcount - 1) * 4, (delaycount - 1) * 4);
-       data = ((readcount - 1) & 0xffff) << 16;
-       data |= (delaycount - 1) & 0xffff;
-       if (send_longcommand(serial, CMD_CAPTURE_SIZE, reverse16(data)) != SR_OK)
+       arg[0] = ((readcount - 1) & 0xff);
+       arg[1] = ((readcount - 1) & 0xff00) >> 8;
+       arg[2] = ((delaycount - 1) & 0xff);
+       arg[3] = ((delaycount - 1) & 0xff00) >> 8;
+       if (send_longcommand(serial, CMD_CAPTURE_SIZE, arg) != SR_OK)
                return SR_ERR;
 
        /* Flag register. */
-       sr_info("Setting demux %s, noise_filter %s, extpat %s, intpat %s",
+       sr_dbg("Setting demux %s, noise_filter %s, extpat %s, intpat %s",
                        devc->flag_reg & FLAG_DEMUX ? "on" : "off",
                        devc->flag_reg & FLAG_FILTER ? "on": "off",
                        devc->flag_reg & FLAG_EXTERNAL_TEST_MODE ? "on": "off",
                        devc->flag_reg & FLAG_INTERNAL_TEST_MODE ? "on": "off");
        /* 1 means "disable channel". */
        devc->flag_reg |= ~(changrp_mask << 2) & 0x3c;
-       data = (devc->flag_reg << 24) | ((devc->flag_reg << 8) & 0xff0000);
-       if (send_longcommand(serial, CMD_SET_FLAGS, data) != SR_OK)
+       arg[0] = devc->flag_reg & 0xff;
+       arg[1] = devc->flag_reg >> 8;
+       arg[2] = arg[3] = 0x00;
+       if (send_longcommand(serial, CMD_SET_FLAGS, arg) != SR_OK)
                return SR_ERR;
 
        /* Start acquisition on the device. */
index 742025ce2a4f13e99012b3ee8a5ca159dfb76479..1762dc45084831a61af3c662d00f6f1703db24c3 100644 (file)
@@ -37,16 +37,17 @@ SR_PRIV int send_shortcommand(struct sr_serial_dev_inst *serial,
 }
 
 SR_PRIV int send_longcommand(struct sr_serial_dev_inst *serial,
-               uint8_t command, uint32_t data)
+               uint8_t command, uint8_t *data)
 {
        char buf[5];
 
-       sr_dbg("Sending cmd 0x%.2x data 0x%.8x.", command, data);
+       sr_dbg("Sending cmd 0x%.2x data 0x%.2x%.2x%.2x%.2x.", command,
+                       data[0], data[1], data[2], data[3]);
        buf[0] = command;
-       buf[1] = (data & 0xff000000) >> 24;
-       buf[2] = (data & 0xff0000) >> 16;
-       buf[3] = (data & 0xff00) >> 8;
-       buf[4] = data & 0xff;
+       buf[1] = data[0];
+       buf[2] = data[1];
+       buf[3] = data[2];
+       buf[4] = data[3];
        if (serial_write_blocking(serial, buf, 5) != 5)
                return SR_ERR;
 
@@ -97,11 +98,8 @@ SR_PRIV int ols_configure_probes(const struct sr_dev_inst *sdi)
                        if (*tc == '1')
                                devc->trigger_value[stage] |= probe_bit;
                        stage++;
-                       if (stage > 3)
-                               /*
-                                * TODO: Only supporting parallel mode, with
-                                * up to 4 stages.
-                                */
+                       /* Only supporting parallel mode, with up to 4 stages. */
+                       if (stage > 4)
                                return SR_ERR;
                }
                if (stage > devc->num_stages)
@@ -111,30 +109,6 @@ SR_PRIV int ols_configure_probes(const struct sr_dev_inst *sdi)
        return SR_OK;
 }
 
-SR_PRIV uint32_t reverse16(uint32_t in)
-{
-       uint32_t out;
-
-       out = (in & 0xff) << 8;
-       out |= (in & 0xff00) >> 8;
-       out |= (in & 0xff0000) << 8;
-       out |= (in & 0xff000000) >> 8;
-
-       return out;
-}
-
-SR_PRIV uint32_t reverse32(uint32_t in)
-{
-       uint32_t out;
-
-       out = (in & 0xff) << 24;
-       out |= (in & 0xff00) << 8;
-       out |= (in & 0xff0000) >> 8;
-       out |= (in & 0xff000000) >> 24;
-
-       return out;
-}
-
 SR_PRIV struct dev_context *ols_dev_new(void)
 {
        struct dev_context *devc;
@@ -218,7 +192,7 @@ SR_PRIV struct sr_dev_inst *get_metadata(struct sr_serial_dev_inst *serial)
                        /* 32-bit unsigned integer */
                        if (serial_read_blocking(serial, &tmp_int, 4) != 4)
                                break;
-                       tmp_int = reverse32(tmp_int);
+                       tmp_int = RB32(&tmp_int);
                        sr_dbg("Got metadata key 0x%.2x value 0x%.8x.",
                               key, tmp_int);
                        switch (token) {
index 333605eeefd46ef5b6fa3e8d1e57a17e0d38f9a9..2d6f57f798ee9f49ff6dcc0887f7f62dbd463aec 100644 (file)
 #define CMD_SET_FLAGS              0x82
 #define CMD_SET_DIVIDER            0x80
 #define CMD_CAPTURE_SIZE           0x81
-#define CMD_SET_TRIGGER_MASK_0     0xc0
-#define CMD_SET_TRIGGER_MASK_1     0xc4
-#define CMD_SET_TRIGGER_MASK_2     0xc8
-#define CMD_SET_TRIGGER_MASK_3     0xcc
-#define CMD_SET_TRIGGER_VALUE_0    0xc1
-#define CMD_SET_TRIGGER_VALUE_1    0xc5
-#define CMD_SET_TRIGGER_VALUE_2    0xc9
-#define CMD_SET_TRIGGER_VALUE_3    0xcd
-#define CMD_SET_TRIGGER_CONFIG_0   0xc2
-#define CMD_SET_TRIGGER_CONFIG_1   0xc6
-#define CMD_SET_TRIGGER_CONFIG_2   0xca
-#define CMD_SET_TRIGGER_CONFIG_3   0xce
+#define CMD_SET_TRIGGER_MASK       0xc0
+#define CMD_SET_TRIGGER_VALUE      0xc1
+#define CMD_SET_TRIGGER_CONFIG     0xc2
+
+/* Trigger config */
+#define TRIGGER_START              (1 << 3)
 
 /* Bitmasks for CMD_FLAGS */
-#define FLAG_DEMUX                 0x01
-#define FLAG_FILTER                0x02
-#define FLAG_CHANNELGROUP_1        0x04
-#define FLAG_CHANNELGROUP_2        0x08
-#define FLAG_CHANNELGROUP_3        0x10
-#define FLAG_CHANNELGROUP_4        0x20
-#define FLAG_CLOCK_EXTERNAL        0x40
-#define FLAG_CLOCK_INVERTED        0x80
-#define FLAG_RLE                   0x0100
-#define FLAG_SWAP_PROBES           0x0200
-#define FLAG_EXTERNAL_TEST_MODE    0x0400
-#define FLAG_INTERNAL_TEST_MODE    0x0800
+/* 12-13 unused, 14-15 RLE mode (we hardcode mode 0). */
+#define FLAG_INTERNAL_TEST_MODE    (1 << 11)
+#define FLAG_EXTERNAL_TEST_MODE    (1 << 10)
+#define FLAG_SWAP_PROBES           (1 << 9)
+#define FLAG_RLE                   (1 << 8)
+#define FLAG_SLOPE_FALLING         (1 << 7)
+#define FLAG_CLOCK_EXTERNAL        (1 << 6)
+#define FLAG_CHANNELGROUP_4        (1 << 5)
+#define FLAG_CHANNELGROUP_3        (1 << 4)
+#define FLAG_CHANNELGROUP_2        (1 << 3)
+#define FLAG_CHANNELGROUP_1        (1 << 2)
+#define FLAG_FILTER                (1 << 1)
+#define FLAG_DEMUX                 (1 << 0)
 
 /* Private, per-device-instance driver context. */
 struct dev_context {
@@ -90,7 +85,7 @@ struct dev_context {
        uint32_t trigger_mask[4];
        uint32_t trigger_value[4];
        int num_stages;
-       uint32_t flag_reg;
+       uint16_t flag_reg;
 
        /* Operational states */
        unsigned int num_transfers;
@@ -110,10 +105,8 @@ SR_PRIV extern const char *ols_probe_names[NUM_PROBES + 1];
 SR_PRIV int send_shortcommand(struct sr_serial_dev_inst *serial,
                uint8_t command);
 SR_PRIV int send_longcommand(struct sr_serial_dev_inst *serial,
-               uint8_t command, uint32_t data);
+               uint8_t command, uint8_t *data);
 SR_PRIV int ols_configure_probes(const struct sr_dev_inst *sdi);
-SR_PRIV uint32_t reverse16(uint32_t in);
-SR_PRIV uint32_t reverse32(uint32_t in);
 SR_PRIV struct dev_context *ols_dev_new(void);
 SR_PRIV struct sr_dev_inst *get_metadata(struct sr_serial_dev_inst *serial);
 SR_PRIV int ols_set_samplerate(const struct sr_dev_inst *sdi,