]> sigrok.org Git - pulseview.git/commit
Fix CMake CXX_STANDARD handling
authorSoeren Apel <redacted>
Fri, 8 Sep 2023 19:15:11 +0000 (21:15 +0200)
committerSoeren Apel <redacted>
Fri, 8 Sep 2023 19:15:11 +0000 (21:15 +0200)
commitcb40d40c6c60f2b1bec744ad946253e3d8c56c13
treee3c6ffe6b94c4a92730fc1b4414b7dc3eb902386
parente0a90b4c5d6b1163a2cbece13a90f2737f0814d4
Fix CMake CXX_STANDARD handling

https://sigrok.org/gitweb/?p=pulseview.git;a=commit;f=CMakeLists.txt;h=fa8d0fcb4cff4f19943fe3ff152dc1428b400b01 introduced a CXX_STANDARD value of 17 while still only requiring cmake 2.8.12.

However, https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html#cxx-standard shows that a value of 17 was introduced with cmake 3.8, leading to

"CXX_STANDARD is set to invalid value '17'" when trying to build with cmake < 3.8.

Hence, for versions below 3.8, we only check for up to 14.
CMakeLists.txt