]> sigrok.org Git - pulseview.git/commit
Fix bug #285 by handling device display names through DeviceManager
authorSoeren Apel <redacted>
Fri, 7 Nov 2014 16:11:30 +0000 (17:11 +0100)
committerBert Vermeulen <redacted>
Sun, 9 Nov 2014 13:15:58 +0000 (14:15 +0100)
commita4cf020a253c8c874ed8652f38a1c61c9a4754a4
treef915635ede21a5f9083ef5c05a4431c349bc9fd1
parentcbe9f991ccfc62182cddb758c69bc5d90f30302f
Fix bug #285 by handling device display names through DeviceManager
Currently, DeviceManager::device_description() is used to determine
how a device should appear in the device selector combobox. This is
problematic because bug #285 requests that a device should show
the extra information only when multiple such devices are present.
Without having access to all devices attached to a particular driver,
this cannot be solved.

This patch makes it possible by creating each device's display name
in the DeviceManager class and storing it there. This way, they
can be constructed while having access to all devices and
transparently queried by anyone who needs them.

With this, bug #285 can easily be solved.
pv/devicemanager.cpp
pv/devicemanager.h
pv/dialogs/connect.cpp
pv/mainwindow.cpp
pv/sigsession.cpp