Bug 998 - Zoom to fit when acquisition stops doesn't work for files
Summary: Zoom to fit when acquisition stops doesn't work for files
Status: RESOLVED WORKSFORME
Alias: None
Product: PulseView
Classification: Unclassified
Component: Data display (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: PulseView 0.5.0
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-22 15:26 CEST by Uwe Hermann
Modified: 2018-06-16 17:47 CEST (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2017-07-22 15:26:25 CEST 
The "Zoom to fit when acquisition stops" feature works fine with devices, but not for .sr file apparently. This can be reproduced e.g. with a long file such as dcf77_480s.sr.
Comment 1 Gerhard Sittig 2018-02-04 12:45:55 CET 
It just worked for me for the dcf77_480s.sr file that you mention, as well as 
for other files (VCD from bug 360).  Does the issue still reproduce, or could 
it have been fixed in the meantime?
Comment 2 Soeren Apel 2018-05-30 23:18:37 CEST 
*bump*
Comment 3 Soeren Apel 2018-06-02 23:37:23 CEST 
I can't reproduce the issue.

Do keep in mind, btw, that changing the view in any way while the file is loading means that the zoom-to-fit will *not* be performed after the file loaded. The rationale for this behavior is that we don't want to mess up the user's view if he/she wanted to start examining the file before it loaded fully.
Comment 4 Uwe Hermann 2018-06-16 17:47:10 CEST 
Can't reproduce anymore either, closing the bug.

Either this was fixed in the mean time or I accidentally clicked / dragged the trace in my tests without noticing or something like that.

I fully agree with the rationale you mentioned, that works exactly like it should indeed.