Bug 985 - Build issue on some Mac OS X systems due to boost-related warning/error
Summary: Build issue on some Mac OS X systems due to boost-related warning/error
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Build system (show other bugs)
Version: unreleased development snapshot
Hardware: All Mac OS X
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-15 19:13 CEST by Uwe Hermann
Modified: 2020-05-22 12:41 CEST (History)
1 user (show)



Attachments
PV boost issue on Mac OS X (9.37 KB, text/plain)
2017-06-15 19:13 CEST, Uwe Hermann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2017-06-15 19:13:21 CEST
Created attachment 311 [details]
PV boost issue on Mac OS X

As reported by dekar on IRC there seem to be some boost-related warnings (errors with -Werror) on some Mac OS X setups, see attached log.

I personally cannot reproduce this atm., but it could be related to compiler/XCode/library versions or such. Further investigation pending.
Comment 1 Soeren Apel 2017-06-15 19:25:33 CEST
We should probably use -isystem or -cxx-isystem instead of -I to include boost headers.

References:

https://stackoverflow.com/questions/39241569/boost-static-warning-in-xcode ("Boost is error-free, but it does not purport itself as warning free.")

https://jira.lsstcorp.org/browse/DM-5394 ("An alternative I've previously suggested is that we include headers from external packages like Boost using -isystem rather than -I. The GCC manual suggests -isystem should be used for "vendor supplied" headers, and GCC will suppress warnings encountered within them.")

and

https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-in-system-headers
Comment 2 Uwe Hermann 2020-05-22 12:41:23 CEST
Closing this one, current git HEAD builds fine on two different Mac OS X boxes with two different Mac OS X versions, homebrew setups and compiler/boost versions.

Some unrelated upcoming changes will auto-improve Boost usage via cmake either way, as well.