Bug 974 - output/srzip should combine received datafeed packets when applicable
Summary: output/srzip should combine received datafeed packets when applicable
Status: RESOLVED FIXED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Output: srzip (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-08 22:48 CEST by Gerhard Sittig
Modified: 2020-07-24 12:13 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerhard Sittig 2017-06-08 22:48:42 CEST 
Research for bug 695 revealed that the srzip output module adds one 
ZIP member per received datafeed packet to the output file, which can be 
as stupid as one logic-1-N file per byte in the input stream.  This is 
killing performance (slowdown orders of magnitude).

Received datafeed packets should get accumulated when they are small, 
and output file content should be written in sensible chunks.  This will 
protect against inefficiencies in other input modules.
Comment 1 Gerhard Sittig 2020-07-16 10:31:53 CEST 
More research was done in bug 762. Several workarounds were suggested there 
(outputting to VCD or raw binary), until the bottleneck in the .sr output 
module gets addressed.
Comment 2 Gerhard Sittig 2020-07-24 12:13:21 CEST 
Fixed in libsigrok c03aaf342c3f. Now collects up to 4MiB of data for ZIP updates.