Bug 955 - Analog data must be processed via sr_analog_to_float()
Summary: Analog data must be processed via sr_analog_to_float()
Status: RESOLVED INVALID
Alias: None
Product: sigrok-cli
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: High blocker
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-26 23:27 CEST by Soeren Apel
Modified: 2018-09-20 03:56 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2017-05-26 23:27:04 CEST 
In the past, analog data was always of type float. This changed and other data types can now be used. In order to make sigrok-cli cope with this, it should pass the data through sr_analog_to_float() if the payload's is_float() flag isn't set.

Until this is done, non-float analog data will not be processed correctly.
Comment 1 Martin Ling 2017-05-30 04:45:44 CEST 
Why does sigrok-cli need to do any conversion? Doesn't it just pass everything through to output modules?
Comment 2 Soeren Apel 2017-05-30 07:20:42 CEST 
You're right, I only remembered "sigrok-cli doesn't behave as expected" and because I didn't dive into this, figured it would be because of not using sr_analog_to_float() as well.

From #950: "Reproduction shows that sigrok-cli does not present expected values either"

If sigrok-cli shows the correct values on the console output then this one should be closed indeed.
Comment 3 Martin Ling 2017-05-30 12:37:50 CEST 
Even if sigrok-cli doesn't show the right values, the bug needs to be assigned to either the input or output module responsible. There's no code in sigrok-cli that actually touches the data.
Comment 4 Martin Ling 2018-09-20 03:56:53 CEST 
Closing as invalid; there was never a sigrok-cli bug here. The problems seen in the mentioned bug #950 have now been solved by fixes to the raw_analog input module and the analog output module, with no change needed to sigrok-cli.