Bug 743 - Pressing DEL after selecting a marker should remove it
Summary: Pressing DEL after selecting a marker should remove it
Status: RESOLVED WORKSFORME
Alias: None
Product: PulseView
Classification: Unclassified
Component: Markers (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-31 21:28 CET by Soeren Apel
Modified: 2019-12-21 23:48 CET (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2016-01-31 21:28:06 CET 
Currently however, selecting a marker causes its popup to appear, making the DEL keypress go to the edit.
Comment 1 Soeren Apel 2019-12-21 23:48:03 CET 
Bug is invalid.

Deleting works just fine when the marker is selected and the popup is closed, e.g. using the ESC key.

Deleting the marker by pressing delete with the popup open is something I don't think we need to support. It's would also require that the focus not be on the QLineEdit when the popup shows because otherwise, the text is deleted instead of the marker being deleted.

However, clicking on a marker and typing away to change its name is the primary purpose of the marker's popup while pressing delete is expected to be used muss less often in comparison.