Bug 366 - decoderstack unit test fails
Summary: decoderstack unit test fails
Alias: None
Product: PulseView
Classification: Unclassified
Component: Unit tests (show other bugs)
Version: unreleased development snapshot
Hardware: x86 Linux
: Normal normal
Target Milestone: ---
Assignee: Nobody
Depends on: 454
  Show dependency treegraph
Reported: 2014-06-10 03:29 CEST by jens.steinhauser
Modified: 2015-09-23 15:52 CEST (History)
3 users (show)


Note You need to log in before you can comment on or make changes to this bug.
Description jens.steinhauser 2014-06-10 03:29:51 CEST
Running the pulseview-test binary yields:

unknown location(0): fatal error in "TwoDecoderStack": std::runtime_error: Invalid argument
.../pulseview/test/data/decoderstack.cpp(74): last checkpoint

A quick step through with the debugger shows that upon adding the decoder to the SigSession, the "Check that all decoders have the required channels" check in "DecoderStack::begin_decode()" fails, the "_decode_thread" member never gets assigned a valid thread, and the unit test then tries to "join()" a default constructed thread object.
Comment 1 Soeren Apel 2015-08-16 14:42:09 CEST
The TwoDecoderStack test is currently disabled. Is it really a blocker for the PV 0.3.0 release? Just wondering about criticality, that's all.
Comment 2 Uwe Hermann 2015-08-21 17:42:57 CEST
No, certainly not a blocker for a release, but it would be nice to have it fixed nonetheless.
Comment 3 Uwe Hermann 2015-09-23 15:52:47 CEST
Dropping target milestone 0.3.0, not release-critical.