Bug 1831 - Rigol DS1xxxZ Plus has 16 digital ports but PulseView ignores them
Summary: Rigol DS1xxxZ Plus has 16 digital ports but PulseView ignores them
Status: RESOLVED FIXED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Driver: rigol-ds (show other bugs)
Version: 0.5.2
Hardware: All All
: Normal major
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-06 22:00 CET by Aristarchos
Modified: 2023-09-27 23:10 CEST (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aristarchos 2023-03-06 22:00:08 CET
Got a DS1104Z Plus and an attached RPL1116.
The DS1xxxZ Plus models are MSO ready, they contain the connector to attach a RPL1116 16 port digital head.
Having a DS1xxxZ Plus and a connected RPL1116 effectively the instrument becomes a MSO1xxxZ.

PulseView determines the instrument's abilities by examining the instrument's reported ID string, so for the DS1104Z Plus it gives attributes from here

https://github.com/sigrokproject/libsigrok/blob/0db1b189bee3ffe5c6ea39d7ca2e62715856b538/src/hardware/rigol-ds/api.c#L277

But that "CH_INFO(4, false)" means 4 analog channels and NO digital channels!
As said though, the DS1xxxZ Plus variants got the D0..D15 digital ports abilities already so this line treats The DS1xxxZ Plus as a plzin DS1xxxZ without the digital ports.

A very simple remedy would be to change the CH_INFO(4, false) to CH_INFO(4, true)
So those two lines should be
from
{SERIES(DS1000Z), "DS1074Z Plus", {5, 1000000000}, CH_INFO(4, false), std_cmd},
{SERIES(DS1000Z), "DS1104Z Plus", {5, 1000000000}, CH_INFO(4, false), std_cmd},
to
{SERIES(DS1000Z), "DS1074Z Plus", {5, 1000000000}, CH_INFO(4, true), std_cmd},
{SERIES(DS1000Z), "DS1104Z Plus", {5, 1000000000}, CH_INFO(4, true), std_cmd},
and the problem will be solved.

Please perform these changes and provide new compiled installers so our instruments be fully utilized.

Regards,
Aristarchos
Comment 1 Aristarchos 2023-03-12 11:27:52 CET
Asked Rigol about the reported ID from the instrument regarding "DS1xxxZ Plus" and "MSO1xxxZ".
There is an official email reply from Rigol support regarding ID reported from the instrument:
"We stopped the sales of MSO versions in 2018 and offered only DS1000Z Plus version (with the principle, when customer require the MSO functionality, to purchase the logic probe).
So the name is DS10xxZ Plus and not MSO."

So with this reply from Rigol becomes evident that the IDs "DS1074Z Plus" and "DS1104Z Plus" should be treated from libsigrok with D0..D15 digitaql ports ability and that is effective since 2018.



From: Boris A****g <******@rigol.com>
Date: Mon, Mar 6, 2023 at 5:17 PM
Subject: RE: You got one.RIGOL Technologies EU GmbHCustomer message
To: ****** <******>
Cc: ****** <******@rigol.com>

Hi ******,

Brian is now on business trip, so I will answer.

We stopped the sales of MSO versions in 2018 and offered only DS1000Z Plus version (with the principle, when customer require the MSO functionality, to purchase the logic probe).

So the name is DS10xxZ Plus and not MSO. This name will and cannot be changed.

Best regards,

Boris

Mit freundlichen Grüßen/With best regards
Boris A****g
RIGOL Technologies EU GmbH
Carl-Benz-Str. 11
82205 Gilching
+49 (0)8105 - 27292-16
E-Mail: ******@rigol.com
Comment 2 Aristarchos 2023-03-17 07:46:03 CET
Submitted a pull request to libsigrok implementing the solution proposed for Rigol DS1xxxX Plus with RPL1116

https://github.com/sigrokproject/libsigrok/pull/214